From 54dce7f5d81a1f89061d19bdae657625273d5faa Mon Sep 17 00:00:00 2001 From: Gunnar Mills Date: Fri, 5 Aug 2022 17:01:32 +0000 Subject: Add redfish-oem-manager-fan-data option IBM doesn't use the Redfish OEM fan data in OemManager. IBM does not use phosphor-pid-control instead using phosphor-fan-presence and such. This is data such as PidControllers, StepwiseControllers, FanZones, FanControllers, and Profile. This has been in bmcweb since Oct 2018 so defaulting this flag to enabled to not break anyone. Why we want a flag: 1) Have observed 500 errors with getting the thermalMode. "Jan 24 16:34:57 rain534 bmcweb[435]: (2022-01-24 16:34:57) [ERROR "managers.hpp":1196] GetPIDValues: Can't get thermalModeIface /xyz/openbmc_project/control/thermal/0" 2) This Redfish OEM fan data includes PATCHing. Commit turning this off in meta-ibm: https://gerrit.openbmc.org/c/openbmc/openbmc/+/56327 Tested: With this flag enabled and disabled. Manager resource looks as expected. Before on a dummy PATCH to this: curl -k -X PATCH https://$bmc/redfish/v1/Managers/bmc -d \ '{"Oem":{"OpenBmc":{"Fan":{"Profile":"Acoustic"}}}}' { "error": { "@Message.ExtendedInfo": [ { "@odata.type": "#Message.v1_1_1.Message", "Message": "The request failed due to an internal service... With this change and the meta-ibm change (instead see a PropertyUnknown) curl -k -X PATCH https://$bmc/redfish/v1/Managers/bmc -d \ '{"Oem":{"OpenBmc":{"Fan":{"Profile" : "Acoustic"} }}}' { "error": { "@Message.ExtendedInfo": [ { "@odata.type": "#Message.v1_1_1.Message", "Message": "The property %1 is not in the list of valid... "MessageArgs": [ "Oem" ], "MessageId": "Base.1.13.0.PropertyUnknown", PATCHed the DateTime with this enabled. Change-Id: I374292ca2798e096b18d49df5bbc7a93c7f1c400 Signed-off-by: Gunnar Mills --- meson_options.txt | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'meson_options.txt') diff --git a/meson_options.txt b/meson_options.txt index a32a4a4f99..ecc7aebc22 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -223,6 +223,15 @@ option( Option will be removed Q4 2022.''' ) +option( + 'redfish-oem-manager-fan-data', + type: 'feature', + value: 'enabled', + description: '''Enables Redfish OEM fan data on the manager resource. + This includes PID and Stepwise controller data. See + OemManager schema for more detail.''' +) + option( 'https_port', type: 'integer', -- cgit v1.2.3