From 456cd875f3c56b45605d8a017e91d810876a035c Mon Sep 17 00:00:00 2001 From: Szymon Dompke Date: Tue, 1 Mar 2022 16:34:08 +0100 Subject: Use url_view for telemetry uris This change refactor telemetry code to use bmcweb utility function for uri construction, which is safe and preferred way, instead of string operations. Testing done: - Some basic GET operations done on Telemetry, no regression. Signed-off-by: Szymon Dompke Change-Id: I6de5d79a078944d398357f27dc0c201c130c4302 --- redfish-core/include/event_service_manager.hpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'redfish-core/include/event_service_manager.hpp') diff --git a/redfish-core/include/event_service_manager.hpp b/redfish-core/include/event_service_manager.hpp index 90c7e87a4f..759c798820 100644 --- a/redfish-core/include/event_service_manager.hpp +++ b/redfish-core/include/event_service_manager.hpp @@ -504,14 +504,16 @@ class Subscription : public persistent_data::UserSubscription void filterAndSendReports(const std::string& reportId, const telemetry::TimestampReadings& var) { - std::string mrdUri = telemetry::metricReportDefinitionUri + ("/" + id); + boost::urls::url mrdUri = + crow::utility::urlFromPieces("redfish", "v1", "TelemetryService", + "MetricReportDefinitions", reportId); // Empty list means no filter. Send everything. if (!metricReportDefinitions.empty()) { if (std::find(metricReportDefinitions.begin(), metricReportDefinitions.end(), - mrdUri) == metricReportDefinitions.end()) + mrdUri.string()) == metricReportDefinitions.end()) { return; } -- cgit v1.2.3