From 1ddcf01a159779cb5af2992b8f1e8ba9ab7484a5 Mon Sep 17 00:00:00 2001
From: "Jason M. Bills" <jason.m.bills@linux.intel.com>
Date: Tue, 26 Nov 2019 14:59:21 -0800
Subject: Return a 404 instead of 500 for invalid Crashdump URIs

Tested:
Used a browser to request an invalid Crashdump URI and got a
404 with a resource not found error.

Change-Id: Idcac7868bb1f3b4c0248926b46be2cf4fce05328
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>
---
 redfish-core/lib/log_services.hpp | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

(limited to 'redfish-core')

diff --git a/redfish-core/lib/log_services.hpp b/redfish-core/lib/log_services.hpp
index 0f4a90226f..3eb4097bf9 100644
--- a/redfish-core/lib/log_services.hpp
+++ b/redfish-core/lib/log_services.hpp
@@ -25,6 +25,7 @@
 #include <boost/algorithm/string/split.hpp>
 #include <boost/beast/core/span.hpp>
 #include <boost/container/flat_map.hpp>
+#include <boost/system/linux_error.hpp>
 #include <error_messages.hpp>
 #include <filesystem>
 #include <string_view>
@@ -1625,7 +1626,15 @@ static void logCrashdumpEntry(std::shared_ptr<AsyncResp> asyncResp,
         if (ec)
         {
             BMCWEB_LOG_DEBUG << "failed to get log ec: " << ec.message();
-            messages::internalError(asyncResp->res);
+            if (ec.value() ==
+                boost::system::linux_error::bad_request_descriptor)
+            {
+                messages::resourceNotFound(asyncResp->res, "LogEntry", logID);
+            }
+            else
+            {
+                messages::internalError(asyncResp->res);
+            }
             return;
         }
         const std::string *log = std::get_if<std::string>(&resp);
-- 
cgit v1.2.3