From d32c4fa936f9a88fc1dd124201ed11a6a90a18c5 Mon Sep 17 00:00:00 2001 From: Ed Tanous Date: Tue, 14 Sep 2021 13:16:51 -0700 Subject: Boost uri update Update to the latest version of boost::uri The newest version of boost uri makes some breaking changes that we need to account for. At the same time, we take the opportunity to move to the error code based parse methods that don't rely on exceptions. The biggest changes are: The standalone build is no longer present. A discussion with the boost::url maintainers shows that our best option is to do a simple copy of the headers, and compile boost/url/src.hpp in a separate file. This is intended to allow people to pull the library in "standalone" and not have to rely on the build machinery in boost-url, which we don't really need. Interestingly, this file doesn't have a newline at the end, which clang correctly flags. OpenBMC doesn't really need that warning, as we rely on clang-format to do that, so we add -Wno-newline-eof clang to get the code to compile there. All url parsers are moved to the parse_uri, or parse_relative_uri equivalents. This slightly tightens the requirements around what URLs are accepted, but in no ways that should break anything. (Ie, "/redfish/v1" is no longer accepted for a virtual media endpoint. boost::urls::url_view::params_type has been renamed to query_params_type, and the relevant methods have been updated. Because of the missing standalone mode, we now need to use boost::string_view which doesn't implicitly construct from std::string_view. Some discussion on the boost list shows that this is coming soon, so that cruft can eventually be cleaned up, but for now we need the construction. Tested: Loaded in qemu, and ran some URLs (/redfish/v1 and /redfish/v1/Chassis) to ensure that the url handler functions as intended. Signed-off-by: Ed Tanous Change-Id: I5843776d4ec01b4d92af2ee3a9cf1ebb1d920ae7 --- subprojects/boost-url.wrap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'subprojects') diff --git a/subprojects/boost-url.wrap b/subprojects/boost-url.wrap index c41d2d119e..3d00dcf8cc 100644 --- a/subprojects/boost-url.wrap +++ b/subprojects/boost-url.wrap @@ -1,3 +1,3 @@ [wrap-git] -revision = a56ae0df6d3078319755fbaa67822b4fa7fd352b +revision = 4f712ed69a04a344957d22efa5dc111b415b3aff url = https://github.com/CPPAlliance/url.git \ No newline at end of file -- cgit v1.2.3