diff options
| author | Paul Fertser <fercerpav@gmail.com> | 2023-04-25 10:51:27 +0300 |
|---|---|---|
| committer | Paul Fertser <fercerpav@gmail.com> | 2023-04-25 10:51:27 +0300 |
| commit | 321a95f8e0413365a569da6438ac748591bd1a68 (patch) | |
| tree | ed37ed7afb99d668935b28a78c641139c7ba4d43 | |
| parent | 0ee1477590855a05ac2e7b1769a190e65aa5ebad (diff) | |
| download | openbmc-321a95f8e0413365a569da6438ac748591bd1a68.tar.xz | |
meta-phosphor: initrdscripts: fix flash update
We need word splitting on IFS for this variable to prevent "watchdog:
invalid number ' 1 -T 5'" error which ruins the update (hardware
watchdog reboots the system during the process) and results in
unbootable BMC firmware after restart.
Fixes: 51d6af4e64f0 ("meta-phosphor: initrdscripts: fix shellcheck issues")
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Change-Id: Ic8d5cb8eb390075b181e2a2a73c27e0d000f6c56
| -rw-r--r-- | meta-phosphor/recipes-phosphor/initrdscripts/files/obmc-shutdown.sh | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/meta-phosphor/recipes-phosphor/initrdscripts/files/obmc-shutdown.sh b/meta-phosphor/recipes-phosphor/initrdscripts/files/obmc-shutdown.sh index 363a1a306b..2de0937ce3 100644 --- a/meta-phosphor/recipes-phosphor/initrdscripts/files/obmc-shutdown.sh +++ b/meta-phosphor/recipes-phosphor/initrdscripts/files/obmc-shutdown.sh @@ -43,7 +43,8 @@ then if test -c /dev/watchdog then echo Pinging watchdog ${wdt+with args $wdt} - watchdog "$wdt" -F /dev/watchdog & + # shellcheck disable=SC2086 + watchdog $wdt -F /dev/watchdog & wd=$! else wd= |