diff options
| author | Charles Boyer <Charles.Boyer@fii-usa.com> | 2021-11-25 00:58:03 +0300 |
|---|---|---|
| committer | Charles Boyer <Charles.Boyer@fii-usa.com> | 2022-01-18 19:39:26 +0300 |
| commit | 2adad365773fb2018fb65d5dbbd2ab5b9c68d97d (patch) | |
| tree | 378a25c014f0f1cfcdcb3a32f70e6baffb708937 /meta-fii/meta-kudo/recipes-phosphor/fans | |
| parent | a4c5b7f99891bd08d5c11b88f7abbc57b2ab8ea6 (diff) | |
| download | openbmc-2adad365773fb2018fb65d5dbbd2ab5b9c68d97d.tar.xz | |
meta-fii/meta-kudo: Organize executables to follow anti-patterns.md
According to
https://github.com/openbmc/docs/blob/master/anti-patterns.md,
/usr/sbin is reserved for system administration executables. The
executables called by services or internal use are placed in
/usr/libexec/<package>.
Executables kept in /usr/sbin,
- kudo.sh
- kudo-ras.sh
- kudo-fw.sh
Executables moved to /usr/libexec,
- ampere-hostctrl/ampere_power_util.sh
- kudo-fw/kudo-fw-ver.sh
- kudo-fw/kudo-lib.sh
- kudo-boot/init_once.sh
- usb-network/usb_network.sh
- obmc-console/kudo_uart_mux_ctrl.sh
- pwm-init/pwm_init.sh
- phosphor-virtual-sensor/tla2024-enable.sh
Also removed /usr/bin/env from service files.
Signed-off-by: Charles Boyer <Charles.Boyer@fii-usa.com>
Change-Id: I270eee5cb9c0ca248f1b84a87d1cff5c6dc129f3
Diffstat (limited to 'meta-fii/meta-kudo/recipes-phosphor/fans')
| -rw-r--r-- | meta-fii/meta-kudo/recipes-phosphor/fans/pwm-init.bb | 4 | ||||
| -rw-r--r-- | meta-fii/meta-kudo/recipes-phosphor/fans/pwm-init/pwm_init.service | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/meta-fii/meta-kudo/recipes-phosphor/fans/pwm-init.bb b/meta-fii/meta-kudo/recipes-phosphor/fans/pwm-init.bb index f4b04e60bc..97daab696e 100644 --- a/meta-fii/meta-kudo/recipes-phosphor/fans/pwm-init.bb +++ b/meta-fii/meta-kudo/recipes-phosphor/fans/pwm-init.bb @@ -22,8 +22,8 @@ SYSTEMD_SERVICE:${PN} += "pwm_init.service" FILES:${PN} += "${bindir}/* ${systemd_system_unitdir}/*" do_install:append() { - install -d ${D}${bindir} - install -m 0755 ${S}/bin/* ${D}${bindir}/ + install -d ${D}${libexecdir}/${PN} + install -m 0755 ${S}/bin/* ${D}${libexecdir}/${PN}/ install -d ${D}${systemd_system_unitdir} install -m 0644 ${S}/*.service ${D}${systemd_system_unitdir} } diff --git a/meta-fii/meta-kudo/recipes-phosphor/fans/pwm-init/pwm_init.service b/meta-fii/meta-kudo/recipes-phosphor/fans/pwm-init/pwm_init.service index 981b8773c5..351d5f15b4 100644 --- a/meta-fii/meta-kudo/recipes-phosphor/fans/pwm-init/pwm_init.service +++ b/meta-fii/meta-kudo/recipes-phosphor/fans/pwm-init/pwm_init.service @@ -4,7 +4,7 @@ Before=xyz.openbmc_project.fansensor.service [Service] Type=oneshot -ExecStart=/usr/bin/pwm_init.sh +ExecStart=/usr/libexec/pwm-init/pwm_init.sh [Install] WantedBy=multi-user.target |