diff options
| author | Zev Weiss <zev@bewilderbeest.net> | 2023-02-16 09:51:22 +0300 |
|---|---|---|
| committer | Zev Weiss <zev@bewilderbeest.net> | 2023-02-16 10:01:30 +0300 |
| commit | d13381167604e829be983c380ada8a413ea28f38 (patch) | |
| tree | 5c10937b443b6ab027db881f73d6a886f6e9bac3 /meta-phosphor | |
| parent | 6f03dd83d324312f691338b22008f7fb69a82f32 (diff) | |
| download | openbmc-d13381167604e829be983c380ada8a413ea28f38.tar.xz | |
jsnbd: Remove superfluous 'exit 0' from state hook script
The shell will implicitly exit with the exit status of the last command
on its own, so having 'exit 0' at the end of a script is at best
redundant, and may actually cause problems by masking a non-zero exit
status of the preceding command and preventing the error from
propagating as it should. (In this particular case we've got 'set -e'
in effect so a command exiting non-zero would terminate the script
anyway, but it would be better not to rely on that.)
Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Change-Id: I1ba2821290695eb7ffbc5937959917a8cf5351f9
Diffstat (limited to 'meta-phosphor')
| -rwxr-xr-x | meta-phosphor/recipes-connectivity/jsnbd/jsnbd/state_hook | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/meta-phosphor/recipes-connectivity/jsnbd/jsnbd/state_hook b/meta-phosphor/recipes-connectivity/jsnbd/jsnbd/state_hook index 063699edf3..5831e94cd2 100755 --- a/meta-phosphor/recipes-connectivity/jsnbd/jsnbd/state_hook +++ b/meta-phosphor/recipes-connectivity/jsnbd/jsnbd/state_hook @@ -82,6 +82,3 @@ stop) echo "invalid action $action" >&2 exit 1 esac - -exit 0 - |