summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2022-04-08run-repotest: Remove exempted shell scriptsCharles Boyer1-9/+0
The shell scripts that were exempted due to shellcheck errors have fixed their shellcheck errors. Therefore, the scripts can be removed from the exemption list. Signed-off-by: Charles Boyer <Charles.Boyer@fii-usa.com> Change-Id: Ic350f14be559f0db96684002ac440a6ee1e8179b
2022-04-08meta-fii: meta-kudo: Fix shellcheck errorsCharles Boyer10-115/+131
Fixes bash shellcheck errors so that the exemptions in run-repotest can be removed. Signed-off-by: Charles Boyer <Charles.Boyer@fii-usa.com> Change-Id: I6afb059cf1151c871ddfcaf67efc6a63183f7130
2022-04-08Added BootType property for multihost supportJayashree Dhanapal3-41/+4
Added BootType property and interface in host-template.yaml for multi-host support to determine the BIOS boot options which supports Legacy and EFI. TESTED : Tested on Facebook Yosemitev2 platform and verified the results. Signed-off-by: Jayashree Dhanapal <jayashree-d@hcl.com> Change-Id: I8f85b9b63019b683b0062c45f793d4b363c82482
2022-04-07setup: enable all qemu* machinesPatrick Williams1-20/+25
The existing support for qemuarm wasn't working. Sometimes, when submitting recipes to upstream, it is useful to test image builds against various qemu* machine models. Enhance the setup script so that we can build any of the qemu* machines that Poky supports and treat them like a generic meta-phosphor machine. Tested: Used `setup qemumips` and was able to `bitbake phosphor-image` successfully. Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Ide141c879dd674fe3771984f7fd41006a64ce54f
2022-04-07phosphor-fan-presence: srcrev bump facbe12962..0850e3122eAndrew Geissler1-1/+1
Patrick Williams (1): sdbusplus: object: don't use 'bool' argument constructor Change-Id: I5b3abe450e7d251c905469d0901d0e56b8dc023e Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-07setup: retab to soft-tabsPatrick Williams1-46/+46
Change-Id: Id9d3d4ff314c0635f9f5ad6fc81d5f19977f65c1 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
2022-04-07meta-fii: meta-kudo: Remove tla2024 from kudoAvenash Asai Thambi3-19/+2
The tla2024 support has been moved into internal repo. Signed-off-by: Avenash Asai Thambi <avenash.thambi@fii-usa.com> Change-Id: Ia77538f10015b033f989b9371c69cfe5d286ee52
2022-04-06phosphor-host-postd: disable testsZev Weiss1-0/+1
Compiling the tests isn't needed for a basic build, and can lead to build failures due to not having gmock/gtest headers. Signed-off-by: Zev Weiss <zev@bewilderbeest.net> Change-Id: I0d55e8a19260dde7dc7f06831d168a1091dc4e74
2022-04-06service-config-manager: srcrev bump eca056ed16..f27f431faaAndrew Geissler1-1/+1
Jiaqing Zhao (1): Switch remaining logs to lg2 Change-Id: I47ae8321eecdf16e3cbc0a3880779c7fc3544b70 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-06phosphor-dbus-interfaces: srcrev bump 2f103d919a..c531268c53Andrew Geissler1-1/+1
Dhruvaraj Subhashchandran (1): Dump: InitiateOffload: Add Unavailable error Matt Spinler (1): openpower: Add GetPELJSON method Change-Id: I2d1c42cdcc04e317db75d70e53a5bfb0d84ff3a0 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-06phosphor-debug-collector: srcrev bump 56bd797e0a..6f4870aadcAndrew Geissler1-1/+1
Marri Devender Rao (4): dreport: add network details to the BMC dump dreport: Add time and date to the BMC dump dreport: add fanctl dump output to BMC dump openpower:dreport: add obmconsole1 log file to the BMC dump Change-Id: Ice66587e41fd465748253a57dcf13c21cac90887 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-06openpower-occ-control: srcrev bump e2d0a43cc1..373af75721Andrew Geissler1-1/+1
Sheldon Bailey (1): openpower-occ-control:failure to read OCC state. Change-Id: I15fca11804e53354081d9cd5c56f9f83ea44f378 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-06phosphor-certificate-manager: srcrev bump 7047be6784..ebd21ba4fcAndrew Geissler1-1/+1
Patrick Williams (1): sdbusplus: object: don't use 'bool' argument constructor Change-Id: Icb67faf7960adb650ca12d9c302fe55723bcc806 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-06x86-power-control: srcrev bump 809545a621..99e8f9dfe6Andrew Geissler1-1/+1
Andrei Kartashev (1): refactor power restore controller Change-Id: I604425396ff9a0c145c5101a50fd92c6e656aaee Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-06bmcweb: srcrev bump 456cd875f3..45ca1b868eAndrew Geissler1-1/+1
Ed Tanous (6): Add new option for query parameters Redfish: Query parameters: Only Implement Expand Implement odata-version checks Fix missing success code in Account PATCH Add setUpRedfishRoute to all nodes in redfish Change-Id: Ia40ac5116d3c2a669a636a619f1b01a7cb5714f2 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-06meta-google: google-usb-network: Remove unused IP optionWilliam A. Kennington III3-27/+11
None of our configurations use the IPv4 address for the BMC, so we can remove all of the configuration. Change-Id: Ib7fd08afc48c189d5e79ceaf64deedacdf6ff6a4 Signed-off-by: William A. Kennington III <wak@google.com>
2022-04-06meta-google: google-usb-network: Fix shutdownWilliam A. Kennington III1-1/+3
We need to specify parameters to shut down the device cleanly. Change-Id: I4f6d3a5cd6aaebf9fb01a86ed78fc1f4737e41eb Signed-off-by: William A. Kennington III <wak@google.com>
2022-04-06meta-google: google-usb-network: Allow specifying interface nameWilliam A. Kennington III2-1/+3
Change-Id: Icdf1b12993b96d13008ddae93a54aa5bd6b35173 Signed-off-by: William A. Kennington III <wak@google.com>
2022-04-06meta-google: google-usb-network: Require fieldsWilliam A. Kennington III2-2/+18
The interface, product ID and bind device are required in order to set up the interface. Change-Id: I9e47c8e9dfa86ae33cb01cedee8471c863e2f066 Signed-off-by: William A. Kennington III <wak@google.com>
2022-04-06meta-google: gbmc-update: Only find a single sigWilliam A. Kennington III1-1/+1
We sometimes have provided tarballs with multiple image or sig files present. We need to limit find to just try the first one. Change-Id: If942c122e95a70ee5d84af702760ff4bc1cb2edb Signed-off-by: William A. Kennington III <wak@google.com>
2022-04-06meta-google: gbmc-update: Fix version outputWilliam A. Kennington III1-0/+4
If we ever have a directory with a VERSION file and version directory, it will write both versions. This is incorrect behavior. Change-Id: Ic6737836ab4c59c32dd3d9c78b76f222558d92a4 Signed-off-by: William A. Kennington III <wak@google.com>
2022-04-06meta-google: gbmc-update: Fixup rmWilliam A. Kennington III1-2/+1
This is a minor nit to remove some extraneous failed logs. It prevents rm from trying to remove `.` and `..`. Tested: Failing and retrying now longer prints out failed `rm` messages Change-Id: Ida92f7d90b989e0875d6a63f4216127cd7151c53 Signed-off-by: William A. Kennington III <wak@google.com>
2022-04-05meta-google: google-usb-network: Name gadget after interfaceWilliam A. Kennington III1-2/+6
We generally have a single interface per gadget, so name it after the interface by default. Change-Id: Iac4ebc50fa8586ec3493111ffa85d8c3a7aa8125 Signed-off-by: William A. Kennington III <wak@google.com>
2022-04-05meta-google: google-usb-network: Bring link up after renameWilliam A. Kennington III1-0/+1
Otherwise it will remain down in some instances. Change-Id: I1878ff533eceed950799f513789f3b801a478c52 Signed-off-by: William A. Kennington III <wak@google.com>
2022-04-05meta-google: google-usb-network: Only rename link if requiredWilliam A. Kennington III1-3/+7
Otherwise it will remain down since the first command sets it administratively down. Change-Id: I203d145ffe9815426c2803b11a4313544d812cf5 Signed-off-by: William A. Kennington III <wak@google.com>
2022-04-05meta-google: google-usb-network: Handle errors consistentlyWilliam A. Kennington III1-19/+21
The previous script was not handling any errors while creating the gadget and could leave the system partially configured. Change-Id: I52ac726129ece1bb82412c5b42027ae8c98e067f Signed-off-by: William A. Kennington III <wak@google.com>
2022-04-05phosphor-bmc-code-mgmt: srcrev bump c026f6cdc3..703de25c2aAndrew Geissler1-1/+1
Adriana Kobylak (1): sync-once: Fix shellcheck warnings Isaac Kurth (3): gen-bios-tar: fix shellcheck warnings obmc-flash-bmc: fix shellcheck warnings Enable shellcheck Justin Ledford (1): Add support for Inventory.Decorator.Compatible Change-Id: I3d50029d3130ab75f8f0ffd6f9be7dfc7e3d677e Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-05phosphor-dbus-interfaces: srcrev bump 4d1ff65d77..2f103d919aAndrew Geissler1-1/+1
John Broadbent (1): Adds new properties to drive Change-Id: Id6609f1d7511acd5b4f4d5475d194858ab467015 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-05phosphor-hwmon: srcrev bump d54618168d..d273b1e06dAndrew Geissler1-1/+1
Patrick Williams (1): sdbusplus: object: don't use 'bool' argument constructor Change-Id: Ib7d14a6ac82be4e6a28a71879a9da33991dbdde0 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-05phosphor-user-manager: srcrev bump ca039ca361..cf53a9466cAndrew Geissler1-1/+1
Patrick Williams (1): meson: improve subproject builds Change-Id: Ie232112294d86dfbe5f6623f81c3222a7e9a92be Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-05estoraged: srcrev bump e35e736137..605085a631Andrew Geissler1-1/+1
John Edward Broadbent (1): Add erase sanitize Change-Id: I3434212a3f0634dd8d59ce92280639a901f3e5d1 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-05openpower-vpd-parser: srcrev bump 6c7a84e4e1..0e34d3574cAndrew Geissler1-1/+2
Alpana Kumari (2): Move preAction postAction to Util Handle ECC update Santosh Puranik (1): manager: Take pre/post actions in recollection Change-Id: I3a86b866549b772d0a72ac6adf6b2b42a14cb223 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-05telemetry: srcrev bump f8ae65ca62..620c65ad38Andrew Geissler1-1/+1
Szymon Dompke (2): Preserve original discrete trigger value OnChange trigger should not handle first reading Change-Id: I8f5aed43d148781aaad561cc6098d5d698869038 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-05phosphor-logging: srcrev bump 7f1b90520c..6ef6b25e44Andrew Geissler1-1/+1
Matt Spinler (1): PEL: Add getPELJSON D-Bus method stub Patrick Williams (1): sdbusplus: object: don't use 'bool' argument constructor Change-Id: Id3e6360e3fae1a578e38e480f1b455b73dc8d01b Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-05phosphor-networkd: srcrev bump 3397be3ca1..166b9598acAndrew Geissler1-1/+1
Patrick Williams (1): sdbusplus: object: don't use 'bool' argument constructor Change-Id: I771e887bea108148a4a112edabb8dc9b248271d3 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-05phosphor-host-ipmid: srcrev bump 3ab2c2b2f3..c1f5aca065Andrew Geissler1-1/+1
Brandon Kim (1): apphandler: Fix Device Revision being 0 Change-Id: I4306701a1e90622c97f9d56a3b0473b33fbee75c Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-05phosphor-fan-presence: srcrev bump baf40fc5f8..facbe12962Andrew Geissler1-1/+1
Matthew Barth (2): control:p10bmc:rainier4u/1s4u: Thermal updates control:p10bmc:rainier-4u/1s4u: Enable floor altitude offsets Change-Id: I39bc89f84168f2276f2976a3fdf795aa6823a180 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-04subtree updatesPatrick Williams138-1623/+1376
meta-openembedded: 9a52bfc4a6..af11f6ce73: Andreas Müller (4): nautilus: Add a packageconfig for libportal - disabled by default gtk4: upgrade 4.4.0 -> 4.6.2 libadwaita: initial add 1.1.0 gtksourceview5: upgrade 5.2.0 -> 5.4.0 Carlos Rafael Giani (3): libopenmpt: Remove unnecessary python code block pipewire: Upgrade to version 0.3.49 wireplumber: Upgrade to version 0.4.9 Kai Kang (4): wxwidgets: 3.1.4 -> 3.1.5 python3-wxgtk4: add recipe wxwidgets: fix typo mcelog: fix compile error Khem Raj (1): python3-wxgtk4: Use cross prefix with native wx-config Matthias Klein (1): paho-mqtt-c: upgrade 1.3.9 -> 1.3.10 Mingli Yu (1): mariadb: increase MY_AES_CTX_SIZE Potin Lai (4): libimobiledevice-glue: add recipe libimobiledevice-glue: fix undefined bswap error libirecovery: add recipe idevicerestore: add recipe S. Lockwood-Childs (1): python3-evdev: fix host header contamination Yi Zhao (2): strongswan: 5.9.4 -> 5.9.5 libnetfilter-conntrack: upgrade 1.0.8 -> 1.0.9 meta-raspberrypi: c06ae5eacf..31c33d155c: Khem Raj (3): linux-raspberrypi_5.15.bb: Upgrade to 5.15.32 raspberrypi-firmware: Update to match 5.15.32 armstubs: Upgrade to 20211101 poky: 5fe3689f4f..1976521190: Chen Qi (1): gobject-introspection: fix default search path for girdir Daniel Ammann (2): overview-manual: Fix reference ref-manual: Add vfat in list of filesystems supported by kickstart Jagadeesh Krishnanjanappa (1): cmake: support to create per-toolchain cmake file in SDK Khem Raj (2): weston: Add a knob to control simple clients meson: Robustify compiler detection logic Marta Rybczynska (1): doc: migration-3.5: extend the section on inclusive language Michael Halstead (1): releases: update to include 3.4.3 Michael Opdenacker (4): overview-manual: add missing upper case docs: add poky.yaml and sphinx-static/switchers.js to "make clean" manuals: fix quoting of double dashes migration-guides: preliminary description for 3.5 Oleksandr Kravchuk (1): python3: update to 3.10.4 Peter Kjellerstedt (1): ref-manual: Remove references to AVAILABLE_LICENSES Rasmus Villemoes (1): git: make expat and curl into PACKAGECONFIG items Richard Purdie (11): set_versions/switchers: Drop versions shown to the active releases mirrors: Add missing gitsm entries for yocto/oe mirrors base: Don't add duplicates to sys.path base: Clean up module import compatibility code modutils-initscripts: Change license PD -> MIT keymaps: Clean up license handling initscripts: Clean up license handling/identifiers bitbake: cooker: Further fixes to inotify to fix memres bitbake issues bitbake: cooker: Restore sys.path and sys.modules between parses bitbake: cooker: Ensure any existing hashserv connection is closed bitbake: cooker: Avoid error if siggen wasn't setup Ross Burton (24): ref-manual: update Python class documentation buildtools-tarball: include nativesdk-python3-pyyaml image_types: hddimg and iso only work on x86 oeqa/selftest/devtool: ensure Git username is set before upgrade tests oeqa/selftest/wic: use os.rename instead of bb.utils.rename oeqa/selftest/wic: remove redundant asserts oeqa/selftest/wic: clean up only_for_arch decorator oeqa/selftest/wic: don't hardcode kernel image type in test_wic_rm oeqa/selftest/wic: add more arch-specific annotations oeqa/selftest/buildoptions: set PACKAGE_CLASSES in test_arch_work_dir_and_export_source oeqa/runtime/decorator/package.py: remove use of strToSet oeqa/core/decorator: remove redundant code testimage: inline updateTestData() oeqa/core/utils/misc: remove redundant file oeqa/selftest: remove unused imports oeqa/core/decorators/data: improve has_* logic oeqa/selftest: tag tests that use runqemu oeqa: rationalise skipifqemu decorators oeqa/selftest/oescripts: refactor skipping logic oeqa/selftest/wic: cleanup WicTestCase.setUpLocal oeqa/selftest/wic: rearrange tests oeqa/selftest/wic: use os.path.join to join paths oeqa/selftest/wic: use self.td instead of get_bb_var to save on bitbake calls oeqa/selftest: generalise test_devtool_virtual_kernel_modify Simon Kuhnle (1): convert-variable-renames: Fix typo in description Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Ic8359fe5772351a45a3154c6a7f5042a88ff934c
2022-04-04linux-aspeed: Add ROMED8HM3, AST2600 SPI NOR fixesJoel Stanley1-1/+1
Jae Hyun Yoo (5): ARM: dts: aspeed-g6: remove FWQSPID group in pinctrl dtsi pinctrl: pinctrl-aspeed-g6: remove FWQSPID group in pinctrl dt-bindings: pinctrl: aspeed-g6: remove FWQSPID group dt-bindings: pinctrl: aspeed-g6: add FWQSPI function/group ARM: dts: aspeed-g6: fix SPI1/SPI2 quad pin group Johnny Huang (2): pinctrl: pinctrl-aspeed-g6: add FWQSPI function-group ARM: dts: aspeed-g6: add FWQSPI group in pinctrl dtsi Potin Lai (1): mtd: spi-nor: aspeed: Set the decoding size to at least 2MB for AST2600 Zev Weiss (1): ARM: dts: aspeed: Add ASRock ROMED8HM3 BMC Change-Id: I648e798dc8c8392509c1cc6fc14b5e02ec7c6d19 Signed-off-by: Joel Stanley <joel@jms.id.au>
2022-04-02meta-google: gbmc-update: Retry wget in case networking isn't readyWilliam A. Kennington III1-1/+9
Otherwise the netboot process will fail early and never complete properly. Change-Id: I90dfbaa53d914df1f9515e2a1feaf17797f741b8 Signed-off-by: William A. Kennington III <wak@google.com>
2022-04-02bmcweb: srcrev bump 9629907de7..456cd875f3Andrew Geissler1-1/+1
Ramesh Iyyar (2): registry: Add PropertyValueResourceConflict registry registry: Add PropertyValueExternalConflict registry Szymon Dompke (1): Use url_view for telemetry uris Change-Id: I92d59347cb9249fe27cb853ba7edb45a7459497b Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-02phosphor-led-sysfs: srcrev bump 3c89426c6c..97db22fd8fAndrew Geissler1-1/+1
Patrick Williams (1): sdbusplus: object: don't use 'bool' argument constructor Change-Id: I12dc454332cee4ec4112f9eaafc2fa7b6795a998 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-02entity-manager: srcrev bump f8ae2ba5c8..e35d0acb7eAndrew Geissler1-1/+1
Andrew Jeffery (22): PerformScan: Destructure config items in run() EntityManager: Rename key to path in populateInterfaceFromJson() EntityManager: Destructure dict items in populateInterfaceFromJson() EntityManager: Destructure items when iterating newConfiguration EntityManager: Destructure exposed items in postToDbus() EntityManager: Destructure board attributes in postToDbus() EntityManager: Destructure board properties in postToDbus() EntityManager: Extract deviceRequiresPowerOn() EntityManager: Refactor deviceRequiresPowerOn() with early-exits EntityManager: Rename isDetectedPowerOn for clarity EntityManager: Determine device config presence with .contains() EntityManager: Continue the loop if the entity is present EntityManager: Exploit destructuring for device removed loop EntityManager: Introduce pruneDevice() EntityManager: Refactor pruneDevice() early-exits EntityManager: Flip condition to start removed timer EntityManager: Introduce getDeviceInterfaces() EntityManager: Exploit destructuring for configuration removed loop EntityManager: Clean up interface removal condition EntityManager: Extract pruneConfiguration() EntityManager: Extract deriveNewConfiguration() EntityManager: Extract publishNewConfiguration() Change-Id: I1fa75ae559576acbf93e8e3aae6322aa41cc5376 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-02openpower-hw-diags: srcrev bump edfcbc38ef..20ed74db38Andrew Geissler1-1/+1
Zane Shelley (4): Create test-only version of util_lib Consolidate test cases for readability trace cleanup for CI script on Ubuntu PPC machines Enable `lg2` logs to be printed to stderr in test Change-Id: Id32c20448442d7bd1f984fc63d9ea5d98ade3269 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-02dbus-sensors: srcrev bump 7aeb1a5e2b..a7afacc4faAndrew Geissler1-1/+1
Andrew Jeffery (1): NVMeBasicContext: Fix response vector size Change-Id: Ic60e3673af8b887fed5cd604f2099ce4d7cd4039 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-02phosphor-power: srcrev bump e5b1e0875c..b23e44332eAndrew Geissler1-1/+1
Adriana Kobylak (1): psu-ng: Skip power supply validation if none are present Shawn McCarney (1): regulators: Retry failed sensor monitoring Change-Id: Ifd4f4270c3a26b1dded2e467caf0b4ca902dd9f7 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-02sdbusplus: srcrev bump 4dd3e2992c..4b0d12687aAndrew Geissler1-1/+1
Patrick Williams (1): server: object: add 'action::emit_no_signals' Change-Id: Ifdc3b48296e81ba9909d253d43a19da8873e1ea8 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-01meta-google: google-usb-network: Fix cleanup routineWilliam A. Kennington III1-5/+5
The sysfs directories are not a real filesystem and do not behave correctly if you use `rm -r`. You need to directly remove the relevant files and directories individually. Currently the script cannot successfully cleanup the interface. Change-Id: Ic7eb104fa6491347d24681ac45b4c0433ea07b23 Signed-off-by: William A. Kennington III <wak@google.com>
2022-04-01meta-google: google-usb-network: Set ifname correctlyWilliam A. Kennington III1-0/+2
We want the interface name on the system to reflect the name given as an argument to the script Change-Id: I00b2d28096aa3e6ef1332ef325a72f3c0f5283e8 Signed-off-by: William A. Kennington III <wak@google.com>
2022-04-01meta-google: google-usb-network: Cleanup gadget if setup failsWilliam A. Kennington III1-1/+4
If setup fails for any reason, we want to cleanup any of the gadget functions that were created. Change-Id: I61be13a66cba2916fe7685b021fe0f7fa225e4f6 Signed-off-by: William A. Kennington III <wak@google.com>