summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2023-06-28meta-facebook: fix phosphor-state-manager build errorPotin Lai1-2/+2
The `systemd_system_unitdir` path changs after enabling 'usrmerge', replace actual path with `systemd_system_unitdir` to avoid build issues due to path changes. Add machine name into FILESEXTRAPATHS to fix files not included issue. Signed-off-by: Potin Lai <potin.lai@quantatw.com> Change-Id: I5bb58f48dcf5e689ad44265f0b6add50b7d141bd
2023-06-28meta-evb-npcm845: host-postd: add postd daemon configurationTim Lee1-0/+1
Enable BIOS POST CODE functionality for Nuvoton BMC in postd. Need to add this configuration and fix daemon load failed. Due to default SNOOP_DEVICE is using Aspeed BMC. Failed log: lpcsnoop.service: Main process exited, code=exited ExecStart=/usr/bin/snoopd -b 1 -d /dev/aspeed-lpc-snoop0 (code=exited) Signed-off-by: Tim Lee <timlee660101@gmail.com> Change-Id: I3ec1c98787260e7a98f4a5135db0b9c5e23fc4af
2023-06-27meta-google: fix timesync timeoutWilly Tu1-3/+3
The systemd config path is wrong. Tested: ``` $ cat /lib/systemd/system/systemd-time-wait-sync.service.d/10-gbmc.conf [Service] TimeoutStartSec=1min $ systemctl status systemd-time-wait-sync.service x systemd-time-wait-sync.service - Wait Until Kernel Time Synchronized Loaded: loaded (/lib/systemd/system/systemd-time-wait-sync.service; disabled; preset: disabled) Drop-In: /lib/systemd/system/systemd-time-wait-sync.service.d `-10-gbmc.conf Active: failed (Result: timeout) since Thu 2023-01-26 02:00:19 PST; 72ms ago Docs: man:systemd-time-wait-sync.service(8) Process: 5542 ExecStart=/lib/systemd/systemd-time-wait-sync (code=exited, status=0/SUCCESS) Main PID: 5542 (code=exited, status=0/SUCCESS) CPU: 20ms Jan 26 01:59:19 gbmc systemd[1]: Starting Wait Until Kernel Time Synchronized... Jan 26 01:59:19 gbmc systemd-time-wait-sync[5542]: adjtime state 5 status 40 time Thu 2023-01-26 09:59:19.662116 UTC Jan 26 02:00:19 gbmc systemd[1]: systemd-time-wait-sync.service: start operation timed out. Terminating. Jan 26 02:00:19 gbmc systemd-time-wait-sync[5542]: Exit without adjtimex synchronized. Jan 26 02:00:19 gbmc systemd[1]: systemd-time-wait-sync.service: Failed with result 'timeout'. ``` Change-Id: I5b3cfd0b098a376eed162c509f5876bb2025cd77 Signed-off-by: Willy Tu <wltu@google.com>
2023-06-27meta-intel-openbmc: add libtinyxml2 to DEPENDSIvan Mikhaylov1-1/+1
Add explicitly libtinyxml2 in depends for intel-ipmi-oem. Change-Id: I941ab3bd36ed5c325e6d6abd57375818d66cef43 Signed-off-by: Ivan Mikhaylov <fr0st61te@gmail.com>
2023-06-27host-error-monitor: srcrev bump 08d16db2cb..1c0d047713Andrew Geissler1-1/+1
Jason M. Bills (1): Handle crashdump busy error Change-Id: I5bbf0522a5b8d81b96b09fd2d7a8b27bdb45203c Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-27entity-manager: srcrev bump e2400c8cc8..aa9bb3dde7Andrew Geissler1-1/+1
Ali El-Haj-Mahmoud (1): entity-manager: tyan s8036: expose AMD's SBTSI CPU temperature sensor. Avenash Asai Thambi (1): kudo_motherboard: Add PID fan table sensor configuration Edward Lee (1): Create Item.System from Exposes List Jonico Eustaquio (1): configurations: Add Mori BMC configuration Marvin Drees (1): add Support for SuperMicro PWS-920P-SQ PSU Naresh Solanki (1): configurations: Add IBM genesis3 board configuration Change-Id: I9563a4546ea0c91a53fa54ff63a1fcd43bd57ccb Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-27libpeci: srcrev bump b65de2d694..c4c3feec24Andrew Geissler1-1/+1
Matt Simmering (1): libpeci: Add 64-bit MMIO Read variable Change-Id: I05e477758dd497539b17a14a65ea662a9e97565d Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-27libpldm: srcrev bump 6409c8a024..b6c06f18e8Andrew Geissler1-1/+1
Andrew Jeffery (2): tests: pdr: Guard TEST(EntityAssociationPDR, testFindContainerID) abi: Update for v0.3.0 tag Change-Id: Icb636c8d6519429df7fffadf191b232a5e04e488 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-27phosphor-debug-collector: srcrev bump c04e0e0a70..ea632b81bcAndrew Geissler1-1/+1
Dhruvaraj Subhashchandran (3): OpenPOWER: Allow initiating mp reboot dump in quiesced state OpenPOWER: Return Unavailable Instead of NotAllowed for Delete OpenPOWER: Allow system dump in TransitioningToOff state Change-Id: I87c6a98882cf2aa694200bf43b76e118a923be94 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-27meta-phosphor: add Upstream-Status to patch filesPatrick Williams1-2/+4
The latest Yocto gives errors such as this for patches without an Upstream-Status disposition: ``` 17:24:20 ERROR: i2c-tools-4.3-r0 do_patch: QA Issue: Missing Upstream-Status in patch ``` Add it as necessary. Change-Id: I2592c84c8dfbca6cb4bbc83f31395ed05d05f4bd Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
2023-06-27pldm: srcrev bump 488f19d00a..95c872c1adAndrew Geissler1-1/+1
Andrew Jeffery (1): oem: ibm: Use `truncate(1)` to create NVRAM related files Change-Id: I8f098ba0ac8723795e72b0b0057fe0b48e35894c Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-27libpldm: srcrev bump 5dc025719d..6409c8a024Andrew Geissler1-1/+1
Andrew Jeffery (2): libpldm: Bump to v0.3.0 bios_table: Remove deprecated APIs sanitized by assert() Change-Id: Icacdb666c0d3a38127f25341b02cfdc2463d3e13 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-27libmctp: srcrev bump 4df106db77..99b9d238bcAndrew Geissler1-1/+1
Andrew Jeffery (2): mctp-demux-daemon: Change default log level to MCTP_LOG_NOTICE astlpc: Log changes to KCS status register Change-Id: Ied08e2cbd2697ab9642e2e574dd68a8798c4915b Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-27phosphor-health-monitor: srcrev bump 658d70aaca..2a9400112dAndrew Geissler1-1/+1
Jian Zhang (1): misc: Move to steady_timer Change-Id: Ia696064aef92009a0f26cdc0ec7db35a6ab3118f Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-27bmcweb: srcrev bump 6995c1ce42..7a54389415Andrew Geissler1-1/+1
Ed Tanous (2): Remove usage of flat_map for enum lookup Break out request completion from connection Patrick Williams (2): error_messages: remove source_location indirect sdbusplus: use shorter type aliases Change-Id: Ia388a4922d2f3fff88f9bfa7963ae176184ed1c8 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-27phosphor-ipmi-blobs-binarystore: srcrev bump 62872f5cb3..53992e85d2Andrew Geissler1-1/+1
Willy Tu (1): markdownlint: reformat README.md Change-Id: Ic8444c8b005b74b8b9dab484636dd41c21c2bb82 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-27phosphor-debug-collector: srcrev bump a72daf5c41..c04e0e0a70Andrew Geissler1-1/+1
Eddie James (1): Add linux trace events Patrick Williams (1): sdbusplus: use shorter type aliases Change-Id: If7b6f8ec4fa816dfab3e54e221d8a152ad8714de Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-26meta-hpe: rl300-g11 update machine config fileCharles Kearney1-0/+1
add missing preferred provider for obmc-host-ipmi-hw Change-Id: I06c79cf0633df0a296841bd3acb99d72e88b9bbe Signed-off-by: Charles Kearney <charles.kearney@hpe.com>
2023-06-26meta-hpe: rl300-g11 add package groups appendCharles Kearney1-0/+1
Change-Id: I76eda146190b008ec10d6be0a35f23f081150509 Signed-off-by: Charles Kearney <charles.kearney@hpe.com>
2023-06-26meta-hpe: remove customer key block file requirementCharles Kearney2-38/+9
The customer key block HPE signed key is no longer required for machines that have been through the transfer of ownership process. Change-Id: Idfc94033dec64c62fa773c5511f9d0a17518a1cf Signed-off-by: Charles Kearney <charles.kearney@hpe.com>
2023-06-26meta-hpe: rl300-g11 add power supply monitoring recipeCharles Kearney12-0/+131
Change-Id: Ib6071c1b6d4df4a1138e0cecf29787c5edcea23c Signed-off-by: Charles Kearney <charles.kearney@hpe.com>
2023-06-26meta-google: Add default rsyslog config for gBMCWilly Tu2-0/+17
Enable common config for imjournal to use across all gBMC, so that we don't have to manage it seperately. Change-Id: I96057e3ee8246afdd0030fb2b90bcf01f9709137 Signed-off-by: Willy Tu <wltu@google.com>
2023-06-26meta-ibm: p10bmc: Move Bonnell dtb to be first on listAdriana Kobylak1-3/+7
The first dtb listed in the KERNEL_DEVICETREE list is the default used for the BMC's genesis boot. The Bonnell device tree specifies an eeprom that's larger in size than other p10bmc systems. Therefore the device driver currently truncates the data on this eeprom when doing a genesis boot on Bonnell since the default device tree is for Rainier. Move Bonnell to the top of the list to be the default since it has the larger eeprom size. Tested: Booted Rainier and Everest on simulation to test a genesis BMC boot. Verified they first booted with the Bonnell's device tree, then the BMC automatically rebooted after the machine type was identified and the device tree corresponding to the system was loaded. Change-Id: Icb9abe7d8b04d42befd9eb906d095f4fa046ab3c Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
2023-06-24telemetry: srcrev bump cc8abc0be5..3995a361afAndrew Geissler1-1/+1
Patrick Williams (1): Remove OWNERS which are unqualified Change-Id: Ica2aaf0070ad41816a7066faea165ff8ba04e203 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-24phosphor-logging: srcrev bump 7ba17c349b..7f5e44105dAndrew Geissler1-1/+1
Marri Devender Rao (1): PEL : Modify faultlog error to include only serviceable record count Patrick Williams (1): lg2: simplify source_location for clang-16 Change-Id: Iaf80ca58f4d072df800eff948c926bc2fdece031 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-24stdplus: srcrev bump 8a6eca3ae3..69a00d76b8Andrew Geissler1-1/+1
Patrick Williams (1): exception: remove source_location indirect William A. Kennington III (23): str/cexpr: Delete clang exemption net/ether: Fixup constructors net/addr/ip: Fixup hash function signatures str/buf: Add allocation reducing string buffer str/conv: Add basic functions numeric/str: Add constexpr int encode numeric/str: Improve base10 encode performance numeric/str: Add constexpr int decode net/addr/ether: Add FromStr conversion net/addr/ether: Add ToStr conversion net/addr/ip: Add In4Addr FromStr conversion net/addr/ip: Add In4Addr ToStr conversion net/addr/ip: Add IPv6 FromStr conversion net/addr/ip: Add IPv6 ToStr conversion net/addr/ip: Add InAnyAddr FromStr conversion net/addr/ip: Add InAnyAddr ToStr conversion net/addr/subnet: Add ToStr conversion net/addr/subnet: Add FromStr conversion net/addr/ether: Add missing equal operator net/addr/ether: Add basic queries net/addr/subnet: Add netmask functions net/addr/subnet: Add hashing functions str/buf: Fix when sizeof(CharT) == sizeof(CharT*) Change-Id: Ie518d47a5845beb32b79ee40650fd14749b084db Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-24sdbusplus: srcrev bump 3cc9c302f0..fa663aec1eAndrew Geissler1-1/+1
Patrick Williams (2): async: add is_sender type-aliases stdexec: update to latest commit Change-Id: I264aa6371700bf76a055f4cf91528e2fd7e59845 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-24phosphor-snmp: srcrev bump edd7082913..40f769bb41Andrew Geissler1-1/+1
Ivan Mikhaylov (1): Add UDP protocol by default in SNMP client Patrick Williams (1): snmp-configuration: fix markdownlint issues Change-Id: I2095f98dadbc2b5fc0d51dc59ee4e83e3b66bfa6 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-23pldm: srcrev bump 477922744e..488f19d00aAndrew Geissler1-1/+1
Andrew Jeffery (1): pldm: Convert to pldm_bios_table_*_check() APIs Change-Id: Ia037c878e70d82bd6dc1744b4541b5b13fcdc4bc Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-22google-ipmi-sys: srcrev bump 444b5ea484..dd04017914Andrew Geissler1-1/+1
Brandon Kim (1): bmc_mode: Add #pragma once Change-Id: I81254d11b3717982a0e916225616c2fabfeaff73 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-22add nghttp2 dependency on bmcwebEd Tanous2-0/+16
This commit is part of the review here: https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/40978 It adds a compile time dependency on nghttp2, and adjusts some of the build params for OpenBMC. Namely: 1. Building only a static library. 2. Enabling LTO. 3. Removing all features that we don't use (to reduce binary size) Signed-off-by: Ed Tanous <edtanous@google.com> Change-Id: Ifa9695c3c2313b4895d500a410307ef71ae1fad9
2023-06-22dbus-sensors: srcrev bump 9a7db6af20..95f49937b8Andrew Geissler1-1/+1
Chau Ly (1): intrusionsensor: Add hwmon reading method Change-Id: I830ce48e388fbf7e171376911dfcd7580514a518 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-22phosphor-dbus-interfaces: srcrev bump e6718c5e42..3bbd482752Andrew Geissler1-1/+1
George Liu (1): DIMM: Refactor the byte attribute to size type Change-Id: Ifd989512d867a531cf07835427693f348bcdf4a4 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-22bmcweb: srcrev bump 3d30708fb6..6995c1ce42Andrew Geissler1-1/+1
George Liu (1): Change the byte of the MemoryAttributes attribute to the size type Change-Id: If5da4af8167710845fa1617dfa64dad3c1ad54c5 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-22phosphor-debug-collector: srcrev bump 64f8da9e70..a72daf5c41Andrew Geissler1-1/+1
Dhruvaraj Subhashchandran (4): OpenPOWER: Add support for OpenPOWER dump policy OpenPOWER: Limit User-Requested System Dumps Fix markdownlint and shellcheck errors OpenPOWER: Fix compile error in p10bmc Matt Spinler (1): openpower:dreport: Save badPEL file in dump Change-Id: Ifde37451b7618b91e3ddfc37638bacccd092f5c3 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-22meta-google: gbmc-bridge: Fix nftable rule setYuxiao Zhang2-7/+2
Seems that nftable cannot jump to a chain that doesn't in its own file. Change-Id: I4d8c0cd804afddaae7ae5e94b5db1266b149fb55 Signed-off-by: Yuxiao Zhang <yuxiaozhang@google.com>
2023-06-22webui-vue: srcrev bump 65fa7bf8c8..fb6c6de90cAndrew Geissler1-1/+1
Jason M. Bills (1): Add fields to the DIMM inventory table Konstantin (1): Fix kvm session and add event bus Change-Id: I214402410f69d8e2029d8fa61818eaf0e0db4723 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-22phosphor-logging: srcrev bump b25e8a328b..7ba17c349bAndrew Geissler1-1/+1
Matt Spinler (1): Don't throw on Settings access fail Change-Id: I6353532fe83c69c30348dd976546a4e45777218a Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-22phosphor-ecc: srcrev bump c0b4eae01f..527190b2b7Andrew Geissler1-1/+1
Patrick Williams (1): clang-format: copy latest and re-format Change-Id: I3fcce1f4ea8e60df28f1bbc2abd772ca2002a1bd Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-22smbios-mdr: srcrev bump 5a122a6e1b..132d037edfAndrew Geissler1-1/+1
Ankita Vilas Gawade (1): Clear cpuInfoMap on platform config discovery Hieu Huynh (1): Fix compiling error Change-Id: I32ec65b7620698687c3068807c9ebe29c3c1137d Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-22phosphor-state-manager: srcrev bump e56feb492e..2038e4925bAndrew Geissler1-1/+1
Andrew Geissler (2): gitignore: add vscode reboot-cause: look for pinhole reset first Change-Id: Ibb5f2f95a1dc1d7657ef568739676ed966716c2f Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-22bmcweb: srcrev bump e164f1b66e..3d30708fb6Andrew Geissler1-1/+1
Chicago Duan (1): Redfish: Implement SNMP Trap Ed Tanous (8): Revert "Fix websocket csrf checking" Set cookieAuth variable for cookie Use fillMessageArgs in log services Upgrade to mozilla intermediate 5.7 Change cipher suite variable Add an option flag for multi-computersystem Break out ComputerSystem methods Move all ComputerSystem routes to bottom George Liu (1): Refactor getManagedObjects method Jayaprakash Mutyala (1): Populate Memory attributes Joseph Reynolds (1): Add headers Referrer-Policy and Permissions-Policy Lakshmi Yadlapati (1): Fix Redfish validator failure in PCIeFunction Nan Zhou (1): json utils: add getEstimatedJsonSize Change-Id: Icd8b2601a60fa5cd1cfc36775877b9c02d192b0c Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-21phosphor-dbus-interfaces: srcrev bump 7720dd643b..e6718c5e42Andrew Geissler1-1/+1
Ivan Mikhaylov (1): network/client: add TCP/UDP as Transport Protocol for Client Change-Id: I19c1244599f78e923b69fec15cdd7f0ea2b4ec41 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-21phosphor-debug-collector & phosphor-dbus-interfacesAndrew Geissler2-2/+2
PDC:srcrev bump 0b566d5497..64f8da9e7 Dhruvaraj Subhashchandran (1): Implement GetFileHandle in dump entry interface PDI: srcrev bump 3826910ef8..7720dd643b Dhruvaraj Subhashchandran (1): Add GetFileHandle method to dump entry Change-Id: I680546978a75f524b6c8e39b7cc24f7e9fde0450 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-21meta-phosphor: ipmitool: patch for fru edit fixesAlex Schendel2-0/+268
This commit is a temporary patch which is a copy of: https://codeberg.org/IPMITool/ipmitool/pulls/1 The current implementation of ipmitool fru edit does not perform proper checks when attempting to resize the FRU. This results in undesireable changes to the FRU in several instances. This commit resolves these issues to ensure proper handling when decreasing or increasing the FRU size. Tested: Built OpenBMC with only this patch for ipmitool and performed the tests described in the patched commit with the same results. Change-Id: I0305277740c55f4a314111acfc556758f14828d4 Signed-off-by: Alex Schendel <alex.schendel@intel.com>
2023-06-21pfr-manager: srcrev bump 304e82e1a3..d5c499082fAndrew Geissler1-1/+1
sri anjaneyulu alapati (1): Updated Additional Error/Status codes Change-Id: Ied89d2f6f325c0ad1de37327bc5b85e681fadf97 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-20phosphor-state-manager: add PACKAGECONFIG optionsAndrew Geissler2-3/+17
Clearly define the optional features and their defaults within the PSM repo. Change-Id: Ibf466d9319b4176c816ef22c4cdbfd8cd693a90b Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
2023-06-20meta-phosphor: simplify FLASH_SIZE specificationPatrick Williams4-3/+2
FLASH_SIZE was previously defaulted in a few bbclasses and bbappends, but this can result in it not being defined in all recipes if the machine has not overridden the FLASH_SIZE. openbmc/openbmc#3876 reported one such case where the u-boot-fw-utils recipe does not receive the correct FLASH_SIZE and ends up erasing the wrong flash region as if it were the u-boot enviroment. Specify it in the common include so it is available everywhere. Resolves openbmc/openbmc#3876. Change-Id: Iacdde1a5d0081b54321110d655da18bb3846cd14 Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
2023-06-20dbus-sensors: srcrev bump 55832f37ec..9a7db6af20Andrew Geissler1-1/+1
Hieu Huynh (1): hwmontemp: add tmp464 Change-Id: I7605a03b0cafc5e63159658ef579f00fad6e5807 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2023-06-20libpldm: srcrev bump a5c3287e9b..5dc025719dAndrew Geissler1-1/+1
Andrew Jeffery (10): meson: Force inclusion of config.h via `-include` bios_table: pldm_bios_table_attr_entry_enum_decode_pv_num_check() values bios_table: pldm_bios_table_attr_entry_enum_decode_pv_hdls_check() values bios_table: pldm_bios_table_attr_entry_enum_decode_def_num_check() values bios_table: pldm_bios_table_attr_entry_string_decode_def_string_length_check() values bios_table: pldm_bios_table_attr_entry_enum_encode_check() values bios_table: pldm_bios_table_attr_entry_string_info_check() NULL deref bios_table: Relax pldm_bios_table_string_entry_decode_string_check() bios_table: Relax pldm_bios_table_attr_entry_enum_decode_pv_hdls_check() bios_table: Deprecate APIs with arguments sanitized using assert() Pavithra Barithaya (2): pdr: Add pldm_entity_association_pdr_add_from_node_with_record_handle() pdr: Add pldm_pdr_find_container_id_range_exclude() API Rashmica Gupta (3): requester: Add check before accessing hdr in pldm_recv() transport: Make APIs work for all types of messages transports: Resize socket send buffer if needed Change-Id: Ia5c5c03562eb01f40a4ce2725e93f7626eecb3f8 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>