| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
As of 9a8f30ec5b58 ("obmc-console: Introduce console-id, deprecate
socket-id") in obmc-console `console-id` is preferred over `socket-id`.
Convert all in-tree configurations to `console-id` to enable removal of
support for the deprecated `socket-id` configuration option.
Change-Id: Ifd50603c378cfed5eb793b829b8296b7964e4194
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
This reverts commit ec7cab9378f548e94ee4af83946b2583d1fc7194.
ec7cab9378f5 ("Add socket-id for the first console") was only a partial
fixup of the obmc-console configurations found in the tree. For
historical reasons not all platforms that support multiple consoles
install a client configuration file for all consoles. Instead they relied
on some default behaviour that was removed in obmc-console's 4e7186918599
("Fixed broken dbus interface for multiple consoles"). Applying the
configuration changes in the manner of ec7cab9378f5 ("Add socket-id for
the first console") resulted in an asymmetric configuration between the
client and server, breaking some SSH SOL instances.
As of ae2460d0b8e8 ("obmc-console: Provide a default value for
`console-id`.") in obmc-console the requirement to specify
`socket-id`[^1] is lifted. Instead, the configuration can choose to
override a default value. This restores the original behaviour and
unbreaks SSH SOL.
[^1]: Now an alias of the `console-id` configuration key
Websocket and IPMI consoles remain broken. A fix is under development
that also takes a proper approach to supporting multiple consoles in
bmcweb, and the same solution pattern can be applied in ipmid.
More discussion of the problems involved can be found here:
https://amboar.github.io/notes/2023/05/08/happenings-in-obmc-console.html
Change-Id: I274284c791758f336da6d6301dc523bac2b5dd69
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
obmc-console configurations are missing some service appending, this
commit adds these.
Remove socket connection check in ampere_uartmux_ctrl.sh for meta-jade
because no socket file is used now in obmc-console.
Tested:
$ ampere_uartmux_ctrl <uart_port> <mux>
Can successfully switch between console header and BMC for host uart
ports
$ ssh root@<BMC_IP> -p <client_port>
Can successfully connect to host console uarts
Signed-off-by: Chau Ly <chaul@amperecomputing.com>
Change-Id: Iaa0c4d8f9045fc94f6f50822516aaac0b99f088e
|
|
This drop adds socket-id for first console. This was left out before
but with the new design this parameter is required and enforced by
obmc-console code. It is decided to set "socket-id = console0"
initially because that is the current path used by bmcweb but in future
you can change this value to whatever is appropriate.
The console information is now available through the DBUS interface.
Each console server register it's object path on DBUS. The leaf node of
the object path is used to create a console path. For example in the
following console0 the leaf node "console0" is used to make up the
console path and the GUI will use console path "/console/console0" to
connect to the console.
busctl tree xyz.openbmc_project.Console.console0
`-/xyz
`-/xyz/openbmc_project
`-/xyz/openbmc_project/console
`-/xyz/openbmc_project/console/console0
Here is a discord thread where new design was discussed.
https://discord.com/channels/775381525260664832/1083551792094249051
Tested:
Tested on the rainier system.
Related commits:
1) phosphor-dbus-interface: https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/61486
2) obmc-console: https://gerrit.openbmc.org/c/openbmc/obmc-console/+/62496
3) bmcweb: https://gerrit.openbmc.org/c/openbmc/bmcweb/+/62525
Change-Id: I5fd06f3aac69872a3e5032d592a9b59711795cfe
Signed-off-by: Ninad Palsule <ninadpalsule@us.ibm.com>
|
|
Upstream obmc-console now supports the meson build system. I consider
the autotools build system deprecated and intend to remove it.
Change-Id: Ic8eea195bee0b3bea1cb9418593596ce1aaceeae
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
This commit refactors obmc-console setup for mtjade
Tested:
1. Successfully connects to host consoles via ssh sol
$ ssh root@${bmc} -p 220*
2. Successfully connects host consoles via ipmi sol
$ ipmitool -I lanplus -H ${bmc} -U root -P 0penBmc \
-C 17 sol activate
3. All the host console logs are in /var/log/
Signed-off-by: Chau Ly <chaul@amperecomputing.com>
Change-Id: Ie01361139644f5836646d1d98934cda52828ec70
|
|
Many scripts in meta-ampere had `shellcheck source=/dev/null`, which
isn't as useful as putting the real sourced script. Fix up all of
these in the meta-layer to point to the right script, which as a
side-effect allow a few global-disables to be removed.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Icb43dc76a19edbdada8b4caa6ced57ff07f42d27
|
|
This commit supports phosphor-hostlogger in STREAM mode, to forward
the byte stream from obmc-console to rsyslog via the imuxsock module.
The logs can be obtained in /var/log/. The logs are rotated by
logrotate. The size threshold of cpu console is 256KB and the others are
64KB. Each log is polled every 1 minute to check if its file size
exceeds the threshold to rotate it to the new file. Each console can be
saved in up to 2 log files.
Tested (CPU console):
1. Change the mux of CPU console to BMC
$ ampere_uartmux_ctrl.sh 1 2
2. Connect to CPU SOL console
$ ssh root@<BMC_IP> -p 2200
3. Execute commands in the CPU SOL console
=> The console output on CPU SOL console will all be logged to
/var/log/obmc-console-cpu.log
=> The log will be rotated to /var/log/obmc-console-cpu.log.1 if the
original log file size exceeds 256KB every 1min poll
Signed-off-by: Chau Ly <chaul@amperecomputing.com>
Change-Id: I5586d1c634ec0f244069b868bd48b75560520dc1
|
|
As mentioned by I970e06ca6f9d0a9792af122eb25da1bb9a06f058, append and
remove directives with '+=' are no longer valid Yocto syntax and raise a
warning.
See https://git.yoctoproject.org/poky/tree/documentation/migration-guides/migration-3.5.rst#n40
One interesting caveat has to do with the difference between "append"
and "+=".
foo:append = "a"
foo:append = "b"
Results in `foo = "ab"`, but
foo += "a"
foo += "b"
Results in `foo = "a b"`. When `:append +=` is used it has behavior
like the `+=` operator. Therefore, in some cases we need to insert
additional whitespace after the `:append = "` to ensure concatenation
behaves as expected. I've manually reviewed the results to ensure there
is no ill side-effects from an additional space potentially being added.
Fix up the entire tree with the following one-liner (and similar for
`remove`):
git ls-files -- ':!:poky/**' ':!:meta-security/**' \
':!:meta-raspberrypi/**' ':!:meta-openembedded/**' \
| grep "\.bb" | xargs grep -l ":append.*+=" \
| xargs sed -i 's/:append\(.*\)+=\([^"]*\)" */:append\1=\2" /'
or ...
| xargs grep -l ":remove.*+=" \
| xargs sed -i "s/:remove\(.*\)+=/:remove\1=/"
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Iea6235e7c76e252f4d473652957c2925f6b8845a
|
|
Fix all issues from the shellcheck checked on bash shells under
meta-ampere.
Tested: Verify the following features:
1. Power control (on,off, cycle, graceful shutdown, hard reset).
2. UART switching.
3. UEFI firmware update.
Signed-off-by: Thang Q. Nguyen <thang@os.amperecomputing.com>
Change-Id: Idabf839b7521ecadb642230cc8bb3472c787002e
|
|
Run convert-overrides.py meta-ampere and update missing changes as
below:
- Change all _mtjade to :mtjade
- Change all _${PN} to :${PN}
Tested:
1. Check compilation without problem.
2. Check basic functions like switch UART mux, power control.
Signed-off-by: Thang Q. Nguyen <thang@os.amperecomputing.com>
Change-Id: I42038b2a98ed1951d6c770bdf49f5fc440f8163e
|
|
Support solssh for Mt.Jade system.
It opens these ssh ports:
2200 - CPU console
2201 - SCP 0 concole
2202 - ATF console
2203 - SCP 1 console
Tested:
- connect to ssh ports
- make sure the console are displayed correctly
Signed-off-by: Tung Nguyen <tungnguyen@os.amperecomputing.com>
Change-Id: Ic0be980f201c0176ca00fd07804c101f404e707a
|
