summaryrefslogtreecommitdiff
path: root/meta-ibm/recipes-phosphor/leds
AgeCommit message (Collapse)AuthorFilesLines
2023-11-08meta-ibm:Remove execution of set-all-groups-assertedSunny Srivastava2-32/+1
The commit removes dependecy of obmc-led-set-all-groups-asserted from the recipe file of phosphor-led-manager. The script executed by the service curently sets asserted property of all the LED groups to false on BMC boot which is now being set using operational status. Hence the script is no longer required. Change-Id: I6ddfa17ec70d75f115931d78d5866dab8a7e1f21 Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>
2023-11-07ledmanager: Disable persistent-led-asserted by defaultGeorge Liu1-1/+1
Since not all systems start persistent-led-asserted by default, persistent-led-asserted should be disabled by default in Yocto. However, IBM’s p10 machine needs to be enabled by default. Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: I9b5302f541bf814f96d5af7d20662b5bfcc4e6a8
2023-02-03meta-ibm: phosphor-ledcontroller has movedAndrew Geissler1-1/+1
Recent changes moved this binary from /usr/sbin to /usr/libexec/phosphor-led-sysfs/. Update this service to reflect that. Signed-off-by: Andrew Geissler <geissonator@yahoo.com> Change-Id: I16df4cb1942ac93dfb8b487e58ff60ea67c58d28
2023-01-27meta-ibm: update service files in accordance with recent refactoringAndrew Geissler1-1/+1
As noted in the following mailing list thread: https://lists.ozlabs.org/pipermail/openbmc/2022-November/032457.html and implemented via this series of commits: https://gerrit.openbmc.org/q/topic:op-power-control-ref Some systemd services had their names changed. Update the service files in this repo to reflect this. Signed-off-by: Andrew Geissler <geissonator@yahoo.com> Change-Id: Idaca9c1a46f8b5d673b4912e3027fc9268aa5dba
2022-10-24Remove largely unmaintained MihawkMyung Bae2-532/+0
A fork of it is maintained but its upstream layer has largely been unmaintained. No future products are planned to be based on this layer. Mihawk is similar to Witherspoon. Signed-off-by: Myung Bae <myungbae@us.ibm.com> Change-Id: I82f7d777b78cd126237d51e42f1e11abdf80ae68
2022-03-23phosphor-led-manager: automatically deduce use-{json,yaml}Patrick Williams1-1/+1
New systems should be using the 'use-json' model by default, but it currently requires a bbappend in order to enable it. Automatically detect based on the PREFERRED_PROVIDER of virtual/...-config-native if the intended use is JSON or YAML. Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Ie674d1b901395b4fd41838b6e978ca1ff00b0277
2022-02-18treewide: fix append/remove directivesPatrick Williams1-2/+2
As mentioned by I970e06ca6f9d0a9792af122eb25da1bb9a06f058, append and remove directives with '+=' are no longer valid Yocto syntax and raise a warning. See https://git.yoctoproject.org/poky/tree/documentation/migration-guides/migration-3.5.rst#n40 One interesting caveat has to do with the difference between "append" and "+=". foo:append = "a" foo:append = "b" Results in `foo = "ab"`, but foo += "a" foo += "b" Results in `foo = "a b"`. When `:append +=` is used it has behavior like the `+=` operator. Therefore, in some cases we need to insert additional whitespace after the `:append = "` to ensure concatenation behaves as expected. I've manually reviewed the results to ensure there is no ill side-effects from an additional space potentially being added. Fix up the entire tree with the following one-liner (and similar for `remove`): git ls-files -- ':!:poky/**' ':!:meta-security/**' \ ':!:meta-raspberrypi/**' ':!:meta-openembedded/**' \ | grep "\.bb" | xargs grep -l ":append.*+=" \ | xargs sed -i 's/:append\(.*\)+=\([^"]*\)" */:append\1=\2" /' or ... | xargs grep -l ":remove.*+=" \ | xargs sed -i "s/:remove\(.*\)+=/:remove\1=/" Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Iea6235e7c76e252f4d473652957c2925f6b8845a
2021-10-07meta-ibm: phosphor-led-manager: Fix LED group manager dependencyAndrew Jeffery1-2/+2
The dependency is required to be the base name of the service file path, otherwise we see: ``` Jan 01 00:00:33 p10bmc systemd[1]: /lib/systemd/system/obmc-led-set-all-groups-asserted@.service:3: Failed to add dependency on xyz.openbmc_project.LED.GroupManager, ignoring: Invalid argument Jan 01 00:00:33 p10bmc systemd[1]: /lib/systemd/system/obmc-led-set-all-groups-asserted@.service:4: Failed to add dependency on xyz.openbmc_project.LED.GroupManager, ignoring: Invalid argument ``` Change-Id: Ide813cb3298e7f815b5f42b82473ab2a434193f7 Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
2021-09-02meta-phosphor: change systemd.bbclass to match upstream override syntaxPatrick Williams1-1/+1
Upstream bbclasses changed to typically use the `:${PN}` override syntax, including the SYSTEMD_ variables. Change our systemd.bbclass to do the same for consistency and perform a tree-wide variable replacement. Spot checked by building bletchley and witherspoon and checking some of the SYSTEMD_LINK directives on installed packages under qemu. Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I20a9dd809bff8af8759488734f80486c7228c6eb
2021-08-11meta-ibm: prep for new override syntaxAdriana Kobylak1-8/+8
Change-Id: I9116ed7260e369136acb39eec15075db2d4dbeba Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
2021-04-12fru-fault-monitor: Enable OperationalStatus monitor featureVishwanatha Subbanna1-2/+3
Currently, the phosphor-fru-fault-monitor updates the Asserted property of the Led Group D-Bus object by monitoring the `/xyz/openbmc_project/logging` object path. The intent behind this commit is to add another way to monitor the `xyz.openbmc_project.State.Decorator.OperationalStatus` interface of the Inventory D-Bus object, and check whether the Inventory D-Bus object is associated with the LED group D-Bus object, and then update the Asserted property of the LedManager. Since both these methods handle the faults differently, Only ONE of these 2 methods can be enabled and NOT both. The first way is supported by default. To turn OFF the default way AND turn ON this second way, Enable monitor-operational-status. Change-Id: I03701e599b6a120bc1f83da6f473b12f38660d64 Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
2021-04-08ibm: led-manager: Replace rainier with p10bmcAdriana Kobylak1-9/+9
The IBM rainier machine name is being replaced with the generic p10bmc. Tested: Verified the rainier build included the expected service files and LED override file, example: - rainier-openbmc-linux-gnueabi/obmc-phosphor-image/1.0-r0/rootfs/usr/share/phosphor-led-manager/lamp-test-led-overrides.json Change-Id: I8f9ecbc6ebe1d320a649b24bf71c5023cfc035c8 Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
2021-03-30leds: rainier: Create virtual physical LEDsVishwanatha Subbanna3-1/+45
These virtual physical LEDs are a mirror of real enclosure fault and enclosure Identify physical LEDs. However, these virtual LEDs are needed to be able to communicate the effective state of the enclosure fault and enclosure identify LEDs during lamp test. During lamp test, real physical enclosure fault and enclosure id LEDs should not be updated and they must be updated only after the lamp test finishes. However, Hypervisors would need to know the effective state of enclosure level fault and identify LEDs and that problem is resolved by these virtual LEDs. Once the lamp test finishes, these virtual physical LEDs would again be in sync with real enclosure fault and Identify LEDs. Tests: root@bmc:/lib/systemd/system/multi-user.target.wants# busctl tree xyz.openbmc_project.LED.Controller.virtual_enc_fault └─/xyz └─/xyz/openbmc_project └─/xyz/openbmc_project/led └─/xyz/openbmc_project/led/physical └─/xyz/openbmc_project/led/physical/virtual_enc_fault root@bmc:/lib/systemd/system/multi-user.target.wants# busctl tree xyz.openbmc_project.LED.Controller.virtual_enc_id └─/xyz └─/xyz/openbmc_project └─/xyz/openbmc_project/led └─/xyz/openbmc_project/led/physical └─/xyz/openbmc_project/led/physical/virtual_enc_id root@bmc:/lib/systemd/system/multi-user.target.wants# busctl get-property xyz.openbmc_project.LED.Controller.virtual_enc_fault /xyz/openbmc_project/led/physical/virtual_enc_fault xyz.openbmc_project.Led.Physical State s "xyz.openbmc_project.Led.Physical.Action.Off" root@bmc:/lib/systemd/system/multi-user.target.wants# busctl set-property xyz.openbmc_project.LED.GroupManager /xyz/openbmc_project/led/groups/ddimm0_identify xyz.openbmc_project.Led.Group Asserted b true root@bmc:/lib/systemd/system/multi-user.target.wants# busctl get-property xyz.openbmc_project.LED.Controller.virtual_enc_id /xyz/openbmc_project/led/physical/virtual_enc_id xyz.openbmc_project.Led.Physical State s "xyz.openbmc_project.Led.Physical.Action.On" root@bmc:/lib/systemd/system/multi-user.target.wants# busctlset-property xyz.openbmc_project.LED.GroupManager /xyz/op_ebmc_project/led/groups/ddimm0_identify xyz.openbmc_project.Led.Group Asserted b false root@bmc:/lib/systemd/system/multi-user.target.wants# busctl get-property xyz.openbmc_project.LED.Controller.virtual_enc_id /xyz/openbmc_project/led/physical/virtual_enc_id xyz.openbmc_project.Led.Physical State s "xyz.openbmc_project.Led.Physical.Action.Off" Change-Id: Ic0ee5b0f376911650d5489d8bb84a4e83247190f Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
2021-03-26ledmanager: Remove phosphor-led-manager-ledmanager packageVishwanatha Subbanna1-4/+4
phosphor-led-manager has 3 packages - phosphor-led-manager : Default - phosphor-led-manager-ledmanager : Packages phosphor-ledmanager - phosphor-ledmanager-faultmonitor : Packages phosphor-fru-fault-monitor Because of this, it was not possible to install files via Makefile and that always needed a corresponding update to FILES_{PN}-ledmanager. Removing phosphor-led-manager-ledmanager will eliminate this problem. Change-Id: I00ca4c34346a47f887872464b9050a46d8f5e8e9 Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
2021-03-24leds: rainier: lamptest: Enable lamp test feature for rainier systemVishwanatha Subbanna1-1/+2
This commit enables phosphor-ledmanager to do lamp test Change-Id: I4933ec034911198f99ae1289f681f15057310c33 Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
2021-03-24leds: rainier: Enable PACKAGECONFIG to use jsonVishwanatha Subbanna1-0/+3
This enables phosphor-ledmanager to use JSON configuration file Change-Id: I3cbd0bf6b60e81f9f0a479ad51dab438c708c6c1 Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
2020-12-15LEDS: Add systemd unit to call led-set-all-groups-asserted.shVishwanatha Subbanna3-0/+44
led-set-all-groups-asserted.sh needs to be called with "false" as part of below transitions to turn off all indicator LEDs - BMC booting to standby and staying at standby - BMC starting to power on (From meta-ibm rev: e784b71c2d625b4507758df4bb5743fc678251f3) Change-Id: If248220964c65e91e9382504b1a7095cc5cec26b Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com> Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
2020-06-02phosphor-led-manager: Support LED groups for swiftVishwanatha Subbanna2-0/+29
(From meta-ibm rev: 34c7a88436d2e425429b7a61065e25ce4a9b0664) Change-Id: I9d4259e36c7c7225e5f29041e204f7d75dc15720 Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com> Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
2020-04-27meta-ibm: move all meta-witherspoon metadataBrad Bishop2-0/+532
The metadata common to all IBM systems is confusingly split between meta-ibm and meta-witherspoon. Move everything to meta-ibm. The meta-ibm README is re-written to more accurately reflect the scope of the layer. Allow the configuration samples (bblayers.conf.sample, local.conf.sample) to be sourced from either meta-ibm or meta-witherspoon until such a time that any workflows and tooling have had the opportunity to move to meta-ibm. (From meta-ibm rev: 6e05ef2e90b214eaf4e43ee7027bbbb1d8d09442) Change-Id: I3ec890d5300f9649c974ea6b9dca93a2e8a889ab Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com> Signed-off-by: Andrew Geissler <geissonator@yahoo.com>