Age | Commit message (Collapse) | Author | Files | Lines |
|
openbmc/phosphor-state-manager#21 highlights an architecture issue with
OpenBMC's use of synchronization targets. When a service, such as
op-occ-disable@.service, runs both in a standard power off target,
as well as in other paths (like the host quiesce path), there is an
issue.
The service starts the synchronization targets in the quiesce path and
this causes them to already be running on the power off, resulting in
the synchronization targets not actually coordinating the power off.
The direction this commit takes OpenBMC is that if a service needs to
run outside of the standard power on or off path, then they can not
have a Wants or Requires clause in the service file.
The following commit was done a while back to address this issue:
https://gerrit.openbmc.org/c/openbmc/phosphor-state-manager/+/40026
That is that we ensure the primary power on and off targets start the
synchronization targets so services requiring them can just use a
Before or After clause.
The piece that was never done was to go and fix the services which fell
into this bucket.
Add an explicit dependency on the stop-instructions service to ensure
that this service is always run before it when they are both started
at the same time. This just provides an extra level of protection to
ensure we never stop host instructions before disabling occ
monitoring.
Tested:
- Did multiple boots, reboots, and host crash tests and saw no issues
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I6c8c32a605216c0c3dc2065f7c09236d2c216720
|
|
Zane Shelley (1):
Revert clang-format to align with openbmc/docs
Change-Id: I8159f0c09ddfffa246d508db1fce50e86b7737d4
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Zane Shelley (3):
Update signature descriptions for NMMU_FIR[41:42]
Add test case for isolation to EQ_CORE_FIR
Revert clang-format to align with openbmc/docs
Change-Id: If6ab0478bb5a168b7876be5c33d43ce9cec21b3b
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Ben Tyner (1):
Attention handler configuration file support
Change-Id: I84d847636183d6ed1d8d89425f64d69a74c2c4b9
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Jayanth Othayoth (12):
libphal: deconfigureTgt skip primary processor deconfig
libphal: Add sbe halt state handling for threadStopProc chipop
libphal: SBE chip-op failure debug data support
ipl: changed clang-format file location
ipl: clang-format: disabled SortIncludes
ipl: enabled clang-format based source formatting
libphal: Added input target type check in isPrimaryProc api
libphal: deconfigureTgt api updates
ipl:: Added clock redundant mode check helper function
libipl:p10: redundant mode clock error handling support
libipl: ATTR_SYS_CLOCK_DECONFIG_STATE based clock state update
libipl: ATTR_SYS_CLOCK_DECONFIG_STATE size update
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I8e3aa976c79e55404e165770b044a389347a1c22
|
|
Jayanth Othayoth (3):
data/p10: Added ATTR_SYS_CLOCK_DECONFIG_STATE
data/p10: ATTR_SYS_CLOCK_DECONFIG_STATE preserved_attrs_list updates
data/p10: ATTR_SYS_CLOCK_DECONFIG_STATE size update
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I01c8b9220be8f6f72c408d8bb8351aca7d80fbf0
|
|
This is to fix build dependency.
ekb: srcrev bump 79f40fbad5..184be55ec
Updated to latest version pub-ekb.
libekb: srcrev bump 9a8b5a419f..6ec7b49e43
Jayanth Othayoth (12):
PLAT: Added new constant for pub-ekb compile
makefile: added odyssey specific include headers
ekb: Update EKB to ..3bc4cc5af7
ekb: Update EKB to ..0229cf8e94
tools: enable hex format display support in scom ffdc userdata
libekb: enable code format using clang-format
libekb: Added FFDC type FFDC_TYPE_SPARE_CLOCK_INFO
plat: Added clock redundant mode check helper function
plat: redundant mode clock error handling helper function updates
plat: Enabled redundant mode clock failure callout support.
ekb: Update EKB to ..184be55ec
plat: remove attribute_info.H dependency
rajerpp1 (2):
libekb: Removing proc guard on clock failure
Adding PCI_REF_CLOCK callout
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I1dc53d952b07bd79d631239521bf6c9865758321
|
|
Jayanth Othayoth (2):
util getservice api updates
PHAL: Redundant mode clock error handling support
Change-Id: I44002eb882224bf502e237eefc8e4380c134eec0
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Zane Shelley (1):
Update to clang-format-14
Change-Id: I667b33e00c4f07e9d24109b7a0164121661bd54e
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Zane Shelley (2):
Update to clang-format-14
CORE_FIR recoverables could be blamed as checkstop root cause
Change-Id: I9444161a2f7eb47d4db95686ffdb493b888ed8fc
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Willy Tu (1):
build: Convert project to meson due to ipmid dependencies
Change-Id: Iba51deb5634799139ddf7382dcbe444ec3043ed0
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Santosh Puranik (1):
manager: Move System VPD Restore to Manager
Change-Id: Ia2874a851093bd7ac2adf7859dc360822cc9aeee
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Marri Devender Rao (1):
PHAL: mpreboot- exit with failure if no functional processor found
Change-Id: I7a597db3512ee974d6ac537388e028a3c0323d4a
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Adriana Kobylak (1):
mmc: reset: Add sleep before returning
zamiseck (1):
Ensure No Unnecessary Errors During Code Update
Change-Id: I8e067fffedd74a21a2ecb2a550661e998f53e96c
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Zane Shelley (1):
Handling for host detected LPC timeout
Change-Id: I6b5d82fd7cf1f34aac9ff4672cc06d17ccfec9d6
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Zane Shelley (1):
Updating signature for host detected LPC timeout
Change-Id: I02602195fd66a25f2ba23c00c4f6ad0052656237
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Zane Shelley (1):
Additional registers to capture for IOHS_DLP_FIR (in SMP mode)
Change-Id: I5b41865529e32a01d6b34e16af01a086ae198cbd
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Konstantin Aladyshev (1):
Correct links to the phosphor-dbus-interfaces project
Change-Id: I9e2bd2ca0a2b75e940b291689dae6cc088c90158
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Konstantin Aladyshev (1):
Correct link to the Software Architecture document
Change-Id: I750ade90e5a599c2b7e934438b4bb35ea140b023
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Andrew Geissler (1):
include what you use (array)
Change-Id: Ie553c6e3095f2beef02f964e8ace66cfa09bc940
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Priyanga Ramasamy (3):
vpd-tool not to force reset if CEC is powered ON
API to read VPD keyword from hardware
Vpd-tool:Read keyword from hardware
Change-Id: Ia22bdac9500139a1c28262e82bd065b034ad127c
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Ed Tanous (1):
Include what you use
Change-Id: I3e808e717e77f2805c694b644f750dc6d70b51e8
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Jayanth Othayoth (2):
Revert "PHAL: Additional callout support during sbe chipop timeout"
op-stop-instructions: change service timeout value to 20 sec
Change-Id: Id235f7c1885f1c4a8873a42badf55b093b4b109a
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Jayanth Othayoth (1):
PHAL: Additional callout support during sbe chipop timeout
Change-Id: I4e71567315cd2ea181b8ee1f5354ab96259a7472
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Matt Spinler (1):
setup.py: Check for version in env var
Change-Id: I263685266216c8ca8b3c6bba724631c07dda38ef
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Ed Tanous (1):
Fixing logic error
Marri Devender Rao (1):
guard: fix compiler warning comparing the result of pointer addition
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I38b8b7f05976ce2eac282cdf7c270edbb636b108
|
|
Marri Devender Rao (1):
PHAL: Log Informational error for PEL created during poweroff
Change-Id: I6df8aa4b0a6819a292b33da09e1d9f0684f66c1b
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Zane Shelley (1):
Fix outdate comment in analyzer filter support
Change-Id: I2e76b047406a3086d0c20b522e4171a075bd260f
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
zamiseck (1):
Preserved Partition Change
Change-Id: I84cc62453f0e90e29771ea8f6764b7f114f033a1
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Zane Shelley (1):
Use WOF in core unit checkstop analysis
Change-Id: I90d0c53426b84a878cfb44df47227e8755d9bc43
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
After updates Gerrit is now hosted at https://gerrit.openbmc.org.
Urls in the documentation are now updated to reflect this change.
Signed-off-by: Corey Hardesty <corey.hardesty@icloud.com>
Change-Id: I3a7f7d338ca1ce600ccf7b41fa03bd62007925ba
|
|
gdbserver improvements:
- Power9 and Power10 support
- Multi thread debugging support
- Updates to parser
libpdbg changes:
- Remove attn API, it was unused and is now part of the gdbserver
- Change behaviour of sbe_get_state to suit phal consumer
- Fix thread_stop
- Remove printing from thread_regs functions
Signed-off-by: Joel Stanley <joel@jms.id.au>
Change-Id: I5101cbd6df3c92fc11ea323f8ae6db4d18ddb5cf
|
|
Adriana Kobylak (3):
Fix shellcheck errors
mmc: Add nvram hostfw directory
mmc: Set clear NVRAM bios attribute during factory reset
Change-Id: I423b69cdb1ea3874c65c2291917a8e26455d2a46
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Sunny Srivastava (1):
System vpd restore list modification
Change-Id: I78a94a93dd152c47ba8137a41e99228c4280ab6f
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Matt Spinler (1):
setup.py: Fail on parse_chip_data_xml failures
Change-Id: If8c30e5fd72e4f15fd4271055b3a0a421b49960e
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Alpana Kumari (1):
Everest: Ignore error if PCIe on low pass
Change-Id: Icb66ba1e6f68d07222bfdf2a0e7453eb14132c20
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Zane Shelley (1):
Ignore analysis of OCMBs that have been masked
Change-Id: Ie3849c4a740bb907c06f4b736ec6f7595a61d3f4
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Santosh Puranik (2):
manager: Save and Restore BIOS Attributes
manager: Update BIOS Attributes only if needed
Change-Id: I537f38d2f57e44ac1f187903e56f8510330ffeb4
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Alpana Kumari (1):
Modify get system json
Change-Id: I42dd62412299847380451e174c38638aef1b3915
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Andrew Geissler (3):
pvm_sys_dump_active: utilize proper systemd syntax
mpreboot: collect bmc dump
pvm_sys_dump_active: ensure no failure
Change-Id: If599512c365b13f35432d9fa9e8bc6a8220a591e
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Zane Shelley (1):
Avoid guarding on TOD interfaces errors
Change-Id: I11f95a011fa922101a30f9d5d06ad9507075bb12
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
austinfcui (1):
Add Attn config option for clearing Attn Interrupts
Change-Id: Ib26dcd669fe44230c77be830074591ff5f43d766
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Alpana Kumari (2):
PEL support for GPIO failure
Handle presence GPIO read failure
Change-Id: I899f67719cea833cf118e6dcd7638ee1dc276551
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Jayanth Othayoth (1):
SBE watchdog times out callout support enhancement
Change-Id: I0f0e711627cc0af6a6aefca45b61323a9f5eb2c8
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Using /usr/bin/env is an antipattern.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I6b4f647a10fd8c261e2b42cfdae030749ded7c29
|
|
Brad Bishop (1):
OWNERS: Remove myself, add Andrew
Patrick Williams (1):
build: enable C++20
Change-Id: I98a2b3c4c01177c741fafead9b2f3b8b98ba7ce7
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Zane Shelley (1):
Enable LPC timeout handling
austinfcui (1):
Add a UT function for getActiveChips() of util/pdbg files
Change-Id: I3d9223a5b5a265b9b6e8af4bed78de21c61fe580
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Chris Cain (2):
Prevent updating power cap sysfs file when OCC not active
Ignore HRESET status when we did not request
Sheldon Bailey (2):
BMC: Fan control for Idle Power saver
openpower_occ_control: Support new APSS sensor IDs
Change-Id: I7568db8114bb139a91daa51054f9c67df4a44a9c
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|
|
Enable the xdma trace events for p10bmc
Signed-off-by: Eddie James <eajames@linux.ibm.com>
Change-Id: Ib7c741fc47cd53492df5a970f1cb315583c4384f
|
|
Priyanga Ramasamy (1):
VPD ECC shared library
Change-Id: I4bd2be40104893980a40607b48607ccb18700aab
Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
|