summaryrefslogtreecommitdiff
path: root/meta-phosphor/recipes-phosphor/dump
AgeCommit message (Collapse)AuthorFilesLines
2022-06-03phosphor-debug-collector: srcrev bump 124d31f09c..919f71c652Andrew Geissler1-1/+1
Claire Weinan (1): faultlog: Initial framework for Fault Log Change-Id: I8d52909edff2174495cfdb30876efb7e24f24edb Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-14dump: move dump plugins to repository but install from recipe.Marri Devender Rao1-1/+1
1) Move ibm specific plugins from recipe to tools/dreport.d/ibm.d/plugins.d in the repository 2) Move openpower specific plugins from recipe to tools/dreport/opepower.d/plugins.d in the repository. 4) Modified to install the plugins from the machine specific plugin folder from the repository Reference links https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-debug-collector/+/52852/ https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-debug-collector/+/52479 Includes: phosphor-debug-collector: srcrev bump 02634e5531..124d31f09c Marri Devender Rao (3): openpower:dreport: add guarded resolved and ephemeral records to BMC dump ibm:dreport add vpd persistent data to BMC dump dreport: Fix network and timedate plugin failures during BMC dump generation Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com> Change-Id: I0bd350b9b564c4e98a6765902de76274f90500e4
2022-04-09phosphor-debug-collector: srcrev bump 6f4870aadc..02634e5531Andrew Geissler1-1/+1
Marri Devender Rao (5): dreport: add active file descriptors list to the BMC dump dreport: add hwmon details to the BMC dump openpower:dreport: add PHAL device tree debug data to BMC dump dreport: add active services (systemd) status to the BMC dump openpower:dreport: add core and BMC generated dump file list to the BMC dump Patrick Williams (3): main: move busname claiming later sdbusplus: object: don't use 'bool' argument constructor meson: simplify dependencies Change-Id: I6ecf79266124aa410d4a2d080a68fccb39f4ebaf Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-04-06phosphor-debug-collector: srcrev bump 56bd797e0a..6f4870aadcAndrew Geissler1-1/+1
Marri Devender Rao (4): dreport: add network details to the BMC dump dreport: Add time and date to the BMC dump dreport: add fanctl dump output to BMC dump openpower:dreport: add obmconsole1 log file to the BMC dump Change-Id: Ice66587e41fd465748253a57dcf13c21cac90887 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-03-18phosphor-debug-collector: srcrev bump af3b526dd3..56bd797e0aAndrew Geissler1-1/+1
Xie Ning (1): Fix the invalid value of Elapsed property Change-Id: I73e31325723a6d0e69d082c22733b8921adef5a1 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-03-09phosphor-debug-collector: srcrev bump 18be42d015..af3b526dd3Andrew Geissler1-1/+1
Jayanth Othayoth (1): dreport: Added error handling support in badvpd Change-Id: Ifbdbcc8759cedf8e7cb92a1e3e7efc77e13d0b0f Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-03-01meta-phosphor: dump: Add dump offload applicationDhruvaraj Subhashchandran1-0/+1
Update recipe to add new application for offloading BMC stored dumps Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com> Change-Id: Ib1c266b3452278c41261ed3bcb0c5b58135c0d8d
2022-02-25phosphor-debug-collector: srcrev bump 41b74cc763..18be42d015Andrew Geissler1-1/+1
Jayanth Othayoth (4): dreport: fix missing log messages related to skipping copy dreport: fix symlinks copy dreport: Added pldmflightrecorder plugin dreport: Added dmesginfo plugin Change-Id: Ic329eb5e380730a1b4622eda97b60980d85a7b66 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-01-26debug-trigger: srcrev bump 9c7783babc..1161642d22Andrew Geissler1-1/+1
Andrew Jeffery (15): OWNERS: Fix typo in 'matchers' MAINTAINERS: Remove in favour of OWNERS meson: Add some compiler options process: Lift debug implementation to separate function process: Lift reboot implementation to separate function main: Use /proc/sysrq-trigger for reboot as well as crash main: Add some documentation main: Extract a 'sink' abstraction main: Add --sink-actions=... command-line option main: Extract a 'source' abstraction main: Add a 'dbus' set of sink actions systemd: Start after the dump manager systemd: Configure command-line using the environment main: Be clear about what we failed to open main: Log command read from source Change-Id: I8c671e9b559404251fb64230fc46ae386ffc002a Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2022-01-25treewide: fix up github SRC_URIsPatrick Williams2-2/+2
Per [1], Yocto is going to start requiring both branch names and `protocol=https` in GitHub SRC_URI variables. Ran the upstream tool to automatically fix our URIs. 1. https://git.yoctoproject.org/poky/tree/documentation/migration-guides/migration-3.5.rst#n10 Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I5f9619f7ff707050b469ae74c8aa16846568c5e4
2022-01-13phosphor-debug-collector: srcrev bump 9b4716aef3..41b74cc763Andrew Geissler1-1/+1
Dhruvaraj Subhashchandran (1): Remove host running check for system dump Change-Id: Ibe2b1ae39b2aaf182d3fdec12b900db82e44b94c Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-11-03meta-phosphor:meson: pkgconfig inherit requiredAndrew Geissler1-1/+1
Upstream yocto made a change recently that brought to light a bug in some of our recipes. If your meson makefiles utilize the dependency() function then the recipe must also include pkgconfig. Signed-off-by: Andrew Geissler <geissonator@yahoo.com> Change-Id: Ie85e2a3bd86010c2ce5d08c75fddc1ba348ff891
2021-10-30phosphor-debug-collector: srcrev bump 2a6835d765..9b4716aef3Andrew Geissler1-1/+1
Manojkiran Eda (1): Add OWNERS file Change-Id: I3175b35824ed1e9ffb9ea70888daa1cc12b1c376 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-10-27debug-trigger: srcrev bump 15fe59cb0f..9c7783babcAndrew Geissler1-1/+1
Manojkiran Eda (1): Add OWNERS file Change-Id: Ia463217362f0d67d82294aba07f997f901ecc64f Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-10-18phosphor-debug-collector: srcrev bump 9d2d722643..2a6835d765Andrew Geissler1-1/+1
George Liu (1): ramoops: Check files in pstore Change-Id: Ieda41504fbb35adee1a6bc2d26ab143c5ecdddbc Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-10-15phosphor-debug-collector: Fix invalied escape sequenceGeorge Liu1-1/+1
There is a warning message in the phosphor-debug-collector repo when using bitbake to build image-bmc: DeprecationWarning: invalid escape sequence \W config_values = re.split('\W+', parse_value, 1) The reason is that `\W` is regarded as an escaped character, add `r` to fix it. Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: I59836e7df9a73a01d47cd03e916f0ab1b8c2d716
2021-10-08phosphor-debug-collector: srcrev bump 52ac69c152..9d2d722643Andrew Geissler1-1/+1
Patrick Williams (7): meson: fix sdbus++ program for subprojects .gitignore: update for meson conversion meson: add proper cereal dependency meson: update to c++20 meson: remove cpp-fs dependency meson: update deprecated source_root() catch exceptions as const Change-Id: Icfaf773a26d02cd5842a0305b540f3e9ca8f7fb1 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-09-08phosphor-debug-collector: srcrev bump f4694d714f..52ac69c152Andrew Geissler1-1/+1
Patrick Williams (2): cleanup sdbus CAMELCASE define exception: switch to public sdbus exception Change-Id: I99e44fb87d06d5b2001eee892cb25dc973e554f5 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-08-18phosphor-debug-collector: srcrev bump 0eadeb7e78..f4694d714fAndrew Geissler1-1/+1
George Liu (1): ramoops_manager: Handle D-Bus exceptions Change-Id: Ibcebfd13c4c9019e3fe540d67e742eae2c4dedfb Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-08-11meta-phosphor: prep for new override syntaxPatrick Williams3-15/+15
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I588025b614416c43aa2d053765ab53bacf890cb5
2021-08-04phosphor-debug-collector: srcrev bump 796a92ee40..0eadeb7e78Andrew Geissler1-1/+1
Lei YU (1): core_manager: Handle dbus exceptions Change-Id: I7071c6a2ae409e7272dbecd0f578a36f320127ac Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-07-28phosphor-debug-collector: srcrev bump ddc3366e3e..796a92ee40Andrew Geissler1-1/+1
Dhruvaraj Subhashchandran (2): Enable dump offload function to download all locally stored dumps Move OpenPOWER specific dump configurations to extension Change-Id: I6925decd29a159240e723b25f435f5d61a6825b0 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-07-26phosphor-dbus-interfaces and phosphor-debug-collectorAndrew Geissler1-1/+1
phosphor-dbus-interfaces: srcrev bump 178cae08d6..c6f2d7a7f1 Dhruvaraj Subhashchandran (1): In dump create add type uint64 for values in additional parameters phosphor-debug-collector: srcrev bump 363af249c9..ddc3366e3e Dhruvaraj Subhashchandran (1): Update dump create parameters Change-Id: I19f621a4c7aef7a3abc267f51c0814cf8aad3f7b Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-07-22dump: Add ramoops serviceGeorge Liu2-0/+15
- Create a new package for the ramoops service and only load it once when the debug-collector daemon starts - Fix openbmc/phosphor-debug-collector#15 Tested: - Built obmc-phosphor-image and saw the ramoops-monitor run successfully. Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: Ic616408b834a257a981f0e0ef24ad030ccffc616
2021-07-16phosphor-debug-collector: srcrev bump 6341919fc1..363af249c9Andrew Geissler1-1/+1
George Liu (4): Collect ramoops data into BMC dump build: Add wrapfiles for dependencies Add fmtlib for phosphor-debug-collector Fix wrong fmt::format strings Tim Lee (1): Adjust current size of total dump files in dump directory Change-Id: I8b84b90cf089127591e64c023c985bb1695b385d Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-07-12phosphor-debug-collector: Add fmt dependencyGeorge Liu1-0/+1
Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: I32e22b2e832998cbcf0dca2cd5f502f0156a0d8e
2021-06-18debug-trigger: srcrev bump 20017150d2..15fe59cb0fAndrew Geissler1-1/+1
Andrew Jeffery (1): meson: Remove redundant udevrules list Change-Id: Ia35655f677b159744f7b103698eee4e1561fa427 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-06-17meta-phosphor: Add debug-trigger recipeAndrew Jeffery1-0/+34
debug-trigger listens for an external signal that the BMC is in some way unresponsive. When the signal is received it triggers a crash to collect debug data and reboots the system in the hope that it will recover. Change-Id: Ib8ea615c2944edb0448b06c333b6e2abbea15687 Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
2021-05-21phosphor-debug-collector: srcrev bump 4bc1c2be9a..6341919fc1Andrew Geissler1-1/+1
Bruce Mitchell (1): Replace IRC with Discord Change-Id: Iccd787f836a27bad6682e58ec07f59834238713d Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-12phosphor-debug-collector: srcrev bump 0af74a5e46..4bc1c2be9aAndrew Geissler1-1/+1
Patrick Williams (1): use new sdbus++ camelcase Change-Id: I38a4cf1b4f508cec609735adcff0cb6778131e81 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-05-07debug-collector: Fix unclosed file in bb fileGeorge Liu1-0/+1
- The intent behind this commit is to fix the unclosed file in the phosphor-debug-collector_git.bb file. - When using `bitbake phosphor-debug-collector` to compile it, the warning message is: ResourceWarning: unclosed file <_io.TextIOWrapper name='phosphor-debug-collector/tools/dreport.d/plugins.d/hostlogger' mode='r' encoding='UTF-8'> install_dreport_user_script(srcname, d) Tested: built phosphor-debug-collector successfully and worked. Signed-off-by: George Liu <liuxiwei@inspur.com> Change-Id: Id95b4a6369571db876acee0ed90953cd3874fff1
2021-04-15phosphor-debug-collector: srcrev bump 22448c5621..0af74a5e46Andrew Geissler1-1/+1
Jayanth Othayoth (2): c++17: drop experimental::filesystem Update clang-format Change-Id: I440953d9ce2d4be5e794691297aa34a9e6263c3a Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-04-10phosphor-debug-collector: srcrev bump 537642dad8..22448c5621Andrew Geissler1-1/+1
Chirag Sharma (1): dreport: Populating missing fields of header Change-Id: I085639b573a55fcbd6bbc892fb68147d29e40b86 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-03-27phosphor-debug-collector: srcrev bump 0c782d64f6..537642dad8Andrew Geissler1-1/+1
PriyangaRamasamy (1): Collect Bad VPD as a part of BMC dump. Change-Id: I9b507ff20966e9dc52f057b3084b1f57f9364b35 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-03-26phosphor-debug-collector: srcrev bump 01c6646064..0c782d64f6Andrew Geissler1-1/+1
Dhruvaraj Subhashchandran (1): Error while invalidating the resource dump over PLDM. Change-Id: Icb588852cc1186f0f7e58e65bb9a47bb4ad85ebd Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-03-19phosphor-debug-collector: srcrev bump 4c63ce5e2e..01c6646064Andrew Geissler1-1/+1
PriyangaRamasamy (1): Fix build issues due to updated arm-sdk Change-Id: Ieaaf6c001b779a980eaa90af055ef5d7b7e91ca0 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-02-24phosphor-debug-collector: srcrev bump 2f8e276c0b..4c63ce5e2eAndrew Geissler1-1/+1
Dhruvaraj Subhashchandran (1): Add support for resource dump delete. Change-Id: I5f8f7d1a105460c400150a2b63fbce543dbec093 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-02-12phosphor-debug-collector: srcrev bump e22aca712e..2f8e276c0bAndrew Geissler1-1/+1
Dhruvaraj Subhashchandran (1): Move emit_object_added to respective dump entry classes Change-Id: Ib3172819933ebddfb0e035579511eb3a8731d802 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com>
2021-02-10dump: Adding workaround for jffs2 file systemChirag Sharma2-7/+5
Change: Incase of jffs2 the jffs-workaround flag will be enabled and will watch IN_CLOSE_WRITE event during core file creation. For rest of the file systems(ubifs, ext4 etc) the flag will be disabled and will watch for IN_CREATE event. For more details please refer to "openbmc/openbmc#2240" and "openbmc/openbmc#2287" issues. Signed-off-by: Chirag Sharma <chirshar@in.ibm.com> Change-Id: I4c43473ae557f3fe45a583e0206d52b318773c88
2021-01-20phosphor-debug-collector: srcrev bump f37c5c3b3e..24e0c5910aAndrew Geissler1-1/+1
Andrew Geissler (1): mpipl: move from diagnostic target to crash target Dhruvaraj Subhashchandran (3): Allow initiating or offloading host dumps only when host is up. Add Resource dump support Change the the namespace of OpenPOWER dumps. Ramesh Iyyar (1): host-transport: pldm: default: Added missing header (From meta-phosphor rev: cc5ce150b4c89b259f85385b5c35c37064f82c79) Change-Id: I3a94f7e8531499cb30e570a3c78fc033ab6aa401 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com> Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
2021-01-13phosphor-debug-collector and phosphor-dbus-interfacesAndrew Geissler1-1/+1
phosphor-debug-collector: srcrev bump 969f9a5904..f37c5c3b3e Dhruvaraj Subhashchandran (1): Remove unused DumpType from Notify implementation. phosphor-dbus-interfaces: srcrev bump a57b7e1a0d..962f955868 Dhruvaraj Subhashchandran (1): Update Notify method to remove unused DumpType Matt Spinler (1): thresholds: Add 2 new threshold interfaces (From meta-phosphor rev: a9ee1a90ff39a31e6ca884ea9b669755bffeab79) Change-Id: I48cafc668a8a58fcc95c285104bc7a776094e199 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com> Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
2020-12-22phosphor-dbus-interfaces: srcrev bump a3943e6e38..4bd4033c79Andrew Geissler1-1/+1
Dhruvaraj Subhashchandran (2): Update dump create interface to accept a set of parameters. Add Entry and create parameters enum for resource dump. phosphor-debus-collector: srcrev bump 2279386bf7..969f9a5904 Dhruvaraj Subhashchandran (1): Update createDump to accept additional parameters. (From meta-phosphor rev: 0f7ad23295ae6310dc110b4cabf1e97e61f83632) Change-Id: I65df3e3bb03ab7ccc4223b7f1dfe97a64c231184 Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com> Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
2020-12-17dump: Used renamed build optionRamesh Iyyar2-3/+3
- The phosphor-debug-collector renamed "host-dump-offload-transport" build option into "host-transport" to make generic for supporting other host dump action (i.e create,delete) not only offload so, changed build option here as well based on phosphor-debug-collector. - In this patch bumping "phosphor-dbus-interfaces" as well to get bumped "phosphor-debug-collector" dependent dbus changes. - Modified "ffdc" recipe to use phosphor-debug-collector.inc to avoid version update in two different place Version bump info: - phosphor-dbus-interfaces: SRCREV: 02f196d..a3943e6 Dhruvaraj Subhashchandran (1): Update Create interface to return object path. - phosphor-debug-collector: SRCREV: ff9c452..2279386 Dhruvaraj Subhashchandran (2): Return the object path for user requested dumps. Progress tracking support for dump entries. Ramesh Iyyar (4): host-dump: Renamed host-dump-offload-transport build option offload: Moved existing pldm offload as oem/ibm command ibm-host-system-dump-offload: Used CustomFd host: Added support to delete system dump phosphor-debug-collector patch: https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-debug-collector/+/38792 (From meta-phosphor rev: 17743ee6f06480be7806d64d50f6bda1a2d4f5df) Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com> Change-Id: I54e01c192170b710977aa54439a02044a34e481e Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
2020-12-16phosphor-debug-collector: srcrev bump 8b9b4690a4..ff9c4527eaAndrew Geissler1-1/+1
Ravi Teja (1): Modify dump offload method to write dump on to unix socket path (From meta-phosphor rev: 4cb25cf5bea4c066584cab7617d0163589221d56) Change-Id: I9c805f42802d55838638bfea213d8af724266ec4 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com> Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
2020-10-14Add Open Power dumps as a package and bump.Dhruvaraj Subhashchandran1-0/+5
Add open power dumps as a package so that can be enabled on the systems or achitectures which supports that. phosphor-debug-collector: srcrev bump c237e3d..8b9b469 (From meta-phosphor rev: 9cc0e41c87fd5db2e786d71a65b5809aab8ff847) Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com> Change-Id: I2c9af7b2b3c4b7d49db3db2a02b9dcd301fee846 Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
2020-10-08phosphor-debug-collector: srcrev bump c237e3d8fe..8b9b4690a4Andrew Geissler1-1/+1
Dhruvaraj Subhashchandran (1): Make OpenPower specific dump an optional feature (From meta-phosphor rev: f42c194ede7fd2b936d0b32a6d8fd01251554cb2) Change-Id: Id921f89f7d2aff6bbc707fee2ee5b7a61b4f4fac Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com> Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
2020-09-30phosphor-debug-collector: srcrev bump 7040bce74b..c237e3d8feAndrew Geissler1-1/+1
Chirag Sharma (1): Creating dump header for IBM systems (From meta-phosphor rev: d28d03765b2de80ee8fdf5ee97565b023d76c7a7) Change-Id: Idc78923cdb3aa75397a16ee1a7b190448c580004 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com> Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
2020-09-26phosphor-debug-collector: srcrev bump 5042725366..7040bce74bAndrew Geissler1-1/+1
Dhruvaraj Subhashchandran (3): Fix shellcheck errors in dreport Create dump manager for each dump type. Implement user requested system dump. (From meta-phosphor rev: e9301773a15a88d8bfc2511e8728c2fee4d4082f) Change-Id: Ibe9d4d5dac2a998e10a8b18bfa672334576b3c85 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com> Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
2020-09-23phosphor-debug-collector: srcrev bump e6d6cc831d..5042725366Andrew Geissler1-1/+1
Chirag Sharma (1): Unit test framework for phosphor-debug-collector (From meta-phosphor rev: caa67ea3f56655c7d3054ec0b77a4dbd1252981d) Change-Id: I72741361d9c3fe3034597ed33840ae7c9ec41409 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com> Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
2020-08-26phosphor-debug-collector: srcrev bump bb410df796..e6d6cc831dAndrew Geissler1-1/+1
Ramesh Iyyar (1): build: Removed autotools support (From meta-phosphor rev: 025ed4f735dfdf0f9e16044a3decf4153b7618f6) Change-Id: Iad9c19b63ececf613442cb9b3b5684cc1f7f13f9 Signed-off-by: Andrew Geissler <openbmcbump-github@yahoo.com> Signed-off-by: Andrew Geissler <geissonator@yahoo.com>