From c22d38baefc5a7a1e1f5cdc9dbb556b1f0ec5c57 Mon Sep 17 00:00:00 2001 From: Nick Clifton Date: Thu, 30 Mar 2023 10:10:09 +0100 Subject: [PATCH] Fix an illegal memory access when an accessing a zer0-lengthverdef table. PR 30285 * elf.c (_bfd_elf_slurp_version_tables): Fail if no version definitions are allocated. CVE: CVE-2023-1972 Upstream-Status: Backport Signed-off-by: Ross Burton --- bfd/ChangeLog | 6 ++++++ bfd/elf.c | 5 +++++ 2 files changed, 11 insertions(+) diff --git a/bfd/elf.c b/bfd/elf.c index 027d0143735..185028cbd97 100644 --- a/bfd/elf.c +++ b/bfd/elf.c @@ -9030,6 +9030,9 @@ _bfd_elf_slurp_version_tables (bfd *abfd, bool default_imported_symver) bfd_set_error (bfd_error_file_too_big); goto error_return_verdef; } + + if (amt == 0) + goto error_return_verdef; elf_tdata (abfd)->verdef = (Elf_Internal_Verdef *) bfd_zalloc (abfd, amt); if (elf_tdata (abfd)->verdef == NULL) goto error_return_verdef; @@ -9133,6 +9136,8 @@ _bfd_elf_slurp_version_tables (bfd *abfd, bool default_imported_symver) bfd_set_error (bfd_error_file_too_big); goto error_return; } + if (amt == 0) + goto error_return; elf_tdata (abfd)->verdef = (Elf_Internal_Verdef *) bfd_zalloc (abfd, amt); if (elf_tdata (abfd)->verdef == NULL) goto error_return; -- 2.34.1