From 5a4271456104bdf027644c81c3a208cde5cf522e Mon Sep 17 00:00:00 2001 From: Tim Orling Date: Thu, 17 Nov 2022 16:33:20 -0800 Subject: [PATCH] Skip TODO test cases that fail TODO cases report as "not ok" with ptest-runner Upstream-Status: Inappropriate [ptest-runner specific] Signed-off-by: Tim Orling --- t/escape-char.t | 20 ++++++++++---------- t/iri.t | 18 +++++++++--------- t/mailto.t | 12 ++++++------ 3 files changed, 25 insertions(+), 25 deletions(-) diff --git a/t/escape-char.t b/t/escape-char.t index c6ce79c..5e62ad5 100644 --- a/t/escape-char.t +++ b/t/escape-char.t @@ -6,16 +6,16 @@ use warnings; use Test::More; use URI (); -TODO: { - my $str = "http://foo/\xE9"; - utf8::upgrade($str); - my $uri = URI->new($str); - - local $TODO = 'URI::Escape::escape_char misunderstands utf8'; - - # http://foo/%C3%A9 - is("$uri", 'http://foo/%E9', 'correctly created a URI from a utf8-upgraded string'); -} +#TODO: { +# my $str = "http://foo/\xE9"; +# utf8::upgrade($str); +# my $uri = URI->new($str); +# +# local $TODO = 'URI::Escape::escape_char misunderstands utf8'; +# +# # http://foo/%C3%A9 +# is("$uri", 'http://foo/%E9', 'correctly created a URI from a utf8-upgraded string'); +#} { my $str = "http://foo/\xE9"; diff --git a/t/iri.t b/t/iri.t index cf983d6..884b36e 100644 --- a/t/iri.t +++ b/t/iri.t @@ -6,7 +6,7 @@ use Test::More; use Config qw( %Config ); if (defined $Config{useperlio}) { - plan tests=>30; + plan tests=>28; } else { plan skip_all=>"this perl doesn't support PerlIO layers"; } @@ -67,17 +67,17 @@ is $u->as_iri, "http://➡.ws/"; # draft-duerst-iri-bis.txt examples (section 3.7.1): is(URI->new("http://www.example.org/D%C3%BCrst")->as_iri, "http://www.example.org/D\xFCrst"); is(URI->new("http://www.example.org/D%FCrst")->as_iri, "http://www.example.org/D%FCrst"); -TODO: { - local $TODO = "some chars (like U+202E, RIGHT-TO-LEFT OVERRIDE) need to stay escaped"; -is(URI->new("http://xn--99zt52a.example.org/%e2%80%ae")->as_iri, "http://\x{7D0D}\x{8C46}.example.org/%e2%80%ae"); -} +#TODO: { +# local $TODO = "some chars (like U+202E, RIGHT-TO-LEFT OVERRIDE) need to stay escaped"; +#is(URI->new("http://xn--99zt52a.example.org/%e2%80%ae")->as_iri, "http://\x{7D0D}\x{8C46}.example.org/%e2%80%ae"); +#} # try some URLs that can't be IDNA encoded (fallback to encoded UTF8 bytes) $u = URI->new("http://" . ("ü" x 128)); is $u, "http://" . ("%C3%BC" x 128); is $u->host, ("\xC3\xBC" x 128); -TODO: { - local $TODO = "should ihost decode UTF8 bytes?"; - is $u->ihost, ("ü" x 128); -} +#TODO: { +# local $TODO = "should ihost decode UTF8 bytes?"; +# is $u->ihost, ("ü" x 128); +#} is $u->as_iri, "http://" . ("ü" x 128); diff --git a/t/mailto.t b/t/mailto.t index 79e9a13..c68cfb2 100644 --- a/t/mailto.t +++ b/t/mailto.t @@ -48,12 +48,12 @@ $u = URI->new('mailto:user+detail@example.com'); is $u->to, 'user+detail@example.com', 'subaddress with `+` parsed correctly'; is $u, 'mailto:user+detail@example.com', '... and stringification works'; -TODO: { - local $TODO = "We can't handle quoted local parts without properly parsing the email addresses"; - $u = URI->new('mailto:"foo bar+baz"@example.com'); - is $u->to, '"foo bar+baz"@example.com', 'address with quoted local part containing spaces is parsed correctly'; - is $u, 'mailto:%22foo%20bar+baz%22@example.com', '... and stringification works'; -} +#TODO: { +# local $TODO = "We can't handle quoted local parts without properly parsing the email addresses"; +# $u = URI->new('mailto:"foo bar+baz"@example.com'); +# is $u->to, '"foo bar+baz"@example.com', 'address with quoted local part containing spaces is parsed correctly'; +# is $u, 'mailto:%22foo%20bar+baz%22@example.com', '... and stringification works'; +#} # RFC 5321 (4.1.3) - Address Literals