diff options
| author | Ed Tanous <ed@tanous.net> | 2024-04-21 02:36:00 +0300 |
|---|---|---|
| committer | Ed Tanous <ed@tanous.net> | 2024-04-26 08:09:46 +0300 |
| commit | 511650a90260e0922bfeb1091b4babc597d36af6 (patch) | |
| tree | 5295a081eb0d0d13382a2b7c5f8b07dab9e76097 | |
| parent | 740cbd525fa619e6a4190ec08c80f45ae72435eb (diff) | |
| download | webui-vue-511650a90260e0922bfeb1091b4babc597d36af6.tar.xz | |
Allow the favicon to be cached
The favicon is currently loaded directly by url. This commit changes it
to be loaded by file-loader. Note, the default vue webpack file loader
doesn't support ico file types (because it seems to expect to use a png
here), so add that to the file loader config.
This allows bmcweb [1] to provide caching headers for the favicon, and
avoid downloading a new favicon on every refresh.
Tested: Webui-vue loads, favicon in the network panel loads properly.
[1] https://gerrit.openbmc.org/c/openbmc/bmcweb/+/70644
Change-Id: I27e5b459ff8822294ac9273220111e9944e8d1e5
Signed-off-by: Ed Tanous <ed@tanous.net>
| -rw-r--r-- | public/index.html | 2 | ||||
| -rw-r--r-- | vue.config.js | 8 |
2 files changed, 9 insertions, 1 deletions
diff --git a/public/index.html b/public/index.html index c355ece4..e96efdaf 100644 --- a/public/index.html +++ b/public/index.html @@ -5,7 +5,7 @@ <meta charset="utf-8"> <meta http-equiv="X-UA-Compatible" content="IE=edge"> <meta name="viewport" content="width=device-width,initial-scale=1.0"> - <link rel="icon" href="<%= BASE_URL %>favicon.ico"> + <link rel="icon" href="<%= require('./favicon.ico') %>"> <title>OpenBMC Web UI</title> </head> <body> diff --git a/vue.config.js b/vue.config.js index bd226746..e66d5d15 100644 --- a/vue.config.js +++ b/vue.config.js @@ -61,6 +61,14 @@ module.exports = { .rule('vue') .use('vue-svg-inline-loader') .loader('vue-svg-inline-loader'); + config.module + .rule('ico') + .test(/\.ico$/) + .use('file-loader') + .loader('file-loader') + .options({ + name: '[name].[contenthash:8].[ext]', + }); }, configureWebpack: (config) => { config.plugins.push( |