diff options
author | Yoshie Muranaka <yoshiemuranaka@gmail.com> | 2020-02-19 19:07:40 +0300 |
---|---|---|
committer | Gunnar Mills <gmills@us.ibm.com> | 2020-02-22 00:28:30 +0300 |
commit | c11d38945b8a51e4181142c2b8852ffcb30338d9 (patch) | |
tree | 5c13c0b058214e273100bacb06232f7daff2f831 /src/components/Global | |
parent | 4ee8d290a5d45ce93419c819a6e7544d3a009b99 (diff) | |
download | webui-vue-c11d38945b8a51e4181142c2b8852ffcb30338d9.tar.xz |
Add Reboot BMC page
Created a ControlStore with the intention to consolidate actions
across multiple subnav pages under the 'Control' tab, instead of
creating a dedicated RebootBmc store with one action.
- Update PageSection component to make sectionTitle prop optional
- Changed PageTitle computed property to data since the value
doesn't change during the component lifecycle
- Change PageSection <section> element to <div> to avoid
accessibility issues
Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I2877e2a7b9bfee245c48d52c70859978b74be7f3
Diffstat (limited to 'src/components/Global')
-rw-r--r-- | src/components/Global/PageSection.vue | 9 | ||||
-rw-r--r-- | src/components/Global/PageTitle.vue | 8 |
2 files changed, 9 insertions, 8 deletions
diff --git a/src/components/Global/PageSection.vue b/src/components/Global/PageSection.vue index 03040b29..dcd85e61 100644 --- a/src/components/Global/PageSection.vue +++ b/src/components/Global/PageSection.vue @@ -1,8 +1,8 @@ <template> - <section class="page-section"> - <h2>{{ sectionTitle }}</h2> + <div class="page-section"> + <h2 v-if="sectionTitle">{{ sectionTitle }}</h2> <slot /> - </section> + </div> </template> <script> @@ -11,7 +11,7 @@ export default { props: { sectionTitle: { type: String, - required: true + default: '' } } }; @@ -21,6 +21,7 @@ export default { .page-section { margin-bottom: $spacer * 2; } + h2 { @include font-size($h4-font-size); margin-bottom: $spacer; diff --git a/src/components/Global/PageTitle.vue b/src/components/Global/PageTitle.vue index 59bb6a1e..17c08849 100644 --- a/src/components/Global/PageTitle.vue +++ b/src/components/Global/PageTitle.vue @@ -14,10 +14,10 @@ export default { default: '' } }, - computed: { - title() { - return this.$t(this.$route.meta.title); - } + data() { + return { + title: this.$t(this.$route.meta.title) + }; } }; </script> |