Age | Commit message (Collapse) | Author | Files | Lines |
|
All changes should be whitespace, and were done using npm run-script
lint.
Change-Id: I943c6b435c5c872841af5affc1e89910468b5ca6
Signed-off-by: Ed Tanous <ed@tanous.net>
|
|
Being on an old version of eslint is causing conflicts in our builds,
but because we pull in the @vue/cli-plugin-eslint plugin, we can't
upgrade. @vue is non trial to update, because webui-vue is on vue 4.X,
while the latest is 5.X.
This commit upgrades eslint to the latest version, and at the same time
disables @vue/cli-plugin-eslint. Not having a cli plugin doesn't seem
like it would be any amount of impact, as devs can just run eslint
manually.
At the same time, to fix a minor issue, update all of @vue to the latest
minor revision 4.5.12->4.5.19
Change-Id: I3ca9c7bbee5bdf9046d86e25e7130808b9caaa2b
Signed-off-by: Ed Tanous <ed@tanous.net>
|
|
New versions of the vue linter flag that this class has no effect. It
isn't clear what the intent was, so remove it so the linter can pass.
Tested: Upgraded linter now passes.
Change-Id: Icccc4d57714be313c958023c74e9d8508afed4ce
Signed-off-by: Ed Tanous <ed@tanous.net>
|
|
Format code is supposed to do just that... format code. npm ci is doing
much more than that, so it belongs in run-ci.
Change-Id: I4c4e94f1a53e04aa13289aea259098143377cc2c
Signed-off-by: Ed Tanous <ed@tanous.net>
|
|
New versions of vuex warn if there are modules that are used in an
element that haven't had their namespace defined. This module isn't
actually used in the test, so add an empty Vuex module that matches the
name of AuthenticationStore, so the test can pass.
Change-Id: I5bceb3e1e0bad603028cfb17fa95b020d68ceb4d
Signed-off-by: Ed Tanous <ed@tanous.net>
|
|
The commit "Add SNMP alerts page and test hooks"
(7c1cfe7e25957fc915fc9790bdf78887295b1fee) has added a new page to the
navigation, but didn't change the shanpshot. As a result this broke the
unit tests.
Perform "npx jest --updateSnapshot" to automatically correct the
AppNavigation snapshot.
Tested: Did npm run test:unit and it passed.
Change-Id: I9f9dbf235013d8736d958d5c8d19eb3d75c575ba
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
Spanish was on the list, but the actual translation was missing
Change-Id: I36fd0542954f048fceea7c6ad7b1e0f207e70df8
Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru>
|
|
With a large number of FANs, a list of names is much easier to read than
a list of IDs. Now the Name is in the header of the row, and the ID only
when expanded.
Change-Id: Ic8a08e28db7f747f9765f45dbbda504bf827fb25
Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru>
|
|
I have multiple email addresses in my Gerrit account but as
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/69506 shows my Preferred
email has to match the OWNERS file, do that.
More discussion in Discord at
[1] https://discord.com/channels/775381525260664832/817151035197358081/1209585278025601094
Tested: With https://gerrit.openbmc.org/c/openbmc/bmcweb/+/69549 my +2
means something again.
Change-Id: I56c3813cd3f5feb5f0b614786dea374efe19dc79
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
Add russian translations that were missed in a commit
5d86af86e5dd0c4c7d9e902fc191c8b19ac890d1
("Add State to DIMM slot inventory summary").
Change-Id: I127fd05a2ceb621c3ba455b9caf89578b48e5cf9
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
|
|
Add state information in DIMM slot inventory summary so that users can
know if the DIMM slot has DIMM plugged or not.
Change-Id: Id9b7ebb2079762b354b418d060d4a1223273b50d
Signed-off-by: HuyLe <hule@amperecomputing.com>
|
|
Issue: when clicking the Refresh button at top right corner of the
WebUI, sensors that were removed from Redfish are not removed from the
WebUI but still shown with old sensor values.
Root cause: current code keeps a list of sensors. Click on Refresh
button just checks and updates sensors returned by Redfish, it does not
check if sensors are still present or not. This is incorrect for
sensors on hot plug devices or PLDM sensors when the sensor source is
not available. In this case, sensors are completely removed instead of
just their values changed to n/a.
Solution: Initialize an empty array sensor state to retrieve
existing sensor data whenever loading sensors.
Change-Id: Ifb0c0586fdba22b6f446c58b3d5b937a3f3ee750
Signed-off-by: HuyLe <hule@amperecomputing.com>
|
|
- if isServerPowerOffRequired is true & !isServerOff is true
a warning will be shown that the server must be powered off
to switch images and update the firmware.
- When system power is on,
the switch to "running button" is disabled.
Signed-off-by: Kenneth Fullbright <kennyneedsmilky@gmail.com>
Change-Id: I65a24984c36f6ae39d715f4fa66e9884d031cb20
|
|
When the IPv4 address is in DHCP mode, hide the trashcan icon.
If the address is in static IPv4 mode, the trashcan icon will show
that the user can delete the IPv4 static address.
Change-Id: I27dc8dc64d93b1e2425de6143473a91f7bc0b104
Signed-off-by: Sivaprabu Ganesan <sivaprabug@ami.com>
|
|
As part of [1] There are deprecated login flows that webui-vue seems to
have copied from phosphor-rest. These were originally added because
phosphor-rest didn't look at response codes, but webui-vue does, so we
can use the normal version, which allows us to reduce the code in
bmcweb.
This needs to go the same time as [1].
Tested: Gunnar tested with 65810 and this works.
[1] https://gerrit.openbmc.org/c/openbmc/bmcweb/+/65810
Change-Id: I1e55f08cf1d7d44b6757ac4173a26546eaca72e5
Signed-off-by: Ed Tanous <edtanous@google.com>
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
This page will be included in Configuration section of the primary
navigation. The user will be able to delete and add alert destination.
Change-Id: I396d19a54ea11724f2c5aec67e20ba9abff947d3
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
|
|
Just like the commit before it, enabling this on the env Intel, enable
VUE_APP_FAN_DATA_FROM_THERMAL_SUBSYSTEM and ThermalSubsystem for the fan
data.
Change-Id: Iaf8164ed622546579a379c707ebbc9660017379b
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
Fan data API switch in Inventory and LEDs page based on
environment variable VUE_APP_FAN_DATA_FROM_THERMAL_SUBSYSTEM.
Backend Support PR:
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/57533
Change-Id: I95ac9f9cef97bdab84a179b3e318eb37ab11752b
Signed-off-by: Sivaprabu Ganesan <sivaprabug@ami.com>
|
|
For https://nvd.nist.gov/vuln/detail/CVE-2022-0235, update node-fetch to
2.6.7.
For https://nvd.nist.gov/vuln/detail/CVE-2022-0536 and
https://nvd.nist.gov/vuln/detail/CVE-2022-0155, update follow-redirects
to 1.14.8.
Tested:
Confirmed that I can still log into the web UI.
Change-Id: I044014ac07ce3c88f63b1a66d8677cf80617cd5a
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>
|
|
- This patchset will try to connect to the WebSocket with the path 'console/default'.
- Until now, we were connecting to 'console0'.
Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com>
Change-Id: I6136e09458284b76f5b03f89be247db3e3ff82fd
|
|
Redfish deprecated the Processor/Memory Summary Status (state, health,
healthrollup) attributes. Please refer to redfish spec for more details:
https://redfish.dmtf.org/schemas/v1/ComputerSystem.v1_20_0.json
These attributes are already removed from the bmcweb code:
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/62731
So currently webui-vue tries to access not present attributes and fails,
and since these fields are not marked as optional, 'Server Overview'
card fails to display.
Drop processor and memory summary status attributes handling to correct
the issue.
Change-Id: I7fb956a0a310c6bd85560169b1ca0a64c19dc824
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
|
|
Looks like a new bump of the tools caught us.
Saw this fail on
https://gerrit.openbmc.org/c/openbmc/webui-vue/+/63442
Fails like:
```
diff --git a/docs/guide/components/page-section/index.md
b/docs/guide/components/page-section/index.md
index 94113c5..a37d67c 100644
--- a/docs/guide/components/page-section/index.md
+++ b/docs/guide/components/page-section/index.md
@@ -6,7 +6,7 @@ string will be rendered in an `h2` header element.
```vue
// Example: `src/views/AccessControl/Ldap/Ldap.vue`
- <page-section :section-title="$t('pageLdap.settings')">
+<page-section :section-title="$t('pageLdap.settings')"></page-section>
```
```
Change-Id: I1ada18a09050c5fbcc773a28ef20b8af1b7e84e4
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
1."api.get()" need to add 'config' parameter for some circumstance
need to modify configure.
2.The second param of api.delete() is payload not config.
3."api.patch()" need to add 'config' parameter for some circumstance
need to modify configure.
4."api.put()" need to add 'config' parameter for some circumstance
need to modify configure.
Change-Id: I2df9eae468933c043dd9be1e12d2e2aeb9576ae8
Signed-off-by: Bowei Yu <yubowei0982@phytium.com.cn>
|
|
Fix minor difference in EN/RU translation that was introduced in a
commit 568b8a93af49d35891f042f73add850cfa651308
("Sessions page Client ID is not displayed").
Change-Id: I4d4c3275a954fd9a005d81ea1a51571cb54ff23a
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
|
|
Add russian translations that were missed in a commit
bcb0ab4f1e933795e53da7c28ca75382c94f9af9
("Old password input in change password screen").
Change-Id: I44eacf1ab099f70a72db19c88b1cffad344028fb
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
|
|
Add russian translations that were missed in a commit
65fa7bf8c8bb0f3f856c69f7d8aa61808ad6994a
("OpenLDAP and Active Directory is taken from translation file").
Change-Id: I7154dab0f68009763d560c3f534d313dac93aeba
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
|
|
Bug description:
Before this commit KVM window wasn't being closed
after logging out
Test: Step1. Launch webui on browser and see KVM page on /#/operations/kvm.
Step2. Open additional window using 'Open in new tab'.
Step3. Navigate to another page. For example, /#/operations/key-clear.
Step4. Logout. Window is still open.
Change-Id: Ife79ebca41eb4d588c0b8f4fae06135420eda155
Signed-off-by: Konstantin Maskov <sulwirld@gmail.com>
|
|
There is a request to see three additional fields from Redfish in the
DIMM inventory table: https://github.com/openbmc/webui-vue/issues/107.
This change adds Manufacturer, Error correction, and Rank count data
from Redfish into the DIMM inventory table.
Tested:
Confirmed that the three fields show in the table with the correct data
from Redfish.
Change-Id: I6f1fc5103649abf8350e5b5c107c11eea3d1a599
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>
|
|
- OpenLDAP and Active Directory were hardcoded in the file, Hence, now, it is taken from the
translation file in this commit.
Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com>
Change-Id: Iebf557fbb20842878cce34c7f2969031af1765dd
|
|
Nicole is no longer working on the project, remove her name and the
section about becoming a design partner.
Change-Id: I1b25dc1f5479093fed1b645bbc6b352fd75eea37
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
Propose myself (Kirankumar Ballapalli) as an additional maintainer.
I have contributed following patches to the webui-vue package.
[1] commits:
https://gerrit.openbmc.org/q/owner:kirankumarb%2540ami.com
Change-Id: Ifcb12a4bdb6b3365860fbe264c1b79bbf6d23a8a
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
Sandeepa has left the project. Thank you for all the work on OpenBMC!
Change-Id: I6e2a68f56a6730c93cbe5aaec8b5476700e574c2
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
AngularJS is end of life, correct that. Recommend switching from
phosphor-webui. Further minor README improvements.
Change-Id: I5067a9b5c6fc775bfa684fa1af4cb9a8142629dc
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
After logged on via Safari web browser, click <user> -> Log out button
does not take effect until clicking on other tab. The current page still
works normally. For example, in Virtual Media page, after clicking on
the Log out button, nothing happens and we can still mount ISO file.
The issue does not happen on Chrome or Firefox.
Fix the issue by changing router.go() to router.push().
Reference:
https://github.com/vuejs/vue-router/issues/2554
https://codewithandrea.com/articles/flutter-navigation-gorouter-go-vs-push/
Tested:
1. Check if the issue does not happen on Safari anymore.
2. Check if no issue with Google Chrome and Mozilla Firefox.
Change-Id: I2ae35dad2dec6b19c3cb9d7f8d577b6077ac8d9c
Signed-off-by: Thang Q. Nguyen <thang@os.amperecomputing.com>
Signed-off-by: HuyLe <hule@amperecomputing.com>
|
|
This patchset will provide the option to configure the session timeout
for the WebUI. The functionality will provide the below timeout options
to configure.
1. 30 minutes
2. 1 hour
3. 2 hours
4. 4 hours
5. 8 hours
6. 1 Day
For the API, redfish is having the following resource.
URL - /redfish/v1/SessionService
Method
- GET (to get the configured timeout)
- PATCH (to configure the timeout value)
Property - { "SessionTimeout": 1800 }
When the user idles up until the configured session timeout, after that
any API call from this session will get 401 status and the web UI will
gets logged out.
Change-Id: Ic7c6b4817e560ca4ceb983dc5e2af51f3ae08cf5
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
Resolved and Unresolved status button in event log page is shown
or hidden based on the environment variable
VUE_APP_EVENT_LOGS_TOGGLE_BUTTON_DISABLED
Change-Id: If99a9705d4690995fb998daa979c21c61c3cc4a7
Signed-off-by: Sivaprabu Ganesan <sivaprabug@ami.com>
|
|
This change removes the hardcoded chassis URL from FanStore. Now
the URL is taken from the odata.id.
Signed-off-by: MichalX Szopinski <michalx.szopinski@intel.com>
Change-Id: I59e4d46a8aaa453f6662f4f396f32d7fad18fb91
|
|
According to the Redfish specification, the address to update the
firmware is set in redfish/v1/UpdateService with the HttpPushUri
variable.
```
https://github.com/openbmc/bmcweb/commit/4dc23f3fb6c9a7cef84658f8ab3b703d29ec7d57
```
Change-Id: I29566a8ab2d06b658ab62f61c34be00fbbba0571
Signed-off-by: greenfil <mikl@greenfil.ru>
|
|
Now Health status will be "Ok" if there are no unsolved problems in the
log.
Before this patch, the flag "solved" was not considered.
Test:
Created a log entry with the status of "Critical" and "Warning".
Health became Critical.
Event Critical pressed Resolved. Health became "Warning".
Event Warning pressed Resolved. Health became "Ok".
Change-Id: Ic74a4c488c1c806c478c562a17fc0bb132e66e8f
Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru>
|
|
Saving power cap value was throwing an error, and it was caused by
incorrect endpoint to PowerControl resource in
Redfish: https://redfish.dmtf.org/schemas/v1/Power.v1_7_1.json
Fixed endpoint for saving Power Cap value
Signed-off-by: Damian Celico <damianx.celico@intel.com>
Change-Id: Ib9117f62548c55eb3f07562b71330675a2101924
|
|
At the moment, the Overview page shows the total number of log errors
and warnings, even if they are marked as "resolved". After the patch,
only unresolved errors and warnings are counted.
Test:
Created an error event and a warning event in the log.
The Overview page displays 1 and 1.
Marked them as resolved.
The Overview page displays 0 and 0.
Change-Id: I8ee1122bbec3e678d33edfbd2035d02553fb64ea
Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru>
|
|
In the event logs page, if the filter options are selected for both
severity and status, it displays row that falls into either of the
two categories: severity or status.
The filter options are in two categories:
severity [OK, Warning, Critical], and status [Resolved, Unresolved]
If select the filter options "Critical" on severity and "Unresolved"
on status, it shows every row whose status is "Unresolved" whether its
severity is "Ok" or "Warning", If the row data is "Critical" or
"Unresolved", it shows in the table. As per the filter selection, it
shouldn't show the row data that has "Ok" or "Warning" but the status
is "Unresolved"; it should show only the row data that is in both
"Critical" and "Unresolved".
This commit will work as follows: if different categories are
selected, that will be applied with an "and" logic, and within the
same category, it will be applied with an "or" logic.
Change-Id: I5ddf6e5ebe35c961306e68885febf6f2324ebaee
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
Display API error messages on Local user managment tab.
Change-Id: I8ffe2359aa454503d07e8895907202bd0d8493f5
Signed-off-by: MichalX Szopinski <michalx.szopinski@intel.com>
|
|
On the session Web UI page, when we disconnect the current session,
instead of navigating to the login page, the browser populates the
authentication window for basic authorization.
If basic authentication is enabled, we are adding the www-authenticate
header to unauthorizing requests.
As per redfish, we have to set the "Accept" and "X-Requested-With"
header for the request from Web UI. This patch set will add those
headers.
Tested:
Logged in to the WebUI and navigated to the sessions page. Clicked
"Disconnect" to the current session and the WebUI is navigated to login.
page as expected.
Change-Id: I61cccbf41e854683e6cd5aa80fa72593ae4aa698
Signed-off-by: Ed Tanous <edtanous@google.com>
|
|
When the user changed their password in profile settings, to prevent
XSS attacks, I added the current password input field to authenticate
the user.
Once the authentication had success with the current password, then
allowing the update was possible. After the password is changed
successfully, all the sessions of the user who changed the password
will be disconnected, including the current session. and the current
session will navigate to the login page.
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
Change-Id: Idb8bc9d6ada420329c38407da76a08dc83fddd61
|
|
Since %{settings} template variable in this case takes values like
'DHCP' or 'IPv4' the translation string needs minor correction.
Change-Id: I987e3a8a60fd3f1bba163fcf81904dda303fe036
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
|
|
Add russian translations that were missed in a commit
e8cb2c6a81e8abb75cb63c10c29008d868e7fef2
("Added DHCP enable/disable feature").
Change-Id: Ida37e9864f12424011c8c1b12eb1cac126672112
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
|
|
This patchset will fix the following issues in the user management page
1. "lockoutThreshold" and "lockoutDuration" values are not shown in the
account policy model when we navigate to any other page and come back
to the user management page account policy model.
Fix - The "lockoutThreshold" and "lockoutDuration" values are monitored
and updated in the model window by using the watch. When navigated from
another page, the watch is not updating the values, so the default
values are displayed. Initialized the value with an empty object, so
the watch will get triggered and update the fields with proper values.
2. The User Management Page title is not translated properly. The
router names are used to map each page's language objects. For the user
management page, the router name and the object value in the locale
file are different. Due to that, the title did not get translated
properly.
Fix - Changed the user management page title to match the locale file's
language object key value.
Change-Id: I1582c9d528633465c65f5d78e31d3dc740252cb0
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
This commit allows us to add 'exclusiveToRoles' field to
route config files, with the list of roles that can access
this resource, if needed. In this case, only Administrator
can access Virtual-Media page and SOL console, and it is blocked for other
users.
Signed-off-by: Sivaprabu Ganesan <sivaprabug@ami.com>
Change-Id: Ibcee18bd92d97c34414ecaf2caf6af28070c5538
|
|
Redfish added support for the Context parameter on the session resource
This parameter has the same function that the "OemSession.ClientId"
field served. And BMC Web moves all the existing ClientId code to
produce Context. This patch set contains the code changes for adding a
new column "Context" in the sessions page and modifying the existing
column "Client ID" to "Session ID" and mapping the redfish property
"Id" to it.
The property "Context" is optional in redfish. If the Context holds any
value it will display in WebUI as it is. If it is not having any value,
"-" will be displayed in the WebUI.
Change-Id: Ibc99416fc37a91029bf430ccc7b387832eef729c
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|