| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
There is a request to see three additional fields from Redfish in the
DIMM inventory table: https://github.com/openbmc/webui-vue/issues/107.
This change adds Manufacturer, Error correction, and Rank count data
from Redfish into the DIMM inventory table.
Tested:
Confirmed that the three fields show in the table with the correct data
from Redfish.
Change-Id: I6f1fc5103649abf8350e5b5c107c11eea3d1a599
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>
|
|
- OpenLDAP and Active Directory were hardcoded in the file, Hence, now, it is taken from the
translation file in this commit.
Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com>
Change-Id: Iebf557fbb20842878cce34c7f2969031af1765dd
|
|
Nicole is no longer working on the project, remove her name and the
section about becoming a design partner.
Change-Id: I1b25dc1f5479093fed1b645bbc6b352fd75eea37
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
Propose myself (Kirankumar Ballapalli) as an additional maintainer.
I have contributed following patches to the webui-vue package.
[1] commits:
https://gerrit.openbmc.org/q/owner:kirankumarb%2540ami.com
Change-Id: Ifcb12a4bdb6b3365860fbe264c1b79bbf6d23a8a
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
Sandeepa has left the project. Thank you for all the work on OpenBMC!
Change-Id: I6e2a68f56a6730c93cbe5aaec8b5476700e574c2
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
AngularJS is end of life, correct that. Recommend switching from
phosphor-webui. Further minor README improvements.
Change-Id: I5067a9b5c6fc775bfa684fa1af4cb9a8142629dc
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
After logged on via Safari web browser, click <user> -> Log out button
does not take effect until clicking on other tab. The current page still
works normally. For example, in Virtual Media page, after clicking on
the Log out button, nothing happens and we can still mount ISO file.
The issue does not happen on Chrome or Firefox.
Fix the issue by changing router.go() to router.push().
Reference:
https://github.com/vuejs/vue-router/issues/2554
https://codewithandrea.com/articles/flutter-navigation-gorouter-go-vs-push/
Tested:
1. Check if the issue does not happen on Safari anymore.
2. Check if no issue with Google Chrome and Mozilla Firefox.
Change-Id: I2ae35dad2dec6b19c3cb9d7f8d577b6077ac8d9c
Signed-off-by: Thang Q. Nguyen <thang@os.amperecomputing.com>
Signed-off-by: HuyLe <hule@amperecomputing.com>
|
|
This patchset will provide the option to configure the session timeout
for the WebUI. The functionality will provide the below timeout options
to configure.
1. 30 minutes
2. 1 hour
3. 2 hours
4. 4 hours
5. 8 hours
6. 1 Day
For the API, redfish is having the following resource.
URL - /redfish/v1/SessionService
Method
- GET (to get the configured timeout)
- PATCH (to configure the timeout value)
Property - { "SessionTimeout": 1800 }
When the user idles up until the configured session timeout, after that
any API call from this session will get 401 status and the web UI will
gets logged out.
Change-Id: Ic7c6b4817e560ca4ceb983dc5e2af51f3ae08cf5
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
Resolved and Unresolved status button in event log page is shown
or hidden based on the environment variable
VUE_APP_EVENT_LOGS_TOGGLE_BUTTON_DISABLED
Change-Id: If99a9705d4690995fb998daa979c21c61c3cc4a7
Signed-off-by: Sivaprabu Ganesan <sivaprabug@ami.com>
|
|
This change removes the hardcoded chassis URL from FanStore. Now
the URL is taken from the odata.id.
Signed-off-by: MichalX Szopinski <michalx.szopinski@intel.com>
Change-Id: I59e4d46a8aaa453f6662f4f396f32d7fad18fb91
|
|
According to the Redfish specification, the address to update the
firmware is set in redfish/v1/UpdateService with the HttpPushUri
variable.
```
https://github.com/openbmc/bmcweb/commit/4dc23f3fb6c9a7cef84658f8ab3b703d29ec7d57
```
Change-Id: I29566a8ab2d06b658ab62f61c34be00fbbba0571
Signed-off-by: greenfil <mikl@greenfil.ru>
|
|
Now Health status will be "Ok" if there are no unsolved problems in the
log.
Before this patch, the flag "solved" was not considered.
Test:
Created a log entry with the status of "Critical" and "Warning".
Health became Critical.
Event Critical pressed Resolved. Health became "Warning".
Event Warning pressed Resolved. Health became "Ok".
Change-Id: Ic74a4c488c1c806c478c562a17fc0bb132e66e8f
Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru>
|
|
Saving power cap value was throwing an error, and it was caused by
incorrect endpoint to PowerControl resource in
Redfish: https://redfish.dmtf.org/schemas/v1/Power.v1_7_1.json
Fixed endpoint for saving Power Cap value
Signed-off-by: Damian Celico <damianx.celico@intel.com>
Change-Id: Ib9117f62548c55eb3f07562b71330675a2101924
|
|
At the moment, the Overview page shows the total number of log errors
and warnings, even if they are marked as "resolved". After the patch,
only unresolved errors and warnings are counted.
Test:
Created an error event and a warning event in the log.
The Overview page displays 1 and 1.
Marked them as resolved.
The Overview page displays 0 and 0.
Change-Id: I8ee1122bbec3e678d33edfbd2035d02553fb64ea
Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru>
|
|
In the event logs page, if the filter options are selected for both
severity and status, it displays row that falls into either of the
two categories: severity or status.
The filter options are in two categories:
severity [OK, Warning, Critical], and status [Resolved, Unresolved]
If select the filter options "Critical" on severity and "Unresolved"
on status, it shows every row whose status is "Unresolved" whether its
severity is "Ok" or "Warning", If the row data is "Critical" or
"Unresolved", it shows in the table. As per the filter selection, it
shouldn't show the row data that has "Ok" or "Warning" but the status
is "Unresolved"; it should show only the row data that is in both
"Critical" and "Unresolved".
This commit will work as follows: if different categories are
selected, that will be applied with an "and" logic, and within the
same category, it will be applied with an "or" logic.
Change-Id: I5ddf6e5ebe35c961306e68885febf6f2324ebaee
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
Display API error messages on Local user managment tab.
Change-Id: I8ffe2359aa454503d07e8895907202bd0d8493f5
Signed-off-by: MichalX Szopinski <michalx.szopinski@intel.com>
|
|
On the session Web UI page, when we disconnect the current session,
instead of navigating to the login page, the browser populates the
authentication window for basic authorization.
If basic authentication is enabled, we are adding the www-authenticate
header to unauthorizing requests.
As per redfish, we have to set the "Accept" and "X-Requested-With"
header for the request from Web UI. This patch set will add those
headers.
Tested:
Logged in to the WebUI and navigated to the sessions page. Clicked
"Disconnect" to the current session and the WebUI is navigated to login.
page as expected.
Change-Id: I61cccbf41e854683e6cd5aa80fa72593ae4aa698
Signed-off-by: Ed Tanous <edtanous@google.com>
|
|
When the user changed their password in profile settings, to prevent
XSS attacks, I added the current password input field to authenticate
the user.
Once the authentication had success with the current password, then
allowing the update was possible. After the password is changed
successfully, all the sessions of the user who changed the password
will be disconnected, including the current session. and the current
session will navigate to the login page.
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
Change-Id: Idb8bc9d6ada420329c38407da76a08dc83fddd61
|
|
Since %{settings} template variable in this case takes values like
'DHCP' or 'IPv4' the translation string needs minor correction.
Change-Id: I987e3a8a60fd3f1bba163fcf81904dda303fe036
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
|
|
Add russian translations that were missed in a commit
e8cb2c6a81e8abb75cb63c10c29008d868e7fef2
("Added DHCP enable/disable feature").
Change-Id: Ida37e9864f12424011c8c1b12eb1cac126672112
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
|
|
This patchset will fix the following issues in the user management page
1. "lockoutThreshold" and "lockoutDuration" values are not shown in the
account policy model when we navigate to any other page and come back
to the user management page account policy model.
Fix - The "lockoutThreshold" and "lockoutDuration" values are monitored
and updated in the model window by using the watch. When navigated from
another page, the watch is not updating the values, so the default
values are displayed. Initialized the value with an empty object, so
the watch will get triggered and update the fields with proper values.
2. The User Management Page title is not translated properly. The
router names are used to map each page's language objects. For the user
management page, the router name and the object value in the locale
file are different. Due to that, the title did not get translated
properly.
Fix - Changed the user management page title to match the locale file's
language object key value.
Change-Id: I1582c9d528633465c65f5d78e31d3dc740252cb0
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
This commit allows us to add 'exclusiveToRoles' field to
route config files, with the list of roles that can access
this resource, if needed. In this case, only Administrator
can access Virtual-Media page and SOL console, and it is blocked for other
users.
Signed-off-by: Sivaprabu Ganesan <sivaprabug@ami.com>
Change-Id: Ibcee18bd92d97c34414ecaf2caf6af28070c5538
|
|
Redfish added support for the Context parameter on the session resource
This parameter has the same function that the "OemSession.ClientId"
field served. And BMC Web moves all the existing ClientId code to
produce Context. This patch set contains the code changes for adding a
new column "Context" in the sessions page and modifying the existing
column "Client ID" to "Session ID" and mapping the redfish property
"Id" to it.
The property "Context" is optional in redfish. If the Context holds any
value it will display in WebUI as it is. If it is not having any value,
"-" will be displayed in the WebUI.
Change-Id: Ibc99416fc37a91029bf430ccc7b387832eef729c
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
If the user switches pages between the KVM and Virtual Media pages
after the session has expired, it won't redirect to the login page.
So I have added the system redfish API call in the create method to
check the session timeout status. If the session is expired, the API
call will get a 401 status, and WEBUI will be redirected to the
login page.
Change-Id: I069768ee0cef41afb4e6aa770bb8bec6565a16bd
Signed-off-by: Kirankumarb07 Ballapalli <kirankumarb@ami.com>
|
|
Nikhil has contributed to webui-vue and continues to give review
feedback.
https://gerrit.openbmc.org/q/owner:a.nikhil%2540ibm.com
Change-Id: Id0bcbf82e17fcf8204a13468572fa21b40ba6ad1
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
There is no validation handle before checking the page title name
from the router. Which causes the pre-commit script to through error.
This patch set will handle this scenario and fix the break.
Change-Id: I5aed3bfeba643c2eb2b2753bf8f6d984b5100361
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
Problem : "handleSubmit" called on clicking Ok button implicitly as
well by the form
(<b-form id="generate-csr-form" novalidate @submit.prevent=
"handleSubmit"), due to this,
redfish API POST /redfish/v1/CertificateService/Actions/Certificate
Servi
ce.GenerateCSR
sent two times when "Generate CSR" button clicked,ideally redfish API
needs to be sent only once
This leads to failure of the second redfish API.
Steps to Reproduce Issue:
1. Go to 'Login->Security and access->Certificate->Generate CSR fill
the form
2. Click on 'Generate CSR.'
3. Scroll down to 'More Tools->Web Developer Tools->Network tab'
4. Two POST /redfish/v1/CertificateService/Actions/CertificateService.
GenerateCSR are sent
Solution: The issue can be fixed either by deleting the Ok button click
event listener or deleting
the (@submit.prevent="handleSubmit"). I have used later one, which is
small change as well does not
alter the code much
Tested : I did manual testing and observed that two POST requests
are no longer sent
Reference : https://softauthor.com/vuejs-prevent-form-submission/
Signed-off-by: Chandra Harkude <chandramohan.harkude@gmail.com>
Change-Id: I8736e597d2fe70aef438779667475426837d2c67
|
|
When the SOL console is opened in a new window, the status of the SOL
connection is displayed as "disconnected." And the error message is
displaying, "The system must be powered on to connect."
I have added this patch to get the systems API call to get the server
status when SOL is opened in a new window.
Change-Id: I971947fea0980605d400d46bb1e18b2d20164602
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
Utilize '#LogService.ClearLog' action to provide a possibility for the
user to clear POST code logs.
Change-Id: Iadd94b9ebc93bc81b13ee979962103587c939fc7
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
|
|
Description:
When KVM is opened in new window, after WEB UI is logged out,
opened KVM window is not getting closed. It remains opened and
accessible.
Root Cause:
There is not handle to close the KVM new window after the WEB UI
logged out.
Fix:
Added the KVM window opened information in store, and checked that
information to close the window.
Tested:
Step 1: Login to WEB UI
Step 2: Navigate to Operations -> KVM
Step 3: Open KVM in new window
Step 4: Click Logout in WEB UI
Result:
After successful log out, KVM new window is closed as expected.
Change-Id: Iab8e54d3088a08fb0ae9b581b2647fc0ab5460bd
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
- DHCP toggle for enablement was not present, It is now added in
the Networks page.
- DHCP when enabled, if there is no address, it picks up an address on its own.When it is disabled, we need to manually configure it.
Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com>
Change-Id: I32a9e0df28e6609945f3757a6bd69dc66a86f480
|
|
I use this patch to convert all values into the
format <Description>:<Value><Unit of Measure>.
I put the units of measure in a separate
localization area in order to use them in
the sensor page in the future.
Change-Id: Ic6554860c4185bc4d681a97205051799c6637b5c
Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru>
|
|
Showing error message if uploaded certificate is incorrect
Signed-off-by: Damian Celico <damianx.celico@intel.com>
Change-Id: Ifa034e663329e4841ff5c68f6171ce71739a6d13
|
|
On the sensor page and user management page, some of the strings are
not getting translated to the selected language.
I have added this patch to add the multiple language strings to the
missing strings.
Change-Id: I03ca43bb81708f85e913e39c6dfa24ab7f3de876
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
Log in and log out of the application, change the language, and login
to the application. The heading and title are in the previous language
translation is handled in the router, and the languages are selected
after the router has rendered.The page title and heading translation
are handled after the language is selected.
Change-Id: Iba42fe3a535fe0b402f551c3f43e19d5ff12181d
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
Bug description:
Before this commit there was an endless loading
on blue bar when user entering to the Overview.
Problem was missing `if` statement
after what that promise wasn't be able to finish.
Test:
Step1. Launch webui on browser and see Overview page.
Step2. Wait a while. Blue loading bar finished pulsing.
Change-Id: I2ea3b6f125ca24fcefeea8020c4a903ea018f4f7
Signed-off-by: Konstantin Maskov <sulwirld@gmail.com>
|
|
Add myself to the reviewer list so I can become a maintainer one day.
Change-Id: I00ed700c35ba9771a368ea6528e0f74942f028fe
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
Description 1:
When WebUI creates the user with an already existing username
the error message will display the exact failure reason.
Tested:
Step 1: Login to webUI and navigate to user management page
Step 2: Create new user with username "testUser1"
Step 3: Create another user with same username "testUser1"
Step 4: WEB UI will through the error message
as "Username 'testuser1' already exists."
Description 2:
User can able to disable and change the root user via WebUI
Now restricted to disable the root user and changing the
root user privilege.
Tested:
Step 1: Login to Web UI with root user
Step 2: Navigate to User management page
Step 3: Try to modify the root user's details
Step 4: WebUI won't allow to disable the user,
username change and privilege change
Step 5: Login Web UI with non-root user
Step 6: Web UI won't allow to modify or delete the root
user's details
Change-Id: I0e38215b51fb058984664ec38ae9613e18043ed7
Signed-off-by: Sivaprabu Ganesan <sivaprabug@ami.com>
|
|
Description:
The sensor count in WebUI is mismatched when compared to
IPMI and REDFISH responses. When Web UI is iterating the
sensor response property, the iteration is stopped when
the key value is undefined. As a result, the sensor details
in the web UI are incorrect. So added the code changes to
check the property value in every iteration, whether the
value is present or not.
Tested:
Step 1: Login to WEB UI
Step 2: Navigate to Hardware Status and Sensors
Step 3: Check the sensor details with IPMI and redfish response
Step 4: All the sensors and those details in the IPMI and redfish
response are listing in Web UI
Change-Id: Icf5098b3dd2413851e755d9ede17a8501cbb7411
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
Description 1:
Downloading the CSR certificate data value without
encodeURIComponent function is not supported in Firefox
So added the encodeURIComponent function to download the
csr certificate
Tested:
Step 1: Launch WEBUI on firefox
Step 2: Navigate to Security and access, Certificates Page
Step 3: Generate and Download CSR certificate
(KeyPair Algorithm - EC and Key curve id - secp521r1)
Step 4: After CSR Downloaded, copy the downloaded
file to any of the linux machine
Step 5: Try to create an https/ldap certificate
via openssl on linux machine
Result:
Able to download the CSR certificate successfully
and able to create https/ldap certificate via openssl
Description 2:
While downloading the generated csr via Web UI,
the csr file is getting downloaded as ".txt" file
but it should download as ".csr" file
So changed the extension to ".csr"
Tested:
Step 1: Login to Web UI.
Step 2: Navigate to Security and access, Certificates Page
Step 3: Click Generate CSR Button and fill the required details
Step 4: Click Generate CSR from the popup modal.
Step 5: After CSR Generated an prompt will open
and it will show download and copy option. In that select download,
the csr certificate will download with ".csr" extension
Change-Id: Ice176006a95afd53845d7696ce0eac88f02b1096
Signed-off-by: Sivaprabu Ganesan <sivaprabug@ami.com>
|
|
Only when the host is turned off should the status be "Disconnected".
For other host states, the SOL status should be Connected.
Test: enabled my host in DiagnosticMode. Now SOL status is "Connected",
before the patch it was "Disconnected
Signed-off-by: glukhov.mikhail <mikl@greenfil.ru>
Change-Id: I000b181f71d7ee5bd243a3c6a6d03ea7a9ea0ef7
|
|
Removed the MemorySize field for DIMMs,
because it is missing in Redfish
```
https://www.dmtf.org/sites/default/files/standards/documents/DSP8010.zip
```
Change-Id: I12f37a601e429060765960f3c66b5249b84eabe7
Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru>
|
|
Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.
Change-Id: I2804ee3ab5ff6bcbf986b028db2fafec8e616779
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
If identify LED for the DIMM module is not present, don't display
control element for it.
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Change-Id: I30f7e3ad9333874bbeb2050c421baf509bb833fc
|
|
The reason for this problem is uniqBy always keep the first one when removing repetition
Resolves: https://github.com/openbmc/webui-vue/issues/60
Change-Id: Iec87d7845e694b0f2a14de4061ae113eac492fc0
Signed-off-by: wangqi02 <wangqi02@inspur.com>
|
|
Before the patch, the diagnostic mode was displayed as "Not available",
after the patch "Diagnostic mode".
Test: in the console run the command
"busctl set-property xyz.openbmc_project.State.Host \
/xyz/openbmc_project/state/host0 \
xyz.openbmc_project.State.Host CurrentHostState \
s "xyz.openbmc_project.State.Host.HostState.DiagnosticMode".
open the "Server power operations" page,
check the Server status
Signed-off-by: glukhov.mikhail <mikl@greenfil.ru>
Change-Id: I90d04e05188eb92c4c4b38fe578ae36db0424b5c
|
|
Delete button in event logs page is shown
or hidden based on the enviroment variable
VUE_APP_EVENT_LOGS_DELETE_BUTTON_ENABLED
Signed-off-by: Damian Celico <damianx.celico@intel.com>
Change-Id: I10a46f5ef147865f954e6f94bcefec5c280ad3ea
|
|
Add russian translations that were missed in a commit
112dbb266e659e252e42f2230ddb4a80a467da20
("Server manufacturer and Firmware version on Overview tab").
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Change-Id: I17994d86f10a3bd860d493af7045214aa3c66800
|
|
Add russian translations that were missed in a commit
31fb2b96a58492c3214197685787f42f305a42ad
("Check certificate file extension").
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Change-Id: I99facf93497cc62326638db79bdd6a4930b857d7
|
|
Change-Id: Id9bbacb752c142f712e4e5e752b74c5bac848d81
Signed-off-by: wangqi02 <wangqi02@inspur.com>
|
