| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
Issue: when clicking the Refresh button at top right corner of the
WebUI, sensors that were removed from Redfish are not removed from the
WebUI but still shown with old sensor values.
Root cause: current code keeps a list of sensors. Click on Refresh
button just checks and updates sensors returned by Redfish, it does not
check if sensors are still present or not. This is incorrect for
sensors on hot plug devices or PLDM sensors when the sensor source is
not available. In this case, sensors are completely removed instead of
just their values changed to n/a.
Solution: Initialize an empty array sensor state to retrieve
existing sensor data whenever loading sensors.
Change-Id: Ifb0c0586fdba22b6f446c58b3d5b937a3f3ee750
Signed-off-by: HuyLe <hule@amperecomputing.com>
|
|
As part of [1] There are deprecated login flows that webui-vue seems to
have copied from phosphor-rest. These were originally added because
phosphor-rest didn't look at response codes, but webui-vue does, so we
can use the normal version, which allows us to reduce the code in
bmcweb.
This needs to go the same time as [1].
Tested: Gunnar tested with 65810 and this works.
[1] https://gerrit.openbmc.org/c/openbmc/bmcweb/+/65810
Change-Id: I1e55f08cf1d7d44b6757ac4173a26546eaca72e5
Signed-off-by: Ed Tanous <edtanous@google.com>
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
This page will be included in Configuration section of the primary
navigation. The user will be able to delete and add alert destination.
Change-Id: I396d19a54ea11724f2c5aec67e20ba9abff947d3
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
|
|
Fan data API switch in Inventory and LEDs page based on
environment variable VUE_APP_FAN_DATA_FROM_THERMAL_SUBSYSTEM.
Backend Support PR:
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/57533
Change-Id: I95ac9f9cef97bdab84a179b3e318eb37ab11752b
Signed-off-by: Sivaprabu Ganesan <sivaprabug@ami.com>
|
|
Redfish deprecated the Processor/Memory Summary Status (state, health,
healthrollup) attributes. Please refer to redfish spec for more details:
https://redfish.dmtf.org/schemas/v1/ComputerSystem.v1_20_0.json
These attributes are already removed from the bmcweb code:
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/62731
So currently webui-vue tries to access not present attributes and fails,
and since these fields are not marked as optional, 'Server Overview'
card fails to display.
Drop processor and memory summary status attributes handling to correct
the issue.
Change-Id: I7fb956a0a310c6bd85560169b1ca0a64c19dc824
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
|
|
1."api.get()" need to add 'config' parameter for some circumstance
need to modify configure.
2.The second param of api.delete() is payload not config.
3."api.patch()" need to add 'config' parameter for some circumstance
need to modify configure.
4."api.put()" need to add 'config' parameter for some circumstance
need to modify configure.
Change-Id: I2df9eae468933c043dd9be1e12d2e2aeb9576ae8
Signed-off-by: Bowei Yu <yubowei0982@phytium.com.cn>
|
|
There is a request to see three additional fields from Redfish in the
DIMM inventory table: https://github.com/openbmc/webui-vue/issues/107.
This change adds Manufacturer, Error correction, and Rank count data
from Redfish into the DIMM inventory table.
Tested:
Confirmed that the three fields show in the table with the correct data
from Redfish.
Change-Id: I6f1fc5103649abf8350e5b5c107c11eea3d1a599
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>
|
|
After logged on via Safari web browser, click <user> -> Log out button
does not take effect until clicking on other tab. The current page still
works normally. For example, in Virtual Media page, after clicking on
the Log out button, nothing happens and we can still mount ISO file.
The issue does not happen on Chrome or Firefox.
Fix the issue by changing router.go() to router.push().
Reference:
https://github.com/vuejs/vue-router/issues/2554
https://codewithandrea.com/articles/flutter-navigation-gorouter-go-vs-push/
Tested:
1. Check if the issue does not happen on Safari anymore.
2. Check if no issue with Google Chrome and Mozilla Firefox.
Change-Id: I2ae35dad2dec6b19c3cb9d7f8d577b6077ac8d9c
Signed-off-by: Thang Q. Nguyen <thang@os.amperecomputing.com>
Signed-off-by: HuyLe <hule@amperecomputing.com>
|
|
This patchset will provide the option to configure the session timeout
for the WebUI. The functionality will provide the below timeout options
to configure.
1. 30 minutes
2. 1 hour
3. 2 hours
4. 4 hours
5. 8 hours
6. 1 Day
For the API, redfish is having the following resource.
URL - /redfish/v1/SessionService
Method
- GET (to get the configured timeout)
- PATCH (to configure the timeout value)
Property - { "SessionTimeout": 1800 }
When the user idles up until the configured session timeout, after that
any API call from this session will get 401 status and the web UI will
gets logged out.
Change-Id: Ic7c6b4817e560ca4ceb983dc5e2af51f3ae08cf5
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
This change removes the hardcoded chassis URL from FanStore. Now
the URL is taken from the odata.id.
Signed-off-by: MichalX Szopinski <michalx.szopinski@intel.com>
Change-Id: I59e4d46a8aaa453f6662f4f396f32d7fad18fb91
|
|
According to the Redfish specification, the address to update the
firmware is set in redfish/v1/UpdateService with the HttpPushUri
variable.
```
https://github.com/openbmc/bmcweb/commit/4dc23f3fb6c9a7cef84658f8ab3b703d29ec7d57
```
Change-Id: I29566a8ab2d06b658ab62f61c34be00fbbba0571
Signed-off-by: greenfil <mikl@greenfil.ru>
|
|
Now Health status will be "Ok" if there are no unsolved problems in the
log.
Before this patch, the flag "solved" was not considered.
Test:
Created a log entry with the status of "Critical" and "Warning".
Health became Critical.
Event Critical pressed Resolved. Health became "Warning".
Event Warning pressed Resolved. Health became "Ok".
Change-Id: Ic74a4c488c1c806c478c562a17fc0bb132e66e8f
Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru>
|
|
Saving power cap value was throwing an error, and it was caused by
incorrect endpoint to PowerControl resource in
Redfish: https://redfish.dmtf.org/schemas/v1/Power.v1_7_1.json
Fixed endpoint for saving Power Cap value
Signed-off-by: Damian Celico <damianx.celico@intel.com>
Change-Id: Ib9117f62548c55eb3f07562b71330675a2101924
|
|
Display API error messages on Local user managment tab.
Change-Id: I8ffe2359aa454503d07e8895907202bd0d8493f5
Signed-off-by: MichalX Szopinski <michalx.szopinski@intel.com>
|
|
On the session Web UI page, when we disconnect the current session,
instead of navigating to the login page, the browser populates the
authentication window for basic authorization.
If basic authentication is enabled, we are adding the www-authenticate
header to unauthorizing requests.
As per redfish, we have to set the "Accept" and "X-Requested-With"
header for the request from Web UI. This patch set will add those
headers.
Tested:
Logged in to the WebUI and navigated to the sessions page. Clicked
"Disconnect" to the current session and the WebUI is navigated to login.
page as expected.
Change-Id: I61cccbf41e854683e6cd5aa80fa72593ae4aa698
Signed-off-by: Ed Tanous <edtanous@google.com>
|
|
This commit allows us to add 'exclusiveToRoles' field to
route config files, with the list of roles that can access
this resource, if needed. In this case, only Administrator
can access Virtual-Media page and SOL console, and it is blocked for other
users.
Signed-off-by: Sivaprabu Ganesan <sivaprabug@ami.com>
Change-Id: Ibcee18bd92d97c34414ecaf2caf6af28070c5538
|
|
Redfish added support for the Context parameter on the session resource
This parameter has the same function that the "OemSession.ClientId"
field served. And BMC Web moves all the existing ClientId code to
produce Context. This patch set contains the code changes for adding a
new column "Context" in the sessions page and modifying the existing
column "Client ID" to "Session ID" and mapping the redfish property
"Id" to it.
The property "Context" is optional in redfish. If the Context holds any
value it will display in WebUI as it is. If it is not having any value,
"-" will be displayed in the WebUI.
Change-Id: Ibc99416fc37a91029bf430ccc7b387832eef729c
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
Utilize '#LogService.ClearLog' action to provide a possibility for the
user to clear POST code logs.
Change-Id: Iadd94b9ebc93bc81b13ee979962103587c939fc7
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
|
|
Description:
When KVM is opened in new window, after WEB UI is logged out,
opened KVM window is not getting closed. It remains opened and
accessible.
Root Cause:
There is not handle to close the KVM new window after the WEB UI
logged out.
Fix:
Added the KVM window opened information in store, and checked that
information to close the window.
Tested:
Step 1: Login to WEB UI
Step 2: Navigate to Operations -> KVM
Step 3: Open KVM in new window
Step 4: Click Logout in WEB UI
Result:
After successful log out, KVM new window is closed as expected.
Change-Id: Iab8e54d3088a08fb0ae9b581b2647fc0ab5460bd
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
- DHCP toggle for enablement was not present, It is now added in
the Networks page.
- DHCP when enabled, if there is no address, it picks up an address on its own.When it is disabled, we need to manually configure it.
Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com>
Change-Id: I32a9e0df28e6609945f3757a6bd69dc66a86f480
|
|
Bug description:
Before this commit there was an endless loading
on blue bar when user entering to the Overview.
Problem was missing `if` statement
after what that promise wasn't be able to finish.
Test:
Step1. Launch webui on browser and see Overview page.
Step2. Wait a while. Blue loading bar finished pulsing.
Change-Id: I2ea3b6f125ca24fcefeea8020c4a903ea018f4f7
Signed-off-by: Konstantin Maskov <sulwirld@gmail.com>
|
|
Description 1:
When WebUI creates the user with an already existing username
the error message will display the exact failure reason.
Tested:
Step 1: Login to webUI and navigate to user management page
Step 2: Create new user with username "testUser1"
Step 3: Create another user with same username "testUser1"
Step 4: WEB UI will through the error message
as "Username 'testuser1' already exists."
Description 2:
User can able to disable and change the root user via WebUI
Now restricted to disable the root user and changing the
root user privilege.
Tested:
Step 1: Login to Web UI with root user
Step 2: Navigate to User management page
Step 3: Try to modify the root user's details
Step 4: WebUI won't allow to disable the user,
username change and privilege change
Step 5: Login Web UI with non-root user
Step 6: Web UI won't allow to modify or delete the root
user's details
Change-Id: I0e38215b51fb058984664ec38ae9613e18043ed7
Signed-off-by: Sivaprabu Ganesan <sivaprabug@ami.com>
|
|
Description:
The sensor count in WebUI is mismatched when compared to
IPMI and REDFISH responses. When Web UI is iterating the
sensor response property, the iteration is stopped when
the key value is undefined. As a result, the sensor details
in the web UI are incorrect. So added the code changes to
check the property value in every iteration, whether the
value is present or not.
Tested:
Step 1: Login to WEB UI
Step 2: Navigate to Hardware Status and Sensors
Step 3: Check the sensor details with IPMI and redfish response
Step 4: All the sensors and those details in the IPMI and redfish
response are listing in Web UI
Change-Id: Icf5098b3dd2413851e755d9ede17a8501cbb7411
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
Removed the MemorySize field for DIMMs,
because it is missing in Redfish
```
https://www.dmtf.org/sites/default/files/standards/documents/DSP8010.zip
```
Change-Id: I12f37a601e429060765960f3c66b5249b84eabe7
Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru>
|
|
The reason for this problem is uniqBy always keep the first one when removing repetition
Resolves: https://github.com/openbmc/webui-vue/issues/60
Change-Id: Iec87d7845e694b0f2a14de4061ae113eac492fc0
Signed-off-by: wangqi02 <wangqi02@inspur.com>
|
|
In bmcweb/41d61c8 ("Convert IPv4-mapped IPv6 ClientIP back to IPv4"),
bmcweb automatically converts IPv4 addresses to IPv4 format, workaround
in webui-vue is no longer needed.
The original patch also brings issue with displaying IPv6 addresses in
Sessions tab.
This reverts commit d902aa7b4f98b49d2a20ad8253bc15afd77e9349.
Tested:
Both IPv4 and IPv6 addresses are displayed correctly in Sessions.
Change-Id: Ib56398de51526ee72168b5bf8427278bcb6f9c17
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>
|
|
Add missing "model" mapping on "Hardware status" tab in chassis
section.
Signed-off-by: MichalX Szopinski <michalx.szopinski@intel.com>
Change-Id: I9a6bd4a7e4fbaaac72aa8d59cc065ba0bea040bd
|
|
When a user selects a radio button and saves, the selected setting should be patched.
- Computed properties on generated bootstrap-vue radio buttons causes errors.
- Re-modeled radio buttons to take Redfish api data on component render.
- Mapped selected radio button value to patch the Redfish api property.
- Added translations.
Signed-off-by: Kenneth Fullbright <kennyneedsmilky@gmail.com>
Change-Id: I22ce75d9ef840d7f0c2659bba855093e5b4559f4
|
|
The IP address on sessions page is comming IPv6. It should be shown
IPv4 address.
Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com>
Change-Id: I4d5d492b161c09a09f616849ad9d0e6eb32e9fd8
|
|
This page will allow privileged user to clear encrypted keys.
- Only admin and CE login user will be able to see the page
- The UI will be different for both, admin and CE login user(service)
- This page is IBM only
Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com>
Change-Id: Ic6fe3454de815629a6b2250daa99ab21f2b316c3
|
|
Added RTAD under Network interfaces
Added VirtualTPM under Network services
Removed the sub-headings in Policies page
Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com>
Change-Id: I6290362cecdfe7f8cd7bfde20fcaca88b6bc2c09
|
|
TotalSystemMemoryGiB and CoreCount field is not present.
Added TotalSystemMemoryGiB under Memory summary
Added CoreCount under Processor summary
Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com>
Change-Id: I598abc7c05dd5113db0071ecd71bbcc32ad696c4
|
|
The story is integration of these two API responses
for their respective dumps:
1.Resource and Hostboot dumps:
redfish/v1/Systems/system/LogServices/Dump/Entries
2.BMC Dumps: /redfish/v1/Managers/bmc/LogServices/Dump/Entries
Signed-off-by: Sukanya Pandey <sukapan1@in.ibm.com>
Change-Id: I24ded733e682d21904e92e2e8be1951e46d33b09
|
|
DHCP property UseNTPServers is not working and its value is not getting reflected in backend.
It always remains enabled irrespective on enable or disable on GUI.
- Fixed the incorrect patch on the saveNtpState action.
Signed-off-by: Kenneth Fullbright <kennyneedsmilky@gmail.com>
Change-Id: Id0b7240e38f68bea8e98694bdcbe4e36e723bbcb
|
|
Identify LED should toggle on/off successfully
Rewrote the patch code to work with the Redfish schema
Set LocationIndicatorActive to true:
curl -k -H "X-Auth-Token: $token" -X PATCH -d '
{
"Assemblies":[
{"MemberId" : "0", "LocationIndicatorActive":true},
{"MemberId": "1", "LocationIndicatorActive":true}
]
}'
https://${bmc}/redfish/v1/Chassis/chassis/Assembly
MemberId is required to reference which assembly LED to toggle
Signed-off-by: Kenneth Fullbright <kennyneedsmilky@gmail.com>
Change-Id: Id0a3cf4dc533f6a0205be9fd037b13f92647cc00
|
|
Refactored getters and dispatch names were not matching
the getters and actions strings, which made dumps not work.
Made the getters and dispatch names match the vuex getters
and actions strings to the refactored codebase.
Signed-off-by: Kenneth Fullbright <kennyneedsmilky@gmail.com>
Change-Id: I414a7f85ef70c270785b825b3b14f9dfb27a33a7
|
|
- Added the following properties: Base module type, Bus width bits,
Capacity MiB, Data width bits, Enabled, Operating speed Mhz
- Design has been updated for Dimms table
Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com>
Change-Id: Ifd77071abd9544120c1904065275ccc00dd8d862
|
|
Simmilar modification to
https://gerrit.openbmc-project.xyz/c/openbmc/webui-vue/+/42988
which removes the hardcoded chassis name from url on Manage power usage
tab. With this modification we are displaying only informations about
first power device. This change also fixes the overwriting existing
power cap value on load.
Signed-off-by: MichalX Szopinski <michalx.szopinski@intel.com>
Change-Id: Ia164db9f2c50d98bc767c0f4729e9572a2d01da1
|
|
When the user enter the correct username/password and click the "Log in"
button, sometimes the page stays at the login page. The user will have
to reload the page, enter the username/password, and click the "Log in"
button again to actually login the WebUI.
From the browser's debug control, we could see it's waiting for the
response of
https://$bmc/redfish/v1/AccountService/Accounts/root
and it does not get any response.
From the BMC side, we could see the first login is successful.
Somehow if we remove the async keyword of function
checkPasswordChangeRequired(), the issue is not reproduced anymore.
So this is a POC patch to fix the issue, but the root cause is unknown.
Tested: Clear the browser's cookie, successful login multiple times.
Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I01e3ab5ca63baed18045915500fa8ca2e6b247ea
|
|
Adds modals to edit hostname and mac address per interface.
Signed-off-by: Dixsie Wolmers <dixsie@ibm.com>
Change-Id: I45d265c198afd1d9de9bb519a15a74e724f50f55
|
|
Adds ability to add or delete static ipv4 and dns
addesses per interface.
Signed-off-by: Dixsie Wolmers <dixsie@ibm.com>
Change-Id: Ie143ded2f173dd48f137471a684ba0d35ab0bf69
|
|
First commit of the network settings redesign:
- Adds the global network settings section for DHCP settings
- Adds read only hostname, FQDN and MAC address,
modal to edit each will be done seperately
- Removes interface specific sections to refactor in next commit
- Adds tab component to display ethernet data by interface
- Ability to edit, delete and add ipv4 addresses and DNS will
be done in separate commit
Signed-off-by: Dixsie Wolmers <dixsie@ibm.com>
Change-Id: Ibb1db6894ee697fec9e6ea1b8312d041c61faaad
|
|
Console errors were related to the power and network card components from
https://gerrit.openbmc-project.xyz/c/openbmc/webui-vue/+/46511
Signed-off-by: Dixsie Wolmers <dixsie@ibm.com>
Change-Id: Ib967229b74462ed8d5c28cbac24c2a2fbfc834c2
|
|
- Added the following properties: Model, Description, Spare part number,
Location Number, Memory type, Memory size, Identify led
- Design has been updated for Dimms table on inventory page
Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com>
Change-Id: Ife61396bd70c29df1b5ea55091adc8c6813b5cdc
|
|
Signed-off-by: Sneha Patel <Snehaben.Patel@ibm.com>
Change-Id: I1a4edae664d008a4f618d03d62e2319d8157ed6d
|
|
When Virtual Media image was configured and connected entry
did not appear on the UI after opening in the new tab or
after page refresh. The cause was filtering predicate.
Proxy devices has transferProtocolType eq to 'OEM',
legacy the onces that has no transferProtocolType. For
mouting from the share the property exists and has value of
'CIFS'. I added object with all protocols (see docs), and
change the filtering for legacy devices. New condition is
all accept 'OEM'.
Signed-off-by: Grzegorz Raguza <grzegorzx.raguza@intel.com>
Change-Id: I7ba123f19f924536f131ec40d15715b7f50fc985
|
|
Display location number on hardware inventory items
Signed-off-by: Sneha Patel <Snehaben.Patel@ibm.com>
Change-Id: Ib5555191f21ac4546d0b2e2af5b395aaa3a5357e
|
|
Currently webui-vue displays all sensor data with units written as
symbols ('A', 'W', 'C', 'RPM') except for voltage which is written as
'Volts'.
Use a 'V' symbol for voltage unit for unification.
Change-Id: I257b6d6bf1d099f62a861430a6448368b56dace1
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
|
|
- Model type and serial number are newly added system info data on
Appheader.
- On small screens and below system information(model type, serial number and
asset tag) will be hidden.
- On large screen and below model type and serial number will be visible but
asset tag will be hidden.
- For all other screens all the system info will be visible.
Signed-off-by: Sukanya Pandey <sukapan1@in.ibm.com>
Change-Id: Ia844a26f658083cbd5fa9c8f3f6bea8b65ddcd11
|
|
Bug: While toggling identify LED for cpu0, in return other identify LEDs are also getting toggled which belongs
to different CPUs.
Signed-off-by: Sukanya Pandey <sukapan1@in.ibm.com>
Change-Id: Ic48eba7b391a28f861e38f306233387819ad944c
|
