Age | Commit message (Collapse) | Author | Files | Lines |
|
Users of common WIMP GUIs (as opposed to interfaces primarily meant for
touch input) expect dialog boxes to have keyboard focus set on the
button for default action so that it can be executed by a single key
press. Usually that is chosen to proceed with the operation but in cases
where that leads to data loss the UI designers often pre-select Cancel
as a precaution.
This patch adds suitable property to all invocations of msgBoxConfirm()
method of `this.$bvModal` BootstrapVue object. For regular actions the
confirmation button is selected and can be activated by Enter or Space
bar. For actions deemed dangerous Cancel is focused instead so it takes
two key presses (first being Tab to shift the focus) to prooceed.
This also improves accessibility following the Web Content Accessibility
Guidelines (WCAG) published by W3C.
Tested: manually verified that modals are consistently shown with the
specified button focused, Enter and Space bar key presses produce the
same effect as left pointer button click: when Cancel is focused it just
closes the window, when OK is focused it sends the corresponding request
to the Redfish endpoint.
Change-Id: I66bfd02e48e08dc18994b11bbdd5d6b3ea27047f
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
|
|
When a processor is present:
Old behavior: Health = Ok (green color)
New behavior: Health = Ok (green color), State = Enabled (green color)
In the absence of a processor:
Old behavior: Health = Critical (error red color)
New behavior: Health = Ok (green color), State = Absent (warning yellow)
Tested manually on my system with 1 CPU present and 1 CPU missing
Change-Id: I33f8d94cbb5dcfd6a33b4b3ca379d2323362caca
Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru>
|
|
All changes should be whitespace, and were done using npm run-script
lint.
Change-Id: I943c6b435c5c872841af5affc1e89910468b5ca6
Signed-off-by: Ed Tanous <ed@tanous.net>
|
|
New versions of the vue linter flag that this class has no effect. It
isn't clear what the intent was, so remove it so the linter can pass.
Tested: Upgraded linter now passes.
Change-Id: Icccc4d57714be313c958023c74e9d8508afed4ce
Signed-off-by: Ed Tanous <ed@tanous.net>
|
|
Spanish was on the list, but the actual translation was missing
Change-Id: I36fd0542954f048fceea7c6ad7b1e0f207e70df8
Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru>
|
|
With a large number of FANs, a list of names is much easier to read than
a list of IDs. Now the Name is in the header of the row, and the ID only
when expanded.
Change-Id: Ic8a08e28db7f747f9765f45dbbda504bf827fb25
Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru>
|
|
Add state information in DIMM slot inventory summary so that users can
know if the DIMM slot has DIMM plugged or not.
Change-Id: Id9b7ebb2079762b354b418d060d4a1223273b50d
Signed-off-by: HuyLe <hule@amperecomputing.com>
|
|
- if isServerPowerOffRequired is true & !isServerOff is true
a warning will be shown that the server must be powered off
to switch images and update the firmware.
- When system power is on,
the switch to "running button" is disabled.
Signed-off-by: Kenneth Fullbright <kennyneedsmilky@gmail.com>
Change-Id: I65a24984c36f6ae39d715f4fa66e9884d031cb20
|
|
When the IPv4 address is in DHCP mode, hide the trashcan icon.
If the address is in static IPv4 mode, the trashcan icon will show
that the user can delete the IPv4 static address.
Change-Id: I27dc8dc64d93b1e2425de6143473a91f7bc0b104
Signed-off-by: Sivaprabu Ganesan <sivaprabug@ami.com>
|
|
This page will be included in Configuration section of the primary
navigation. The user will be able to delete and add alert destination.
Change-Id: I396d19a54ea11724f2c5aec67e20ba9abff947d3
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
|
|
- This patchset will try to connect to the WebSocket with the path 'console/default'.
- Until now, we were connecting to 'console0'.
Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com>
Change-Id: I6136e09458284b76f5b03f89be247db3e3ff82fd
|
|
Redfish deprecated the Processor/Memory Summary Status (state, health,
healthrollup) attributes. Please refer to redfish spec for more details:
https://redfish.dmtf.org/schemas/v1/ComputerSystem.v1_20_0.json
These attributes are already removed from the bmcweb code:
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/62731
So currently webui-vue tries to access not present attributes and fails,
and since these fields are not marked as optional, 'Server Overview'
card fails to display.
Drop processor and memory summary status attributes handling to correct
the issue.
Change-Id: I7fb956a0a310c6bd85560169b1ca0a64c19dc824
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
|
|
Bug description:
Before this commit KVM window wasn't being closed
after logging out
Test: Step1. Launch webui on browser and see KVM page on /#/operations/kvm.
Step2. Open additional window using 'Open in new tab'.
Step3. Navigate to another page. For example, /#/operations/key-clear.
Step4. Logout. Window is still open.
Change-Id: Ife79ebca41eb4d588c0b8f4fae06135420eda155
Signed-off-by: Konstantin Maskov <sulwirld@gmail.com>
|
|
There is a request to see three additional fields from Redfish in the
DIMM inventory table: https://github.com/openbmc/webui-vue/issues/107.
This change adds Manufacturer, Error correction, and Rank count data
from Redfish into the DIMM inventory table.
Tested:
Confirmed that the three fields show in the table with the correct data
from Redfish.
Change-Id: I6f1fc5103649abf8350e5b5c107c11eea3d1a599
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>
|
|
- OpenLDAP and Active Directory were hardcoded in the file, Hence, now, it is taken from the
translation file in this commit.
Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com>
Change-Id: Iebf557fbb20842878cce34c7f2969031af1765dd
|
|
This patchset will provide the option to configure the session timeout
for the WebUI. The functionality will provide the below timeout options
to configure.
1. 30 minutes
2. 1 hour
3. 2 hours
4. 4 hours
5. 8 hours
6. 1 Day
For the API, redfish is having the following resource.
URL - /redfish/v1/SessionService
Method
- GET (to get the configured timeout)
- PATCH (to configure the timeout value)
Property - { "SessionTimeout": 1800 }
When the user idles up until the configured session timeout, after that
any API call from this session will get 401 status and the web UI will
gets logged out.
Change-Id: Ic7c6b4817e560ca4ceb983dc5e2af51f3ae08cf5
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
Resolved and Unresolved status button in event log page is shown
or hidden based on the environment variable
VUE_APP_EVENT_LOGS_TOGGLE_BUTTON_DISABLED
Change-Id: If99a9705d4690995fb998daa979c21c61c3cc4a7
Signed-off-by: Sivaprabu Ganesan <sivaprabug@ami.com>
|
|
At the moment, the Overview page shows the total number of log errors
and warnings, even if they are marked as "resolved". After the patch,
only unresolved errors and warnings are counted.
Test:
Created an error event and a warning event in the log.
The Overview page displays 1 and 1.
Marked them as resolved.
The Overview page displays 0 and 0.
Change-Id: I8ee1122bbec3e678d33edfbd2035d02553fb64ea
Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru>
|
|
When the user changed their password in profile settings, to prevent
XSS attacks, I added the current password input field to authenticate
the user.
Once the authentication had success with the current password, then
allowing the update was possible. After the password is changed
successfully, all the sessions of the user who changed the password
will be disconnected, including the current session. and the current
session will navigate to the login page.
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
Change-Id: Idb8bc9d6ada420329c38407da76a08dc83fddd61
|
|
This patchset will fix the following issues in the user management page
1. "lockoutThreshold" and "lockoutDuration" values are not shown in the
account policy model when we navigate to any other page and come back
to the user management page account policy model.
Fix - The "lockoutThreshold" and "lockoutDuration" values are monitored
and updated in the model window by using the watch. When navigated from
another page, the watch is not updating the values, so the default
values are displayed. Initialized the value with an empty object, so
the watch will get triggered and update the fields with proper values.
2. The User Management Page title is not translated properly. The
router names are used to map each page's language objects. For the user
management page, the router name and the object value in the locale
file are different. Due to that, the title did not get translated
properly.
Fix - Changed the user management page title to match the locale file's
language object key value.
Change-Id: I1582c9d528633465c65f5d78e31d3dc740252cb0
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
This commit allows us to add 'exclusiveToRoles' field to
route config files, with the list of roles that can access
this resource, if needed. In this case, only Administrator
can access Virtual-Media page and SOL console, and it is blocked for other
users.
Signed-off-by: Sivaprabu Ganesan <sivaprabug@ami.com>
Change-Id: Ibcee18bd92d97c34414ecaf2caf6af28070c5538
|
|
Redfish added support for the Context parameter on the session resource
This parameter has the same function that the "OemSession.ClientId"
field served. And BMC Web moves all the existing ClientId code to
produce Context. This patch set contains the code changes for adding a
new column "Context" in the sessions page and modifying the existing
column "Client ID" to "Session ID" and mapping the redfish property
"Id" to it.
The property "Context" is optional in redfish. If the Context holds any
value it will display in WebUI as it is. If it is not having any value,
"-" will be displayed in the WebUI.
Change-Id: Ibc99416fc37a91029bf430ccc7b387832eef729c
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
If the user switches pages between the KVM and Virtual Media pages
after the session has expired, it won't redirect to the login page.
So I have added the system redfish API call in the create method to
check the session timeout status. If the session is expired, the API
call will get a 401 status, and WEBUI will be redirected to the
login page.
Change-Id: I069768ee0cef41afb4e6aa770bb8bec6565a16bd
Signed-off-by: Kirankumarb07 Ballapalli <kirankumarb@ami.com>
|
|
Problem : "handleSubmit" called on clicking Ok button implicitly as
well by the form
(<b-form id="generate-csr-form" novalidate @submit.prevent=
"handleSubmit"), due to this,
redfish API POST /redfish/v1/CertificateService/Actions/Certificate
Servi
ce.GenerateCSR
sent two times when "Generate CSR" button clicked,ideally redfish API
needs to be sent only once
This leads to failure of the second redfish API.
Steps to Reproduce Issue:
1. Go to 'Login->Security and access->Certificate->Generate CSR fill
the form
2. Click on 'Generate CSR.'
3. Scroll down to 'More Tools->Web Developer Tools->Network tab'
4. Two POST /redfish/v1/CertificateService/Actions/CertificateService.
GenerateCSR are sent
Solution: The issue can be fixed either by deleting the Ok button click
event listener or deleting
the (@submit.prevent="handleSubmit"). I have used later one, which is
small change as well does not
alter the code much
Tested : I did manual testing and observed that two POST requests
are no longer sent
Reference : https://softauthor.com/vuejs-prevent-form-submission/
Signed-off-by: Chandra Harkude <chandramohan.harkude@gmail.com>
Change-Id: I8736e597d2fe70aef438779667475426837d2c67
|
|
When the SOL console is opened in a new window, the status of the SOL
connection is displayed as "disconnected." And the error message is
displaying, "The system must be powered on to connect."
I have added this patch to get the systems API call to get the server
status when SOL is opened in a new window.
Change-Id: I971947fea0980605d400d46bb1e18b2d20164602
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
Utilize '#LogService.ClearLog' action to provide a possibility for the
user to clear POST code logs.
Change-Id: Iadd94b9ebc93bc81b13ee979962103587c939fc7
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
|
|
Description:
When KVM is opened in new window, after WEB UI is logged out,
opened KVM window is not getting closed. It remains opened and
accessible.
Root Cause:
There is not handle to close the KVM new window after the WEB UI
logged out.
Fix:
Added the KVM window opened information in store, and checked that
information to close the window.
Tested:
Step 1: Login to WEB UI
Step 2: Navigate to Operations -> KVM
Step 3: Open KVM in new window
Step 4: Click Logout in WEB UI
Result:
After successful log out, KVM new window is closed as expected.
Change-Id: Iab8e54d3088a08fb0ae9b581b2647fc0ab5460bd
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
- DHCP toggle for enablement was not present, It is now added in
the Networks page.
- DHCP when enabled, if there is no address, it picks up an address on its own.When it is disabled, we need to manually configure it.
Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com>
Change-Id: I32a9e0df28e6609945f3757a6bd69dc66a86f480
|
|
I use this patch to convert all values into the
format <Description>:<Value><Unit of Measure>.
I put the units of measure in a separate
localization area in order to use them in
the sensor page in the future.
Change-Id: Ic6554860c4185bc4d681a97205051799c6637b5c
Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru>
|
|
Showing error message if uploaded certificate is incorrect
Signed-off-by: Damian Celico <damianx.celico@intel.com>
Change-Id: Ifa034e663329e4841ff5c68f6171ce71739a6d13
|
|
On the sensor page and user management page, some of the strings are
not getting translated to the selected language.
I have added this patch to add the multiple language strings to the
missing strings.
Change-Id: I03ca43bb81708f85e913e39c6dfa24ab7f3de876
Signed-off-by: Kirankumar Ballapalli <kirankumarb@ami.com>
|
|
Bug description:
Before this commit there was an endless loading
on blue bar when user entering to the Overview.
Problem was missing `if` statement
after what that promise wasn't be able to finish.
Test:
Step1. Launch webui on browser and see Overview page.
Step2. Wait a while. Blue loading bar finished pulsing.
Change-Id: I2ea3b6f125ca24fcefeea8020c4a903ea018f4f7
Signed-off-by: Konstantin Maskov <sulwirld@gmail.com>
|
|
Description 1:
When WebUI creates the user with an already existing username
the error message will display the exact failure reason.
Tested:
Step 1: Login to webUI and navigate to user management page
Step 2: Create new user with username "testUser1"
Step 3: Create another user with same username "testUser1"
Step 4: WEB UI will through the error message
as "Username 'testuser1' already exists."
Description 2:
User can able to disable and change the root user via WebUI
Now restricted to disable the root user and changing the
root user privilege.
Tested:
Step 1: Login to Web UI with root user
Step 2: Navigate to User management page
Step 3: Try to modify the root user's details
Step 4: WebUI won't allow to disable the user,
username change and privilege change
Step 5: Login Web UI with non-root user
Step 6: Web UI won't allow to modify or delete the root
user's details
Change-Id: I0e38215b51fb058984664ec38ae9613e18043ed7
Signed-off-by: Sivaprabu Ganesan <sivaprabug@ami.com>
|
|
Description 1:
Downloading the CSR certificate data value without
encodeURIComponent function is not supported in Firefox
So added the encodeURIComponent function to download the
csr certificate
Tested:
Step 1: Launch WEBUI on firefox
Step 2: Navigate to Security and access, Certificates Page
Step 3: Generate and Download CSR certificate
(KeyPair Algorithm - EC and Key curve id - secp521r1)
Step 4: After CSR Downloaded, copy the downloaded
file to any of the linux machine
Step 5: Try to create an https/ldap certificate
via openssl on linux machine
Result:
Able to download the CSR certificate successfully
and able to create https/ldap certificate via openssl
Description 2:
While downloading the generated csr via Web UI,
the csr file is getting downloaded as ".txt" file
but it should download as ".csr" file
So changed the extension to ".csr"
Tested:
Step 1: Login to Web UI.
Step 2: Navigate to Security and access, Certificates Page
Step 3: Click Generate CSR Button and fill the required details
Step 4: Click Generate CSR from the popup modal.
Step 5: After CSR Generated an prompt will open
and it will show download and copy option. In that select download,
the csr certificate will download with ".csr" extension
Change-Id: Ice176006a95afd53845d7696ce0eac88f02b1096
Signed-off-by: Sivaprabu Ganesan <sivaprabug@ami.com>
|
|
Only when the host is turned off should the status be "Disconnected".
For other host states, the SOL status should be Connected.
Test: enabled my host in DiagnosticMode. Now SOL status is "Connected",
before the patch it was "Disconnected
Signed-off-by: glukhov.mikhail <mikl@greenfil.ru>
Change-Id: I000b181f71d7ee5bd243a3c6a6d03ea7a9ea0ef7
|
|
Removed the MemorySize field for DIMMs,
because it is missing in Redfish
```
https://www.dmtf.org/sites/default/files/standards/documents/DSP8010.zip
```
Change-Id: I12f37a601e429060765960f3c66b5249b84eabe7
Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru>
|
|
If identify LED for the DIMM module is not present, don't display
control element for it.
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Change-Id: I30f7e3ad9333874bbeb2050c421baf509bb833fc
|
|
Before the patch, the diagnostic mode was displayed as "Not available",
after the patch "Diagnostic mode".
Test: in the console run the command
"busctl set-property xyz.openbmc_project.State.Host \
/xyz/openbmc_project/state/host0 \
xyz.openbmc_project.State.Host CurrentHostState \
s "xyz.openbmc_project.State.Host.HostState.DiagnosticMode".
open the "Server power operations" page,
check the Server status
Signed-off-by: glukhov.mikhail <mikl@greenfil.ru>
Change-Id: I90d04e05188eb92c4c4b38fe578ae36db0424b5c
|
|
Delete button in event logs page is shown
or hidden based on the enviroment variable
VUE_APP_EVENT_LOGS_DELETE_BUTTON_ENABLED
Signed-off-by: Damian Celico <damianx.celico@intel.com>
Change-Id: I10a46f5ef147865f954e6f94bcefec5c280ad3ea
|
|
Add "Server manufacturer" and "Firmware version" to "Server
information" card in Overview tab.
Signed-off-by: MichalX Szopinski <michalx.szopinski@intel.com>
Change-Id: If02516b1b721920f83c5fe42a7c5e79fbb1825ca
|
|
Checking the file extension type of uploaded certificates to redfish.
Sends the file only if the file type is correct, otherwise shows error.
Signed-off-by: Damian Celico <damianx.celico@intel.com>
Change-Id: Idfc790bc8967333aed66c5c128334af4231dbea3
|
|
When the sol page is opened, a socket is opened;
when the sol page is closed, the socket is not closed
(console print is also exception).
It only closes when you log out.
Fix this condition to 'close socket when SOL page is exited'.
test:
Enter the SOL page-->console print'websocket console0/ opened'
-->close the SOL page
-->console print'websocket console0/ closed. code: 1000 reason: '
Signed-off-by: Xiaochao Ma <maxiaochao@inspur.com>
Change-Id: I0f406c2085aec303d6e5139d57b31ed6f244a155
|
|
There shouldn't be an alert message in the update firmware component.
- Took away the alert from the Update firmware component.
Signed-off-by: Kenneth Fullbright <kennyneedsmilky@gmail.com>
Change-Id: I1ab97fbba39fb2d7639707cceaf75b71531fa971
|
|
Unable to delete all dumps and displaying incorrect event log delete message
Able to delete all the Dumps
Approriate message is displayed in toast after deleting Event logs
Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com>
Change-Id: I1169bcd8e6308d50baf5c7ddcab5c511edcbc875
|
|
- if the status of the SOL console is disconnected, an
alert message will be displays that System must be
powered on to connect
Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com>
Change-Id: I4cdf99954f3a4e129404facf2992dadf63e62f70
|
|
When a user selects a radio button and saves, the selected setting should be patched.
- Computed properties on generated bootstrap-vue radio buttons causes errors.
- Re-modeled radio buttons to take Redfish api data on component render.
- Mapped selected radio button value to patch the Redfish api property.
- Added translations.
Signed-off-by: Kenneth Fullbright <kennyneedsmilky@gmail.com>
Change-Id: I22ce75d9ef840d7f0c2659bba855093e5b4559f4
|
|
- Add busy prop to tables
Signed-off-by: Kenneth Fullbright <kennyneedsmilky@gmail.com>
Change-Id: I4416f12967c9a0ad6c8bb782c7d8de5c17fdd195
|
|
This page will allow privileged user to clear encrypted keys.
- Only admin and CE login user will be able to see the page
- The UI will be different for both, admin and CE login user(service)
- This page is IBM only
Signed-off-by: Sandeepa Singh <sandeepa.singh@ibm.com>
Change-Id: Ic6fe3454de815629a6b2250daa99ab21f2b316c3
|
|
Added RTAD under Network interfaces
Added VirtualTPM under Network services
Removed the sub-headings in Policies page
Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com>
Change-Id: I6290362cecdfe7f8cd7bfde20fcaca88b6bc2c09
|
|
TotalSystemMemoryGiB and CoreCount field is not present.
Added TotalSystemMemoryGiB under Memory summary
Added CoreCount under Processor summary
Signed-off-by: Nikhil Ashoka <a.nikhil@ibm.com>
Change-Id: I598abc7c05dd5113db0071ecd71bbcc32ad696c4
|