From 515f46565a93f71ecd8b683198797b1690d3b5f8 Mon Sep 17 00:00:00 2001 From: Ed Tanous Date: Fri, 5 Apr 2024 14:44:20 -0700 Subject: Remove /subscribe websocket handler Having this code is causing crashes for implementations that don't have dbus-rest enabled in bmcweb, which is deprecated. This commit is intended to start a discussion around this issue, and propose simply removing it. 33a8c5369e0253a93dba2e70647bda1c7697b73b (checked in July 2020) points this crash out, and adds a way to disable the feature. While we could just make VUE_APP_SUBSCRIBE_SOCKET_DISABLED the default, this seems ill advised, given the dbus-rest options deprecated status. Change-Id: I6244f5e2ce895199d5d47cfca9eef36584e8f524 Signed-off-by: Ed Tanous --- .env.intel | 1 - 1 file changed, 1 deletion(-) (limited to '.env.intel') diff --git a/.env.intel b/.env.intel index 382e7fb6..79d07f05 100644 --- a/.env.intel +++ b/.env.intel @@ -2,7 +2,6 @@ NODE_ENV=production VUE_APP_ENV_NAME="intel" VUE_APP_COMPANY_NAME="intel" VUE_APP_GUI_NAME="BMC System Management" -VUE_APP_SUBSCRIBE_SOCKET_DISABLED="true" VUE_APP_SWITCH_TO_BACKUP_IMAGE_DISABLED="true" VUE_APP_MODIFY_SSH_POLICY_DISABLED="true" VUE_APP_VIRTUAL_MEDIA_LIST_ENABLED="true" -- cgit v1.2.3