From 25e17a119f023a472b90bf645f4211c66718b446 Mon Sep 17 00:00:00 2001
From: Dixsie Wolmers <dixsie@ibm.com>
Date: Fri, 25 Jun 2021 08:15:05 -0500
Subject: Remove <br /> from hardware status tables

Break tags are not semantic for definition lists.

Signed-off-by: Dixsie Wolmers <dixsie@ibm.com>
Change-Id: I1ecbd7100044da4aa7749888faab962e115e2564
---
 src/assets/styles/bmc/custom/_tables.scss          |  5 +++--
 .../HardwareStatusTableBmcManager.vue              | 24 ++++++----------------
 .../HardwareStatus/HardwareStatusTableChassis.vue  |  3 ---
 .../HardwareStatusTablePowerSupplies.vue           |  4 ----
 .../HardwareStatusTableProcessors.vue              |  6 ------
 .../HardwareStatus/HardwareStatusTableStystem.vue  |  6 ------
 6 files changed, 9 insertions(+), 39 deletions(-)

diff --git a/src/assets/styles/bmc/custom/_tables.scss b/src/assets/styles/bmc/custom/_tables.scss
index 349bfad4..6efe2ba0 100644
--- a/src/assets/styles/bmc/custom/_tables.scss
+++ b/src/assets/styles/bmc/custom/_tables.scss
@@ -64,11 +64,12 @@
       margin: 0;
     }
     dt {
-      display: inline-block;
+      float: left;
+      clear: left;
       margin-right: $spacer / 2;
     }
     dd {
-      display: inline-block;
+      line-height: 1.2
     }
   }
 
diff --git a/src/views/Health/HardwareStatus/HardwareStatusTableBmcManager.vue b/src/views/Health/HardwareStatus/HardwareStatusTableBmcManager.vue
index 2fdcb2ed..2feced86 100644
--- a/src/views/Health/HardwareStatus/HardwareStatusTableBmcManager.vue
+++ b/src/views/Health/HardwareStatus/HardwareStatusTableBmcManager.vue
@@ -34,31 +34,28 @@
             <b-col sm="6">
               <dl>
                 <!-- Description -->
-                <dt class="d-block">
+                <dt class="float-none">
                   {{ $t('pageHardwareStatus.table.description') }}:
                 </dt>
                 <dd class="mb-4">
                   {{ tableFormatter(item.description) }}
                 </dd>
-                <br />
                 <!-- Firmware version -->
-                <dt class="d-block">
+                <dt class="float-none">
                   {{ $t('pageHardwareStatus.table.firmwareVersion') }}:
                 </dt>
                 <dd class="mb-4">
                   {{ tableFormatter(item.firmwareVersion) }}
                 </dd>
-                <br />
                 <!-- Service entry point UUID -->
-                <dt class="d-block">
+                <dt class="float-none">
                   {{ $t('pageHardwareStatus.table.serviceEntryPointUuid') }}:
                 </dt>
                 <dd class="mb-4">
                   {{ tableFormatter(item.serviceEntryPointUuid) }}
                 </dd>
-                <br />
                 <!-- UUID -->
-                <dt class="d-block">
+                <dt class="float-none">
                   {{ $t('pageHardwareStatus.table.uuid') }}:
                 </dt>
                 <dd class="mb-4">
@@ -71,27 +68,23 @@
                 <!-- Power state -->
                 <dt>{{ $t('pageHardwareStatus.table.powerState') }}:</dt>
                 <dd>{{ tableFormatter(item.powerState) }}</dd>
-                <br />
 
                 <!-- Model -->
                 <dt>{{ $t('pageHardwareStatus.table.model') }}:</dt>
                 <dd>{{ tableFormatter(item.model) }}</dd>
-                <br />
 
                 <!-- Health rollup -->
                 <dt>
                   {{ $t('pageHardwareStatus.table.statusHealthRollup') }}:
                 </dt>
                 <dd>{{ tableFormatter(item.healthRollup) }}</dd>
-                <br />
 
                 <!-- Status state -->
                 <dt>{{ $t('pageHardwareStatus.table.statusState') }}:</dt>
                 <dd>{{ tableFormatter(item.statusState) }}</dd>
-                <br />
 
                 <!-- Graphical console -->
-                <dt class="font-weight-bold mt-3 mb-2 d-block">
+                <dt class="font-weight-bold mt-3 mb-2 float-none">
                   {{ $t('pageHardwareStatus.table.graphicalConsole') }}
                 </dt>
                 <dt>
@@ -100,18 +93,15 @@
                 <dd>
                   {{ tableFormatterArray(item.graphicalConsoleConnectTypes) }}
                 </dd>
-                <br />
                 <dt>
                   {{ $t('pageHardwareStatus.table.maxConcurrentSessions') }}:
                 </dt>
                 <dd>{{ tableFormatter(item.graphicalConsoleMaxSessions) }}</dd>
-                <br />
                 <dt>{{ $t('pageHardwareStatus.table.serviceEnabled') }}:</dt>
                 <dd>{{ tableFormatter(item.graphicalConsoleEnabled) }}</dd>
-                <br />
 
                 <!-- Serial console -->
-                <dt class="font-weight-bold mt-3 mb-2 d-block">
+                <dt class="font-weight-bold mt-3 mb-2 float-none">
                   {{ $t('pageHardwareStatus.table.serialConsole') }}
                 </dt>
                 <dt>
@@ -120,12 +110,10 @@
                 <dd>
                   {{ tableFormatterArray(item.serialConsoleConnectTypes) }}
                 </dd>
-                <br />
                 <dt>
                   {{ $t('pageHardwareStatus.table.maxConcurrentSessions') }}:
                 </dt>
                 <dd>{{ tableFormatter(item.serialConsoleMaxSessions) }}</dd>
-                <br />
                 <dt>{{ $t('pageHardwareStatus.table.serviceEnabled') }}:</dt>
                 <dd>{{ tableFormatter(item.serialConsoleEnabled) }}</dd>
               </dl>
diff --git a/src/views/Health/HardwareStatus/HardwareStatusTableChassis.vue b/src/views/Health/HardwareStatus/HardwareStatusTableChassis.vue
index 2bf11f62..c7e409a4 100644
--- a/src/views/Health/HardwareStatus/HardwareStatusTableChassis.vue
+++ b/src/views/Health/HardwareStatus/HardwareStatusTableChassis.vue
@@ -36,11 +36,9 @@
                 <!-- Chassis type -->
                 <dt>{{ $t('pageHardwareStatus.table.chassisType') }}:</dt>
                 <dd>{{ tableFormatter(item.chassisType) }}</dd>
-                <br />
                 <!-- Manufacturer -->
                 <dt>{{ $t('pageHardwareStatus.table.manufacturer') }}:</dt>
                 <dd>{{ tableFormatter(item.manufacturer) }}</dd>
-                <br />
                 <!-- Power state -->
                 <dt>{{ $t('pageHardwareStatus.table.powerState') }}:</dt>
                 <dd>{{ tableFormatter(item.powerState) }}</dd>
@@ -53,7 +51,6 @@
                   {{ $t('pageHardwareStatus.table.statusHealthRollup') }}:
                 </dt>
                 <dd>{{ tableFormatter(item.healthRollup) }}</dd>
-                <br />
                 <!-- Status state -->
                 <dt>{{ $t('pageHardwareStatus.table.statusState') }}:</dt>
                 <dd>{{ tableFormatter(item.statusState) }}</dd>
diff --git a/src/views/Health/HardwareStatus/HardwareStatusTablePowerSupplies.vue b/src/views/Health/HardwareStatus/HardwareStatusTablePowerSupplies.vue
index ba1537b7..d313197d 100644
--- a/src/views/Health/HardwareStatus/HardwareStatusTablePowerSupplies.vue
+++ b/src/views/Health/HardwareStatus/HardwareStatusTablePowerSupplies.vue
@@ -58,11 +58,9 @@
                 <!-- Efficiency percent -->
                 <dt>{{ $t('pageHardwareStatus.table.efficiencyPercent') }}:</dt>
                 <dd>{{ tableFormatter(item.efficiencyPercent) }}</dd>
-                <br />
                 <!-- Firmware version -->
                 <dt>{{ $t('pageHardwareStatus.table.firmwareVersion') }}:</dt>
                 <dd>{{ tableFormatter(item.firmwareVersion) }}</dd>
-                <br />
                 <!-- Indicator LED -->
                 <dt>{{ $t('pageHardwareStatus.table.indicatorLed') }}:</dt>
                 <dd>{{ tableFormatter(item.indicatorLed) }}</dd>
@@ -73,11 +71,9 @@
                 <!-- Model -->
                 <dt>{{ $t('pageHardwareStatus.table.model') }}:</dt>
                 <dd>{{ tableFormatter(item.model) }}</dd>
-                <br />
                 <!-- Power input watts -->
                 <dt>{{ $t('pageHardwareStatus.table.powerInputWatts') }}:</dt>
                 <dd>{{ tableFormatter(item.powerInputWatts) }}</dd>
-                <br />
                 <!-- Status state -->
                 <dt>{{ $t('pageHardwareStatus.table.statusState') }}:</dt>
                 <dd>{{ tableFormatter(item.statusState) }}</dd>
diff --git a/src/views/Health/HardwareStatus/HardwareStatusTableProcessors.vue b/src/views/Health/HardwareStatus/HardwareStatusTableProcessors.vue
index 2f956a9f..27f3bd83 100644
--- a/src/views/Health/HardwareStatus/HardwareStatusTableProcessors.vue
+++ b/src/views/Health/HardwareStatus/HardwareStatusTableProcessors.vue
@@ -55,15 +55,12 @@
                 <!-- Name -->
                 <dt>{{ $t('pageHardwareStatus.table.name') }}:</dt>
                 <dd>{{ tableFormatter(item.name) }}</dd>
-                <br />
                 <!-- Model -->
                 <dt>{{ $t('pageHardwareStatus.table.model') }}:</dt>
                 <dd>{{ tableFormatter(item.model) }}</dd>
-                <br />
                 <!-- Instruction set -->
                 <dt>{{ $t('pageHardwareStatus.table.instructionSet') }}:</dt>
                 <dd>{{ tableFormatter(item.instructionSet) }}</dd>
-                <br />
                 <!-- Manufacturer -->
                 <dt>{{ $t('pageHardwareStatus.table.manufacturer') }}:</dt>
                 <dd>{{ tableFormatter(item.manufacturer) }}</dd>
@@ -76,15 +73,12 @@
                   {{ $t('pageHardwareStatus.table.processorArchitecture') }}:
                 </dt>
                 <dd>{{ tableFormatter(item.processorArchitecture) }}</dd>
-                <br />
                 <!-- Type -->
                 <dt>{{ $t('pageHardwareStatus.table.processorType') }}:</dt>
                 <dd>{{ tableFormatter(item.processorType) }}</dd>
-                <br />
                 <!-- Total cores -->
                 <dt>{{ $t('pageHardwareStatus.table.totalCores') }}:</dt>
                 <dd>{{ tableFormatter(item.totalCores) }}</dd>
-                <br />
                 <!-- Status state -->
                 <dt>{{ $t('pageHardwareStatus.table.statusState') }}:</dt>
                 <dd>{{ tableFormatter(item.statusState) }}</dd>
diff --git a/src/views/Health/HardwareStatus/HardwareStatusTableStystem.vue b/src/views/Health/HardwareStatus/HardwareStatusTableStystem.vue
index fa083a01..9f2e7852 100644
--- a/src/views/Health/HardwareStatus/HardwareStatusTableStystem.vue
+++ b/src/views/Health/HardwareStatus/HardwareStatusTableStystem.vue
@@ -36,11 +36,9 @@
                 <!-- Asset tag -->
                 <dt>{{ $t('pageHardwareStatus.table.assetTag') }}:</dt>
                 <dd>{{ tableFormatter(item.assetTag) }}</dd>
-                <br />
                 <!-- Description -->
                 <dt>{{ $t('pageHardwareStatus.table.description') }}:</dt>
                 <dd>{{ tableFormatter(item.description) }}</dd>
-                <br />
                 <!-- Indicator LED -->
                 <dt>{{ $t('pageHardwareStatus.table.indicatorLed') }}:</dt>
                 <dd v-if="item.locationIndicatorActive === true">
@@ -50,7 +48,6 @@
                   {{ $t('global.status.off') }}
                 </dd>
                 <dd v-else>--</dd>
-                <br />
                 <!-- Model -->
                 <dt>{{ $t('pageHardwareStatus.table.model') }}:</dt>
                 <dd>{{ tableFormatter(item.model) }}</dd>
@@ -61,17 +58,14 @@
                 <!-- Power state -->
                 <dt>{{ $t('pageHardwareStatus.table.powerState') }}:</dt>
                 <dd>{{ tableFormatter(item.powerState) }}</dd>
-                <br />
                 <!-- Health rollup -->
                 <dt>
                   {{ $t('pageHardwareStatus.table.statusHealthRollup') }}:
                 </dt>
                 <dd>{{ tableFormatter(item.healthRollup) }}</dd>
-                <br />
                 <!-- Status state -->
                 <dt>{{ $t('pageHardwareStatus.table.statusState') }}:</dt>
                 <dd>{{ tableFormatter(item.statusState) }}</dd>
-                <br />
                 <!-- System type -->
                 <dt>{{ $t('pageHardwareStatus.table.systemType') }}:</dt>
                 <dd>{{ tableFormatter(item.systemType) }}</dd>
-- 
cgit v1.2.3