From 932aff93a96fff5fb2d1e1dc264f944cc78b3f83 Mon Sep 17 00:00:00 2001 From: Derick Montague Date: Thu, 26 Aug 2021 14:06:49 -0500 Subject: Update login page layout This update will: - Change the positioning of the form to be on the left - Add the built on OpenBMC logo to the bottom right corner of the screen - Add the ability to include a GUI custom name using a .env variable. If the variable is not present, the login page will not include the

section heading element. - Remove the word "logo" from the alt attribute for the company logo image used in the application header and on the login page. Github story: https://github.com/openbmc/webui-vue/issues/63 Signed-off-by: Derick Montague Change-Id: I83ac5aecff0b3858c3ab5f38ab1aaa603d59acf1 --- .env.ibm | 1 + src/assets/images/built-on-openbmc-logo.svg | 13 +++ src/assets/images/login-company-logo.svg | 1 + src/assets/images/logo-login.svg | 1 - src/components/AppHeader/AppHeader.vue | 2 +- src/layouts/LoginLayout.vue | 108 +++++++++++++++----- src/views/ChangePassword/ChangePassword.vue | 130 ++++++++++++------------ src/views/Login/Login.vue | 41 ++++---- tests/unit/__snapshots__/AppHeader.spec.js.snap | 2 +- 9 files changed, 182 insertions(+), 117 deletions(-) create mode 100644 src/assets/images/built-on-openbmc-logo.svg create mode 100644 src/assets/images/login-company-logo.svg delete mode 100644 src/assets/images/logo-login.svg diff --git a/.env.ibm b/.env.ibm index 34204623..97c2afa2 100644 --- a/.env.ibm +++ b/.env.ibm @@ -1,6 +1,7 @@ NODE_ENV=production VUE_APP_ENV_NAME=ibm VUE_APP_COMPANY_NAME="IBM" +VUE_APP_GUI_NAME="BMC System Management" CUSTOM_STYLES=true CUSTOM_APP_NAV=true CUSTOM_ROUTER=true diff --git a/src/assets/images/built-on-openbmc-logo.svg b/src/assets/images/built-on-openbmc-logo.svg new file mode 100644 index 00000000..53e7fdc5 --- /dev/null +++ b/src/assets/images/built-on-openbmc-logo.svg @@ -0,0 +1,13 @@ + + + + + + + + + + + + + diff --git a/src/assets/images/login-company-logo.svg b/src/assets/images/login-company-logo.svg new file mode 100644 index 00000000..d0fa158c --- /dev/null +++ b/src/assets/images/login-company-logo.svg @@ -0,0 +1 @@ +Asset 1 \ No newline at end of file diff --git a/src/assets/images/logo-login.svg b/src/assets/images/logo-login.svg deleted file mode 100644 index d0fa158c..00000000 --- a/src/assets/images/logo-login.svg +++ /dev/null @@ -1 +0,0 @@ -Asset 1 \ No newline at end of file diff --git a/src/components/AppHeader/AppHeader.vue b/src/components/AppHeader/AppHeader.vue index 4e806fb9..7211a598 100644 --- a/src/components/AppHeader/AppHeader.vue +++ b/src/components/AppHeader/AppHeader.vue @@ -130,7 +130,7 @@ export default { data() { return { isNavigationOpen: false, - altLogo: `${process.env.VUE_APP_COMPANY_NAME} logo`, + altLogo: process.env.VUE_APP_COMPANY_NAME || 'Built on OpenBMC', }; }, computed: { diff --git a/src/layouts/LoginLayout.vue b/src/layouts/LoginLayout.vue index c2b9af57..cdff2040 100644 --- a/src/layouts/LoginLayout.vue +++ b/src/layouts/LoginLayout.vue @@ -1,23 +1,34 @@ @@ -26,7 +37,8 @@ export default { name: 'LoginLayout', data() { return { - altLogo: `${process.env.VUE_APP_COMPANY_NAME} logo`, + altLogo: process.env.VUE_APP_COMPANY_NAME || 'OpenBMC', + customizableGuiName: process.env.VUE_APP_GUI_NAME || '', }; }, }; @@ -34,25 +46,67 @@ export default { diff --git a/src/views/ChangePassword/ChangePassword.vue b/src/views/ChangePassword/ChangePassword.vue index e4319303..2440ace1 100644 --- a/src/views/ChangePassword/ChangePassword.vue +++ b/src/views/ChangePassword/ChangePassword.vue @@ -1,71 +1,73 @@ @@ -124,7 +126,9 @@ export default { diff --git a/src/views/Login/Login.vue b/src/views/Login/Login.vue index fc679361..8d96573a 100644 --- a/src/views/Login/Login.vue +++ b/src/views/Login/Login.vue @@ -1,9 +1,5 @@