From 602e98aa32f82fd3b0c3d250c7cc1f8da971db24 Mon Sep 17 00:00:00 2001 From: Derick Montague Date: Wed, 21 Oct 2020 16:20:00 -0500 Subject: Update linting packages to use latest - 99% of changes were small syntax changes that were changed by the lint command. There were a couple of small manual changes to meet the property order patterns established as part of the vue:recommended guidelines. There are rules that were set from errors to warnings and new stories are being opened to address those issues. Testing: - Successfully ran npm run serve - Successfully ran npm run lint - Verified functionality works as expected, e.g. success and failure use cases - Resolved any JavaScript errors thrown to the console Signed-off-by: Derick Montague Change-Id: Ie082f31c73ccbe8a60afa8f88a9ef6dbf33d9fd2 --- src/views/Overview/Overview.vue | 27 ++++++++++++--------------- src/views/Overview/OverviewEvents.vue | 22 +++++++++++----------- src/views/Overview/OverviewNetwork.vue | 4 ++-- src/views/Overview/OverviewQuickLinks.vue | 14 +++++++------- 4 files changed, 32 insertions(+), 35 deletions(-) (limited to 'src/views/Overview') diff --git a/src/views/Overview/Overview.vue b/src/views/Overview/Overview.vue index 27a599b9..13138601 100644 --- a/src/views/Overview/Overview.vue +++ b/src/views/Overview/Overview.vue @@ -101,21 +101,22 @@ export default { OverviewEvents, OverviewNetwork, PageTitle, - PageSection + PageSection, }, mixins: [LoadingBarMixin], data() { return { firmwareStoreModuleName: this.$store.hasModule('firmwareSingleImage') ? 'firmwareSingleImage' - : 'firmware' + : 'firmware', }; }, computed: { ...mapState({ - server: state => state.system.systems[0], - powerCapValue: state => state.powerControl.powerCapValue, - powerConsumptionValue: state => state.powerControl.powerConsumptionValue, + server: (state) => state.system.systems[0], + powerCapValue: (state) => state.powerControl.powerCapValue, + powerConsumptionValue: (state) => + state.powerControl.powerConsumptionValue, serverManufacturer() { if (this.server) return this.server.manufacturer || '--'; return '--'; @@ -131,23 +132,23 @@ export default { hostFirmwareVersion() { if (this.server) return this.server.firmwareVersion || '--'; return '--'; - } + }, }), bmcFirmwareVersion() { return this.$store.getters[ `${this.firmwareStoreModuleName}/bmcFirmwareCurrentVersion` ]; - } + }, }, created() { this.startLoader(); - const quicklinksPromise = new Promise(resolve => { + const quicklinksPromise = new Promise((resolve) => { this.$root.$on('overview::quicklinks::complete', () => resolve()); }); - const networkPromise = new Promise(resolve => { + const networkPromise = new Promise((resolve) => { this.$root.$on('overview::network::complete', () => resolve()); }); - const eventsPromise = new Promise(resolve => { + const eventsPromise = new Promise((resolve) => { this.$root.$on('overview::events::complete', () => resolve()); }); Promise.all([ @@ -158,13 +159,9 @@ export default { this.$store.dispatch('powerControl/getPowerControl'), quicklinksPromise, networkPromise, - eventsPromise + eventsPromise, ]).finally(() => this.endLoader()); }, - beforeRouteLeave(to, from, next) { - this.hideLoader(); - next(); - } }; diff --git a/src/views/Overview/OverviewEvents.vue b/src/views/Overview/OverviewEvents.vue index ac39a2b3..83aa677d 100644 --- a/src/views/Overview/OverviewEvents.vue +++ b/src/views/Overview/OverviewEvents.vue @@ -20,11 +20,11 @@ :fields="fields" :empty-text="$t('pageOverview.events.noHighEventsMsg')" > -