summaryrefslogtreecommitdiff
path: root/.cocciconfig
diff options
context:
space:
mode:
authorDamien Le Moal <damien.lemoal@wdc.com>2020-12-09 14:16:10 +0300
committerDamien Le Moal <damien.lemoal@wdc.com>2020-12-10 09:14:19 +0300
commit6bea0225a4bf14a58af71cb9677a756921469e46 (patch)
treedd1abc26e443eb6209bce93c4a57aeb229eb7dd4 /.cocciconfig
parent0477e92881850d44910a7e94fc2c46f96faa131f (diff)
downloadlinux-6bea0225a4bf14a58af71cb9677a756921469e46.tar.xz
zonefs: fix page reference and BIO leak
In zonefs_file_dio_append(), the pages obtained using bio_iov_iter_get_pages() are not released on completion of the REQ_OP_APPEND BIO, nor when bio_iov_iter_get_pages() fails. Furthermore, a call to bio_put() is missing when bio_iov_iter_get_pages() fails. Fix these resource leaks by adding BIO resource release code (bio_put()i and bio_release_pages()) at the end of the function after the BIO execution and add a jump to this resource cleanup code in case of bio_iov_iter_get_pages() failure. While at it, also fix the call to task_io_account_write() to be passed the correct BIO size instead of bio_iov_iter_get_pages() return value. Reported-by: Christoph Hellwig <hch@lst.de> Fixes: 02ef12a663c7 ("zonefs: use REQ_OP_ZONE_APPEND for sync DIO") Cc: stable@vger.kernel.org Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com> Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> Reviewed-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to '.cocciconfig')
0 files changed, 0 insertions, 0 deletions