diff options
| author | Theodore Ts'o <tytso@mit.edu> | 2012-12-27 10:42:48 +0400 |
|---|---|---|
| committer | Paul Gortmaker <paul.gortmaker@windriver.com> | 2014-02-11 01:11:29 +0400 |
| commit | 0fd8d8773fd8c2a136efbc0f0e705e51ee181be9 (patch) | |
| tree | d98b0645a6aa5d37609b5465208b5ed52d9dd462 | |
| parent | 34de201cb95e93565d55a5bb5e12997133eeffd5 (diff) | |
| download | linux-0fd8d8773fd8c2a136efbc0f0e705e51ee181be9.tar.xz | |
ext4: lock i_mutex when truncating orphan inodes
commit 721e3eba21e43532e438652dd8f1fcdfce3187e7 upstream.
Commit c278531d39 added a warning when ext4_flush_unwritten_io() is
called without i_mutex being taken. It had previously not been taken
during orphan cleanup since races weren't possible at that point in
the mount process, but as a result of this c278531d39, we will now see
a kernel WARN_ON in this case. Take the i_mutex in
ext4_orphan_cleanup() to suppress this warning.
Reported-by: Alexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Reviewed-by: Zheng Liu <wenqing.lz@taobao.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
| -rw-r--r-- | fs/ext4/super.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 6928d5ad2c0d..90906948e242 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -2028,7 +2028,9 @@ static void ext4_orphan_cleanup(struct super_block *sb, __func__, inode->i_ino, inode->i_size); jbd_debug(2, "truncating inode %lu to %lld bytes\n", inode->i_ino, inode->i_size); + mutex_lock(&inode->i_mutex); ext4_truncate(inode); + mutex_unlock(&inode->i_mutex); nr_truncates++; } else { ext4_msg(sb, KERN_DEBUG, |