summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBernhard Bender <bernhard.bender@bytecmed.com>2015-07-23 23:58:08 +0300
committerSasha Levin <sasha.levin@oracle.com>2015-08-27 20:25:45 +0300
commit1d9103f6387b1174d769e2f87802af1bd8a7563a (patch)
treecaf93ffd91fbb0c1aa446c1aa5f27d654306c5d0
parentba86d5813c5a676d076c2d580ddc1cbb1b013ebf (diff)
downloadlinux-1d9103f6387b1174d769e2f87802af1bd8a7563a.tar.xz
Input: usbtouchscreen - avoid unresponsive TSC-30 touch screen
[ Upstream commit 968491709e5b1aaf429428814fff3d932fa90b60 ] This patch fixes a problem in the usbtouchscreen driver for DMC TSC-30 touch screen. Due to a missing delay between the RESET and SET_RATE commands, the touch screen may become unresponsive during system startup or driver loading. According to the DMC documentation, a delay is needed after the RESET command to allow the chip to complete its internal initialization. As this delay is not guaranteed, we had a system where the touch screen occasionally did not send any touch data. There was no other indication of the problem. The patch fixes the problem by adding a 150ms delay between the RESET and SET_RATE commands. Cc: stable@vger.kernel.org Suggested-by: Jakob Mustafa <jakob.mustafa@bytecmed.com> Signed-off-by: Bernhard Bender <bernhard.bender@bytecmed.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
-rw-r--r--drivers/input/touchscreen/usbtouchscreen.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c
index a0966331a89b..c6f7e918b2b1 100644
--- a/drivers/input/touchscreen/usbtouchscreen.c
+++ b/drivers/input/touchscreen/usbtouchscreen.c
@@ -625,6 +625,9 @@ static int dmc_tsc10_init(struct usbtouch_usb *usbtouch)
goto err_out;
}
+ /* TSC-25 data sheet specifies a delay after the RESET command */
+ msleep(150);
+
/* set coordinate output rate */
buf[0] = buf[1] = 0xFF;
ret = usb_control_msg(dev, usb_rcvctrlpipe (dev, 0),