diff options
author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2021-10-29 13:56:17 +0300 |
---|---|---|
committer | Thierry Reding <thierry.reding@gmail.com> | 2021-11-17 19:13:02 +0300 |
commit | 0ee11b87c38b64c693881a53969056e16a03fcd1 (patch) | |
tree | f7eed799463f076d2a5a8e61b6247b05ffa9b9d3 | |
parent | 5e93d7782f7fda242e0e696da918f720660854bf (diff) | |
download | linux-0ee11b87c38b64c693881a53969056e16a03fcd1.tar.xz |
pwm: img: Implement .apply() callback
To eventually get rid of all legacy drivers convert this driver to the
modern world implementing .apply(). This just pushes down a slightly
optimized variant of how legacy drivers are handled in the core.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tested-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
-rw-r--r-- | drivers/pwm/pwm-img.c | 29 |
1 files changed, 26 insertions, 3 deletions
diff --git a/drivers/pwm/pwm-img.c b/drivers/pwm/pwm-img.c index f97f82548293..1f3d6346ab86 100644 --- a/drivers/pwm/pwm-img.c +++ b/drivers/pwm/pwm-img.c @@ -184,10 +184,33 @@ static void img_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm) pm_runtime_put_autosuspend(chip->dev); } +static int img_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, + const struct pwm_state *state) +{ + int err; + + if (state->polarity != PWM_POLARITY_NORMAL) + return -EINVAL; + + if (!state->enabled) { + if (pwm->state.enabled) + img_pwm_disable(chip, pwm); + + return 0; + } + + err = img_pwm_config(pwm->chip, pwm, state->duty_cycle, state->period); + if (err) + return err; + + if (!pwm->state.enabled) + err = img_pwm_enable(chip, pwm); + + return err; +} + static const struct pwm_ops img_pwm_ops = { - .config = img_pwm_config, - .enable = img_pwm_enable, - .disable = img_pwm_disable, + .apply = img_pwm_apply, .owner = THIS_MODULE, }; |