summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJens Axboe <axboe@fb.com>2014-08-29 01:05:40 +0400
committerJens Axboe <axboe@fb.com>2014-08-29 18:34:14 +0400
commit55872c5a3c01f0fe7b5298d19e24e237f5b5ff06 (patch)
treee1747d5c4a677f2266388eccf4f03c772a786345
parenta492f075450f3ba87de36e5ffe92a9d0c7af9723 (diff)
downloadlinux-55872c5a3c01f0fe7b5298d19e24e237f5b5ff06.tar.xz
bsg: fix potential error pointer dereference
Dan writes: block/bsg.c:327 bsg_map_hdr() error: 'next_rq' dereferencing possible ERR_PTR(). Fix this by setting next_rq to NULL, for the case where it can be != NULL but an error pointer. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Jens Axboe <axboe@fb.com>
-rw-r--r--block/bsg.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/block/bsg.c b/block/bsg.c
index 73c78fd12cc1..276e869e686c 100644
--- a/block/bsg.c
+++ b/block/bsg.c
@@ -287,6 +287,7 @@ bsg_map_hdr(struct bsg_device *bd, struct sg_io_v4 *hdr, fmode_t has_write_perm,
next_rq = blk_get_request(q, READ, GFP_KERNEL);
if (IS_ERR(next_rq)) {
ret = PTR_ERR(next_rq);
+ next_rq = NULL;
goto out;
}
rq->next_rq = next_rq;