summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarco Stornelli <marco.stornelli@gmail.com>2011-03-05 13:10:19 +0300
committerAl Viro <viro@zeniv.linux.org.uk>2011-03-10 12:22:15 +0300
commit1ca551c6caae7b52178555cdedea6ca26444be46 (patch)
treecbe1a838712a092f7abe49920a09188ec2403578
parent991ac30d8b30ab6051dff5a7b07d84e6f5efa3a6 (diff)
downloadlinux-1ca551c6caae7b52178555cdedea6ca26444be46.tar.xz
Check for immutable/append flag in fallocate path
In the fallocate path the kernel doesn't check for the immutable/append flag. It's possible to have a race condition in this scenario: an application open a file in read/write and it does something, meanwhile root set the immutable flag on the file, the application at that point can call fallocate with success. In addition, we don't allow to do any unreserve operation on an append only file but only the reserve one. Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
-rw-r--r--fs/open.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/fs/open.c b/fs/open.c
index 5a2c6ebc22b5..b47aab39c057 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -233,6 +233,14 @@ int do_fallocate(struct file *file, int mode, loff_t offset, loff_t len)
if (!(file->f_mode & FMODE_WRITE))
return -EBADF;
+
+ /* It's not possible punch hole on append only file */
+ if (mode & FALLOC_FL_PUNCH_HOLE && IS_APPEND(inode))
+ return -EPERM;
+
+ if (IS_IMMUTABLE(inode))
+ return -EPERM;
+
/*
* Revalidate the write permissions, in case security policy has
* changed since the files were opened.