diff options
| author | Pavel Begunkov <asml.silence@gmail.com> | 2021-04-15 15:40:50 +0300 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2021-04-18 04:19:41 +0300 |
| commit | c82d5bc703825a47af5c600e82e1e0c1db49e036 (patch) | |
| tree | 36862811bfb7a988dcbe6a81fe1814b0b4e5dcb7 | |
| parent | a7be7c23cfdd2cb57609fd2d607923a9cb2a305d (diff) | |
| download | linux-c82d5bc703825a47af5c600e82e1e0c1db49e036.tar.xz | |
io_uring: don't fail submit with overflow backlog
Don't fail submission attempts if there are CQEs in the overflow
backlog, but give away the decision making to the userspace. It
might be very inconvenient to the userspace, especially if
submission and completion are done by different threads.
We can remove it because of recent changes, where requests
are now not locked by the backlog, backlog entries are allocated
separately, so they take less space and cgroup accounted.
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | fs/io_uring.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/fs/io_uring.c b/fs/io_uring.c index 55892e0227dd..81bfe91aed0a 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -6664,12 +6664,6 @@ static int io_submit_sqes(struct io_ring_ctx *ctx, unsigned int nr) { int submitted = 0; - /* if we have a backlog and couldn't flush it all, return BUSY */ - if (test_bit(0, &ctx->sq_check_overflow)) { - if (!__io_cqring_overflow_flush(ctx, false)) - return -EBUSY; - } - /* make sure SQ entry isn't read before tail */ nr = min3(nr, ctx->sq_entries, io_sqring_entries(ctx)); |