diff options
author | Dmitry Torokhov <dtor@chromium.org> | 2014-11-15 00:39:05 +0300 |
---|---|---|
committer | Ben Hutchings <ben@decadent.org.uk> | 2015-01-01 04:27:49 +0300 |
commit | 3e6b2cfaf3aec080122fc0eecf2573364beaba61 (patch) | |
tree | fcbcc8c8b997b4da3d6631c6226048435995bcaf | |
parent | c310193a1731d74b5b95d8608a79eb4c08685284 (diff) | |
download | linux-3e6b2cfaf3aec080122fc0eecf2573364beaba61.tar.xz |
sata_fsl: fix error handling of irq_of_parse_and_map
commit aad0b624129709c94c2e19e583b6053520353fa8 upstream.
irq_of_parse_and_map() returns 0 on error (the result is unsigned int),
so testing for negative result never works.
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
-rw-r--r-- | drivers/ata/sata_fsl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c index 78ae7b67b09e..54702f84dbc3 100644 --- a/drivers/ata/sata_fsl.c +++ b/drivers/ata/sata_fsl.c @@ -1338,7 +1338,7 @@ static int sata_fsl_probe(struct platform_device *ofdev) host_priv->csr_base = csr_base; irq = irq_of_parse_and_map(ofdev->dev.of_node, 0); - if (irq < 0) { + if (!irq) { dev_err(&ofdev->dev, "invalid irq from platform\n"); goto error_exit_with_cleanup; } |