diff options
author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2020-01-31 09:13:51 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-02-15 00:32:08 +0300 |
commit | 06495469423cd58f1801c80aeb30a17dcfb16e67 (patch) | |
tree | 8f31f3fa266bbd29744bb43c56e93ec9b493e096 | |
parent | 48d8bba5e94d87304391438f548cedf30aefa609 (diff) | |
download | linux-06495469423cd58f1801c80aeb30a17dcfb16e67.tar.xz |
lib/test_kasan.c: fix memory leak in kmalloc_oob_krealloc_more()
commit 3e21d9a501bf99aee2e5835d7f34d8c823f115b5 upstream.
In case memory resources for _ptr2_ were allocated, release them before
return.
Notice that in case _ptr1_ happens to be NULL, krealloc() behaves
exactly like kmalloc().
Addresses-Coverity-ID: 1490594 ("Resource leak")
Link: http://lkml.kernel.org/r/20200123160115.GA4202@embeddedor
Fixes: 3f15801cdc23 ("lib: add kasan test module")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | lib/test_kasan.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/lib/test_kasan.c b/lib/test_kasan.c index d6e46dd1350b..1399d1000130 100644 --- a/lib/test_kasan.c +++ b/lib/test_kasan.c @@ -126,6 +126,7 @@ static noinline void __init kmalloc_oob_krealloc_more(void) if (!ptr1 || !ptr2) { pr_err("Allocation failed\n"); kfree(ptr1); + kfree(ptr2); return; } |