diff options
| author | Olliver Schinagl <oliver@schinagl.nl> | 2018-11-26 18:27:44 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-02-13 15:51:15 +0300 |
| commit | cb19da4d5ccfa731bf5dd17e6161b6d7d1b32cbe (patch) | |
| tree | 30e8973e8d94d2d55cbcc663f728bacb79793f10 | |
| parent | a8717b34003f4f7353b23826617ad872f85d85d8 (diff) | |
| download | linux-cb19da4d5ccfa731bf5dd17e6161b6d7d1b32cbe.tar.xz | |
regulator: core: enable power when setting up constraints
[ Upstream commit 2bb1666369339f69f227ad060c250afde94d5c69 ]
When a regulator is marked as always on, it is enabled early on, when
checking and setting up constraints. It makes the assumption that the
bootloader properly initialized the regulator, and just in case enables
the regulator anyway.
Some constraints however currently get missed, such as the soft-start
and ramp-delay. This causes the regulator to be enabled, without the
soft-start and ramp-delay being applied, which in turn can cause
high-currents or other start-up problems.
By moving the always-enabled constraints later in the constraints check,
we can at least ensure all constraints for the regulator are followed.
Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
Signed-off-by: Priit Laes <plaes@plaes.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/regulator/core.c | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index fa8f5fc04d8f..870baa7036ec 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -1142,17 +1142,6 @@ static int set_machine_constraints(struct regulator_dev *rdev) } } - /* If the constraints say the regulator should be on at this point - * and we have control then make sure it is enabled. - */ - if (rdev->constraints->always_on || rdev->constraints->boot_on) { - ret = _regulator_do_enable(rdev); - if (ret < 0 && ret != -EINVAL) { - rdev_err(rdev, "failed to enable\n"); - return ret; - } - } - if ((rdev->constraints->ramp_delay || rdev->constraints->ramp_disable) && ops->set_ramp_delay) { ret = ops->set_ramp_delay(rdev, rdev->constraints->ramp_delay); @@ -1198,6 +1187,17 @@ static int set_machine_constraints(struct regulator_dev *rdev) } } + /* If the constraints say the regulator should be on at this point + * and we have control then make sure it is enabled. + */ + if (rdev->constraints->always_on || rdev->constraints->boot_on) { + ret = _regulator_do_enable(rdev); + if (ret < 0 && ret != -EINVAL) { + rdev_err(rdev, "failed to enable\n"); + return ret; + } + } + print_constraints(rdev); return 0; } |