summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2015-02-02 12:01:45 +0300
committerDavid S. Miller <davem@davemloft.net>2015-02-04 03:22:12 +0300
commit79b7cf60e190efa8f0689b48a45859f5c3534c76 (patch)
tree9d749b7c9cc48bce786997901d476b42f4486407
parent132d7bcafa2ed8e22a31956ff60b3a121e660456 (diff)
downloadlinux-79b7cf60e190efa8f0689b48a45859f5c3534c76.tar.xz
netlabel: Deletion of an unnecessary check before the function call "cipso_v4_doi_putdef"
The cipso_v4_doi_putdef() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Acked-by: Paul Moore <paul@paul-moore.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/netlabel/netlabel_mgmt.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/net/netlabel/netlabel_mgmt.c b/net/netlabel/netlabel_mgmt.c
index 8b3b789c43c2..f5807f57aebc 100644
--- a/net/netlabel/netlabel_mgmt.c
+++ b/net/netlabel/netlabel_mgmt.c
@@ -242,8 +242,7 @@ static int netlbl_mgmt_add_common(struct genl_info *info,
return 0;
add_failure:
- if (cipsov4)
- cipso_v4_doi_putdef(cipsov4);
+ cipso_v4_doi_putdef(cipsov4);
if (entry)
kfree(entry->domain);
kfree(addrmap);