summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorWang ShaoBo <bobo.shaobowang@huawei.com>2022-11-10 14:38:23 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-11-25 19:45:46 +0300
commit709aa1f73d3e9e9ea16e2c4e44f2874c5d2c382c (patch)
tree67e4890af0285d8391520ecf58c795fd313f04df
parent417f2d2edf30a443189b8c6c820da991133f27cf (diff)
downloadlinux-709aa1f73d3e9e9ea16e2c4e44f2874c5d2c382c.tar.xz
mISDN: fix misuse of put_device() in mISDN_register_device()
[ Upstream commit 2d25107e111a85c56f601a5470f1780ec054e6ac ] We should not release reference by put_device() before calling device_initialize(). Fixes: e7d1d4d9ac0d ("mISDN: fix possible memory leak in mISDN_register_device()") Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--drivers/isdn/mISDN/core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/isdn/mISDN/core.c b/drivers/isdn/mISDN/core.c
index 7ea0100f218a..90ee56d07a6e 100644
--- a/drivers/isdn/mISDN/core.c
+++ b/drivers/isdn/mISDN/core.c
@@ -222,7 +222,7 @@ mISDN_register_device(struct mISDNdevice *dev,
err = get_free_devid();
if (err < 0)
- goto error1;
+ return err;
dev->id = err;
device_initialize(&dev->dev);