diff options
| author | Pavel Skripkin <paskripkin@gmail.com> | 2021-07-13 13:58:53 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-07-25 15:35:15 +0300 |
| commit | 04b06716838bfc26742dbed3ae1d3697fe5317ee (patch) | |
| tree | 99be67885bbd82e5d0b675cb295a0cd2c6fd6771 | |
| parent | 8aa13a86964cdec4fd969ef677c6614ff068641a (diff) | |
| download | linux-04b06716838bfc26742dbed3ae1d3697fe5317ee.tar.xz | |
net: fddi: fix UAF in fza_probe
commit deb7178eb940e2c5caca1b1db084a69b2e59b4c9 upstream.
fp is netdev private data and it cannot be
used after free_netdev() call. Using fp after free_netdev()
can cause UAF bug. Fix it by moving free_netdev() after error message.
Fixes: 61414f5ec983 ("FDDI: defza: Add support for DEC FDDIcontroller 700
TURBOchannel adapter")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/net/fddi/defza.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/fddi/defza.c b/drivers/net/fddi/defza.c index 060712c666bf..83e4c5192f35 100644 --- a/drivers/net/fddi/defza.c +++ b/drivers/net/fddi/defza.c @@ -1504,9 +1504,8 @@ err_out_resource: release_mem_region(start, len); err_out_kfree: - free_netdev(dev); - pr_err("%s: initialization failure, aborting!\n", fp->name); + free_netdev(dev); return ret; } |