diff options
| author | Paulo Alcantara <pc@manguebit.com> | 2024-04-02 22:34:00 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-04-10 17:38:21 +0300 |
| commit | 16d58c6a7db5050b9638669084b63fc05f951825 (patch) | |
| tree | 53ae5e5a6b5a2c29a52f8a8f9d6def682601fdf2 | |
| parent | a8344e2b69bde63f713b0aa796d70dbeadffddfb (diff) | |
| download | linux-16d58c6a7db5050b9638669084b63fc05f951825.tar.xz | |
smb: client: fix potential UAF in is_valid_oplock_break()
commit 69ccf040acddf33a3a85ec0f6b45ef84b0f7ec29 upstream.
Skip sessions that are being teared down (status == SES_EXITING) to
avoid UAF.
Cc: stable@vger.kernel.org
Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | fs/smb/client/misc.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/smb/client/misc.c b/fs/smb/client/misc.c index df65cef63afb..74627d647818 100644 --- a/fs/smb/client/misc.c +++ b/fs/smb/client/misc.c @@ -484,6 +484,8 @@ is_valid_oplock_break(char *buffer, struct TCP_Server_Info *srv) /* look up tcon based on tid & uid */ spin_lock(&cifs_tcp_ses_lock); list_for_each_entry(ses, &pserver->smb_ses_list, smb_ses_list) { + if (cifs_ses_exiting(ses)) + continue; list_for_each_entry(tcon, &ses->tcon_list, tcon_list) { if (tcon->tid != buf->Tid) continue; |