diff options
| author | Christian Brauner <brauner@kernel.org> | 2024-05-27 15:15:22 +0300 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2024-05-28 15:32:42 +0300 |
| commit | 0c07c273a5fe1a25d4f477fe7edf64b3e8b19b3d (patch) | |
| tree | 254f04de3110f8eae14bc01ea2a5c02d14360586 | |
| parent | 2bfcfd584ff5ccc8bb7acde19b42570414bf880b (diff) | |
| download | linux-0c07c273a5fe1a25d4f477fe7edf64b3e8b19b3d.tar.xz | |
debugfs: continue to ignore unknown mount options
Wolfram reported that debugfs remained empty on some of his boards
triggering the message "debugfs: Unknown parameter 'auto'".
The root of the issue is that we ignored unknown mount options in the
old mount api but we started rejecting unknown mount options in the new
mount api. Continue to ignore unknown mount options to not regress
userspace.
Fixes: a20971c18752 ("vfs: Convert debugfs to use the new mount API")
Link: https://lore.kernel.org/r/20240527100618.np2wqiw5mz7as3vk@ninjato
Reported-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
| -rw-r--r-- | fs/debugfs/inode.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c index dc51df0b118d..8fd928899a59 100644 --- a/fs/debugfs/inode.c +++ b/fs/debugfs/inode.c @@ -107,8 +107,16 @@ static int debugfs_parse_param(struct fs_context *fc, struct fs_parameter *param int opt; opt = fs_parse(fc, debugfs_param_specs, param, &result); - if (opt < 0) + if (opt < 0) { + /* + * We might like to report bad mount options here; but + * traditionally debugfs has ignored all mount options + */ + if (opt == -ENOPARAM) + return 0; + return opt; + } switch (opt) { case Opt_uid: |