summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJosh Kilmer <srjek2@gmail.com>2022-07-28 20:51:11 +0300
committerJiri Kosina <jkosina@suse.cz>2022-08-25 12:31:41 +0300
commit1c0cc9d11c665020cbeb80e660fb8929164407f4 (patch)
tree77585dfe47e52bde7c7f49e72ef9ae3533add68d
parenta5623a203cffe2d2b84d2f6c989d9017db1856af (diff)
downloadlinux-1c0cc9d11c665020cbeb80e660fb8929164407f4.tar.xz
HID: asus: ROG NKey: Ignore portion of 0x5a report
On an Asus G513QY, of the 5 bytes in a 0x5a report, only the first byte is a meaningful keycode. The other bytes are zeroed out or hold garbage from the last packet sent to the keyboard. This patch fixes up the report descriptor for this event so that the general hid code will only process 1 byte for keycodes, avoiding spurious key events and unmapped Asus vendor usagepage code warnings. Signed-off-by: Josh Kilmer <srjek2@gmail.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
-rw-r--r--drivers/hid/hid-asus.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index 08c9a9a60ae4..b59c3dafa6a4 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -1212,6 +1212,13 @@ static __u8 *asus_report_fixup(struct hid_device *hdev, __u8 *rdesc,
rdesc = new_rdesc;
}
+ if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD &&
+ *rsize == 331 && rdesc[190] == 0x85 && rdesc[191] == 0x5a &&
+ rdesc[204] == 0x95 && rdesc[205] == 0x05) {
+ hid_info(hdev, "Fixing up Asus N-KEY keyb report descriptor\n");
+ rdesc[205] = 0x01;
+ }
+
return rdesc;
}