diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-03-22 20:02:14 +0300 |
|---|---|---|
| committer | Thierry Reding <treding@nvidia.com> | 2023-04-04 15:24:40 +0300 |
| commit | 30d92e0fcd902bb8b1e465f5a0c7ea9596a9e381 (patch) | |
| tree | 0f512dce509908b2f2e2aa7b90d6e28a834b8f24 | |
| parent | 437405403ab4496cee65add5733f45a40b08c8c8 (diff) | |
| download | linux-30d92e0fcd902bb8b1e465f5a0c7ea9596a9e381.tar.xz | |
drm/tegra: dc: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <treding@nvidia.com>
| -rw-r--r-- | drivers/gpu/drm/tegra/dc.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c index 6bf1b2bc43b1..53630b673029 100644 --- a/drivers/gpu/drm/tegra/dc.c +++ b/drivers/gpu/drm/tegra/dc.c @@ -3263,7 +3263,7 @@ disable_pm: return err; } -static int tegra_dc_remove(struct platform_device *pdev) +static void tegra_dc_remove(struct platform_device *pdev) { struct tegra_dc *dc = platform_get_drvdata(pdev); @@ -3272,8 +3272,6 @@ static int tegra_dc_remove(struct platform_device *pdev) tegra_dc_rgb_remove(dc); pm_runtime_disable(&pdev->dev); - - return 0; } struct platform_driver tegra_dc_driver = { @@ -3282,5 +3280,5 @@ struct platform_driver tegra_dc_driver = { .of_match_table = tegra_dc_of_match, }, .probe = tegra_dc_probe, - .remove = tegra_dc_remove, + .remove_new = tegra_dc_remove, }; |