diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2024-03-29 13:35:40 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-05-30 10:49:52 +0300 |
| commit | 32db1047161806460b4b4066da1b32c9a8b46e4d (patch) | |
| tree | 5e05a68c7de512257b8be44cbba3a8bbee31daaa | |
| parent | 29aa8e4dff9b3e68af891c17f436ed56dab39a4d (diff) | |
| download | linux-32db1047161806460b4b4066da1b32c9a8b46e4d.tar.xz | |
pwm: Fix setting period with #pwm-cells = <1> and of_pwm_single_xlate()
[ Upstream commit 73dfe970c038d0548beccc5bfb2707e1d543b01f ]
For drivers making use of of_pwm_single_xlate() (i.e. those that don't
pass a hwpwm index) and also don't pass flags, setting period was
wrongly skipped. This affects the pwm-pxa and ti-sn65dsi86 drivers.
Reported-by: Karel Balej <balejk@matfyz.cz>
Link: https://lore.kernel.org/r/D05IVTPYH35N.2CLDG6LSILRSN@matfyz.cz
Fixes: 40ade0c2e794 ("pwm: Let the of_xlate callbacks accept references without period")
Tested-by: Karel Balej <balejk@matfyz.cz>
Link: https://lore.kernel.org/r/20240329103544.545290-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/pwm/core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 830a697826af..9d2dc5e1c8aa 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -443,7 +443,7 @@ of_pwm_single_xlate(struct pwm_chip *chip, const struct of_phandle_args *args) if (IS_ERR(pwm)) return pwm; - if (args->args_count > 1) + if (args->args_count > 0) pwm->args.period = args->args[0]; pwm->args.polarity = PWM_POLARITY_NORMAL; |