summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZhang Qilong <zhangqilong3@huawei.com>2020-11-03 17:13:23 +0300
committerMark Brown <broonie@kernel.org>2020-11-09 22:44:28 +0300
commit3482e797ab688da6703fe18d8bad52f94199f4f2 (patch)
treeeafeac7e54a48e423e92a3c794af250739f70d1e
parent763eab7074f6e71babd85d796156f05a675f9510 (diff)
downloadlinux-3482e797ab688da6703fe18d8bad52f94199f4f2.tar.xz
spi: tegra20-sflash: fix reference leak in tegra_sflash_resume
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to pm_runtime_put_noidle will result in reference leak in tegra_sflash_resume, so we should fix it. Fixes: 8528547bcc336 ("spi: tegra: add spi driver for sflash controller") Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com> Link: https://lore.kernel.org/r/20201103141323.5841-1-zhangqilong3@huawei.com Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r--drivers/spi/spi-tegra20-sflash.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/spi/spi-tegra20-sflash.c b/drivers/spi/spi-tegra20-sflash.c
index b59015c7c8a8..cfb7de737937 100644
--- a/drivers/spi/spi-tegra20-sflash.c
+++ b/drivers/spi/spi-tegra20-sflash.c
@@ -552,6 +552,7 @@ static int tegra_sflash_resume(struct device *dev)
ret = pm_runtime_get_sync(dev);
if (ret < 0) {
+ pm_runtime_put_noidle(dev);
dev_err(dev, "pm runtime failed, e = %d\n", ret);
return ret;
}