summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLiang He <windhl@126.com>2022-07-19 11:56:40 +0300
committerKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>2022-08-16 12:12:06 +0300
commit48af14fb0eaa63d9aa68f59fb0b205ec55a95636 (patch)
tree79009adaf4aea6dd53c18a344b1ba4536ccb8780
parent05215fb32010d4afb68fbdbb4d237df6e2d4567b (diff)
downloadlinux-48af14fb0eaa63d9aa68f59fb0b205ec55a95636.tar.xz
memory: of: Fix refcount leak bug in of_lpddr3_get_ddr_timings()
We should add the of_node_put() when breaking out of for_each_child_of_node() as it will automatically increase and decrease the refcount. Fixes: 976897dd96db ("memory: Extend of_memory with LPDDR3 support") Signed-off-by: Liang He <windhl@126.com> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20220719085640.1210583-2-windhl@126.com
-rw-r--r--drivers/memory/of_memory.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/memory/of_memory.c b/drivers/memory/of_memory.c
index 8e2ef4bf6b17..fcd20d85d385 100644
--- a/drivers/memory/of_memory.c
+++ b/drivers/memory/of_memory.c
@@ -285,6 +285,7 @@ const struct lpddr3_timings
if (of_device_is_compatible(np_tim, tim_compat)) {
if (of_lpddr3_do_get_timings(np_tim, &timings[i])) {
devm_kfree(dev, timings);
+ of_node_put(np_tim);
goto default_timings;
}
i++;