diff options
| author | Miquel Raynal <miquel.raynal@bootlin.com> | 2020-05-19 15:59:56 +0300 |
|---|---|---|
| committer | Miquel Raynal <miquel.raynal@bootlin.com> | 2020-05-31 11:53:34 +0300 |
| commit | 5f3bce3a52758227e2a0b51531b9c0b7069d1724 (patch) | |
| tree | 5d6631f89c73acea716ae6d61fdb93b23c112e45 | |
| parent | 28dcc4e8a8318beb77a7b42bccb9ed57707c546d (diff) | |
| download | linux-5f3bce3a52758227e2a0b51531b9c0b7069d1724.tar.xz | |
mtd: rawnand: lpc32xx_mlc: Stop using nand_release()
This helper is not very useful and very often people get confused:
they use nand_release() instead of nand_cleanup().
Let's stop using nand_release() by calling mtd_device_unregister() and
nand_cleanup() directly.
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-24-miquel.raynal@bootlin.com
| -rw-r--r-- | drivers/mtd/nand/raw/lpc32xx_mlc.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/mtd/nand/raw/lpc32xx_mlc.c b/drivers/mtd/nand/raw/lpc32xx_mlc.c index 241b58b83240..7521038af2ef 100644 --- a/drivers/mtd/nand/raw/lpc32xx_mlc.c +++ b/drivers/mtd/nand/raw/lpc32xx_mlc.c @@ -826,8 +826,13 @@ free_gpio: static int lpc32xx_nand_remove(struct platform_device *pdev) { struct lpc32xx_nand_host *host = platform_get_drvdata(pdev); + struct nand_chip *chip = &host->nand_chip; + int ret; + + ret = mtd_device_unregister(nand_to_mtd(chip)); + WARN_ON(ret); + nand_cleanup(chip); - nand_release(&host->nand_chip); free_irq(host->irq, host); if (use_dma) dma_release_channel(host->dma_chan); |