summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorValdis.Kletnieks@vt.edu <Valdis.Kletnieks@vt.edu>2014-12-10 00:15:50 +0300
committerDavid S. Miller <davem@davemloft.net>2014-12-10 05:49:09 +0300
commit69204cf7eb9c5a72067ce6922d4699378251d053 (patch)
tree38a2c1030456f342246379867ec6883c3ac21105
parent11d3d2a16cc1f05c6ece69a4392e99efb85666a6 (diff)
downloadlinux-69204cf7eb9c5a72067ce6922d4699378251d053.tar.xz
net: fix suspicious rcu_dereference_check in net/sched/sch_fq_codel.c
commit 46e5da40ae (net: qdisc: use rcu prefix and silence sparse warnings) triggers a spurious warning: net/sched/sch_fq_codel.c:97 suspicious rcu_dereference_check() usage! The code should be using the _bh variant of rcu_dereference. Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu> Acked-by: Eric Dumazet <edumazet@google.com> Acked-by: John Fastabend <john.r.fastabend@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/sched/sch_fq_codel.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sched/sch_fq_codel.c b/net/sched/sch_fq_codel.c
index b9ca32ebc1de..1e52decb7b59 100644
--- a/net/sched/sch_fq_codel.c
+++ b/net/sched/sch_fq_codel.c
@@ -94,7 +94,7 @@ static unsigned int fq_codel_classify(struct sk_buff *skb, struct Qdisc *sch,
TC_H_MIN(skb->priority) <= q->flows_cnt)
return TC_H_MIN(skb->priority);
- filter = rcu_dereference(q->filter_list);
+ filter = rcu_dereference_bh(q->filter_list);
if (!filter)
return fq_codel_hash(q, skb) + 1;