summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYang Jihong <yangjihong1@huawei.com>2024-02-06 11:32:28 +0300
committerSasha Levin <sashal@kernel.org>2024-03-27 01:17:04 +0300
commit6a480b3ad283b1691d1940800864abd436c47355 (patch)
tree27d8cebddfee53e43e33df56fada088755be4812
parent082c23a1a3079d7d30de9cbff97d977f8bd0d537 (diff)
downloadlinux-6a480b3ad283b1691d1940800864abd436c47355.tar.xz
perf thread_map: Free strlist on normal path in thread_map__new_by_tid_str()
[ Upstream commit 1eb3d924e3c0b8c27388b0583a989d757866efb6 ] slist needs to be freed in both error path and normal path in thread_map__new_by_tid_str(). Fixes: b52956c961be3a04 ("perf tools: Allow multiple threads or processes in record, stat, top") Reviewed-by: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: Yang Jihong <yangjihong1@huawei.com> Signed-off-by: Namhyung Kim <namhyung@kernel.org> Link: https://lore.kernel.org/r/20240206083228.172607-6-yangjihong1@huawei.com Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--tools/perf/util/thread_map.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/perf/util/thread_map.c b/tools/perf/util/thread_map.c
index e848579e61a8..ea3b431b9783 100644
--- a/tools/perf/util/thread_map.c
+++ b/tools/perf/util/thread_map.c
@@ -280,13 +280,13 @@ struct perf_thread_map *thread_map__new_by_tid_str(const char *tid_str)
threads->nr = ntasks;
}
out:
+ strlist__delete(slist);
if (threads)
refcount_set(&threads->refcnt, 1);
return threads;
out_free_threads:
zfree(&threads);
- strlist__delete(slist);
goto out;
}