diff options
| author | Fedor Pchelkin <pchelkin@ispras.ru> | 2024-05-22 21:13:08 +0300 |
|---|---|---|
| committer | Christian König <christian.koenig@amd.com> | 2024-05-27 17:09:22 +0300 |
| commit | 6cb05d89fd62a76a9b74bd16211fb0930e89fea8 (patch) | |
| tree | b75bce7a956d01221d7555d33afd97963aa4a4f5 | |
| parent | 779aa4d74785078575ee20d05d49e6942d1f2844 (diff) | |
| download | linux-6cb05d89fd62a76a9b74bd16211fb0930e89fea8.tar.xz | |
dma-buf: handle testing kthreads creation failure
kthread creation may possibly fail inside race_signal_callback(). In
such a case stop the already started threads, put the already taken
references to them and return with error code.
Found by Linux Verification Center (linuxtesting.org).
Fixes: 2989f6451084 ("dma-buf: Add selftests for dma-fence")
Cc: stable@vger.kernel.org
Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Reviewed-by: T.J. Mercier <tjmercier@google.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240522181308.841686-1-pchelkin@ispras.ru
Signed-off-by: Christian König <christian.koenig@amd.com>
| -rw-r--r-- | drivers/dma-buf/st-dma-fence.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c index b7c6f7ea9e0c..6a1bfcd0cc21 100644 --- a/drivers/dma-buf/st-dma-fence.c +++ b/drivers/dma-buf/st-dma-fence.c @@ -540,6 +540,12 @@ static int race_signal_callback(void *arg) t[i].before = pass; t[i].task = kthread_run(thread_signal_callback, &t[i], "dma-fence:%d", i); + if (IS_ERR(t[i].task)) { + ret = PTR_ERR(t[i].task); + while (--i >= 0) + kthread_stop_put(t[i].task); + return ret; + } get_task_struct(t[i].task); } |