summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorian Westphal <fw@strlen.de>2020-08-01 17:39:59 +0300
committerDavid S. Miller <davem@davemloft.net>2020-08-01 21:52:55 +0300
commit7126bd5c8bcbc015cf89864cf71d750e8f33f924 (patch)
tree6819266d7ae3d0bb39789db40d73b139e78c1586
parent8b66a6fd34f519f4ad42c4ab0152c3c0782a7dbd (diff)
downloadlinux-7126bd5c8bcbc015cf89864cf71d750e8f33f924.tar.xz
mptcp: fix syncookie build error on UP
kernel test robot says: net/mptcp/syncookies.c: In function 'mptcp_join_cookie_init': include/linux/kernel.h:47:38: warning: division by zero [-Wdiv-by-zero] #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr)) I forgot that spinock_t size is 0 on UP, so ARRAY_SIZE cannot be used. Fixes: 9466a1ccebbe54 ("mptcp: enable JOIN requests even if cookies are in use") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Florian Westphal <fw@strlen.de> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/mptcp/syncookies.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/net/mptcp/syncookies.c b/net/mptcp/syncookies.c
index 6eb992789b50..abe0fd099746 100644
--- a/net/mptcp/syncookies.c
+++ b/net/mptcp/syncookies.c
@@ -125,8 +125,6 @@ void __init mptcp_join_cookie_init(void)
{
int i;
- for (i = 0; i < ARRAY_SIZE(join_entry_locks); i++)
+ for (i = 0; i < COOKIE_JOIN_SLOTS; i++)
spin_lock_init(&join_entry_locks[i]);
-
- BUILD_BUG_ON(ARRAY_SIZE(join_entry_locks) != ARRAY_SIZE(join_entries));
}